X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F55namespaces_cleaned.t;h=a8a966df73a287f4e60d2dcefad371f72bdd3eb5;hb=c1f3f2e8a79c6a4081c9949fa30da09d18d64d3b;hp=85c288b47d380a136b31626d3e328e97056c5975;hpb=a1249d49dffc7703374d3ea8aa3637609f21843e;p=dbsrgits%2FDBIx-Class.git diff --git a/t/55namespaces_cleaned.t b/t/55namespaces_cleaned.t index 85c288b..a8a966d 100644 --- a/t/55namespaces_cleaned.t +++ b/t/55namespaces_cleaned.t @@ -1,28 +1,71 @@ +BEGIN { + if ($] < 5.010) { + + # Pre-5.10 perls pollute %INC on unsuccesfull module + # require, making it appear as if the module is already + # loaded on subsequent require()s + # Can't seem to find the exact RT/perldelta entry + # + # The reason we can't just use a sane, clean loader, is because + # if a Module require()s another module the %INC will still + # get filled with crap and we are back to square one. A global + # fix is really the only way for this test, as we try to load + # each available module separately, and have no control (nor + # knowledge) over their common dependencies. + # + # we want to do this here, in the very beginning, before even + # warnings/strict are loaded + + unshift @INC, 't/lib'; + require DBICTest::Util::OverrideRequire; + + DBICTest::Util::OverrideRequire::override_global_require( sub { + my $res = eval { $_[0]->() }; + if ($@ ne '') { + delete $INC{$_[1]}; + die $@; + } + return $res; + } ); + } +} + use strict; use warnings; use Test::More; +use lib 't/lib'; + +BEGIN { + require DBICTest::RunMode; + plan( skip_all => "Skipping test on plain module install" ) + if DBICTest::RunMode->is_plain; +} + +use DBICTest; use File::Find; use File::Spec; use B qw/svref_2object/; +use Package::Stash; # makes sure we can load at least something use DBIx::Class; +use DBIx::Class::Carp; my @modules = grep { - my $mod = $_; - - # trap deprecation warnings and whatnot - local $SIG{__WARN__} = sub {}; + my ($mod) = $_ =~ /(.+)/; # not all modules are loadable at all times - eval "require $mod" ? $mod : do { - SKIP: { skip "Failed require of $mod: $@", 1 }; - (); + do { + # trap deprecation warnings and whatnot + local $SIG{__WARN__} = sub {}; + eval "require $mod"; + } ? $mod : do { + SKIP: { skip "Failed require of $mod: " . ($@ =~ /^(.+?)$/m)[0], 1 }; + (); # empty RV for @modules }; - } find_modules(); # have an exception table for old and/or weird code we are not sure @@ -38,13 +81,23 @@ my $skip_idx = { map { $_ => 1 } ( # G::L::D is unclean, but we never inherit from it 'DBIx::Class::Admin::Descriptive', 'DBIx::Class::Admin::Usage', + + # this subclass is expected to inherit whatever crap comes + # from the parent + 'DBIx::Class::ResultSet::Pager', + + # utility classes, not part of the inheritance chain + 'DBIx::Class::ResultSource::RowParser::Util', + 'DBIx::Class::_Util', ) }; -my $has_cmop = eval { require Class::MOP }; +my $has_moose = eval { require Moose::Util }; + +Sub::Defer::undefer_all(); # can't use Class::Inspector for the mundane parts as it does not # distinguish imports from anything else, what a crock of... -# Class::MOP is not always available either - hence just do it ourselves +# Moose is not always available either - hence just do it ourselves my $seen; #inheritance means we will see the same method multiple times @@ -52,20 +105,15 @@ for my $mod (@modules) { SKIP: { skip "$mod exempt from namespace checks",1 if $skip_idx->{$mod}; - my %all_method_like = do { - no strict 'refs'; - map { - my $m = $_; - map - { *{"${m}::$_"}{CODE} ? ( $_ => *{"${m}::$_"}{CODE} ) : () } - keys %{"${m}::"} - } (reverse @{mro::get_linear_isa($mod)}); - }; + my %all_method_like = (map + { %{Package::Stash->new($_)->get_all_symbols('CODE')} } + (reverse @{mro::get_linear_isa($mod)}) + ); my %parents = map { $_ => 1 } @{mro::get_linear_isa($mod)}; my %roles; - if ($has_cmop and my $mc = Class::MOP::class_of($mod)) { + if ($has_moose and my $mc = Moose::Util::find_meta($mod)) { if ($mc->can('calculate_all_roles_with_inheritance')) { $roles{$_->name} = 1 for ($mc->calculate_all_roles_with_inheritance); } @@ -73,18 +121,18 @@ for my $mod (@modules) { for my $name (keys %all_method_like) { - # overload is a funky thing - it is neither cleaned, and its imports are named funny + # overload is a funky thing - it is not cleaned, and its imports are named funny next if $name =~ /^\(/; my $gv = svref_2object($all_method_like{$name})->GV; my $origin = $gv->STASH->NAME; - next if $seen->{"${origin}:${name}"}++; + is ($gv->NAME, $name, "Properly named $name method at $origin" . ($origin eq $mod + ? '' + : " (inherited by $mod)" + )); - TODO: { - local $TODO = 'CAG does not clean its BEGIN constants' if $name =~ /^__CAG_/; - is ($gv->NAME, $name, "Properly named $name method at $origin"); - } + next if $seen->{"${origin}:${name}"}++; if ($origin eq $mod) { pass ("$name is a native $mod method"); @@ -103,10 +151,38 @@ for my $mod (@modules) { last; } } - fail ("${mod}::${name} appears to have entered inheritance chain by import into " + + # exception time + if ( + ( $name eq 'import' and $via = 'Exporter' ) + ) { + pass("${mod}::${name} is a valid uncleaned import from ${name}"); + } + else { + fail ("${mod}::${name} appears to have entered inheritance chain by import into " + . ($via || 'UNKNOWN') + ); + } + } + } + + # some common import names (these should never ever be methods) + for my $f (qw/carp carp_once carp_unique croak confess cluck try catch finally/) { + if ($mod->can($f)) { + my $via; + for (reverse @{mro::get_linear_isa($mod)} ) { + if ( ($_->can($f)||'') eq $all_method_like{$f} ) { + $via = $_; + last; + } + } + fail ("Import $f leaked into method list of ${mod}, appears to have entered inheritance chain at " . ($via || 'UNKNOWN') ); } + else { + pass ("Import $f not leaked into method list of $mod"); + } } } } @@ -127,5 +203,4 @@ sub find_modules { return sort @modules; } - done_testing;