X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F55namespaces_cleaned.t;h=5b147d431498074c0bb5bd023cd0cf8b6402567a;hb=ghpr%2Fclosed%2Finspiring_eef9b484;hp=b7d81a839957fb17672a0c2ced06df5cc440549a;hpb=0d8817bcb744bb46adf787f359f34e49b092d42e;p=dbsrgits%2FDBIx-Class-Historic.git diff --git a/t/55namespaces_cleaned.t b/t/55namespaces_cleaned.t index b7d81a8..5b147d4 100644 --- a/t/55namespaces_cleaned.t +++ b/t/55namespaces_cleaned.t @@ -79,6 +79,10 @@ my $skip_idx = { map { $_ => 1 } ( # this subclass is expected to inherit whatever crap comes # from the parent 'DBIx::Class::ResultSet::Pager', + + # utility classes, not part of the inheritance chain + 'DBIx::Class::ResultSource::RowParser::Util', + 'DBIx::Class::_Util', ) }; my $has_cmop = eval { require Class::MOP }; @@ -117,17 +121,10 @@ for my $mod (@modules) { my $gv = svref_2object($all_method_like{$name})->GV; my $origin = $gv->STASH->NAME; - TODO: { - local $TODO; - if ($name =~ /^__CAG_/) { - $TODO = 'CAG does not clean its BEGIN constants'; - } - - is ($gv->NAME, $name, "Properly named $name method at $origin" . ($origin eq $mod - ? '' - : " (inherited by $mod)" - )); - } + is ($gv->NAME, $name, "Properly named $name method at $origin" . ($origin eq $mod + ? '' + : " (inherited by $mod)" + )); next if $seen->{"${origin}:${name}"}++;