X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F52leaks.t;h=ea055a607b66c4cd570f2bcfbe65dd5c294aa221;hb=2b3fc4088d96e40ac23b3871b26d4a1faff17aed;hp=6d3c53fdf4885f763c5bae84ce7ea51de55e319e;hpb=66917da3d4982b89c8ba4ed97fa9fb8bc4539171;p=dbsrgits%2FDBIx-Class-Historic.git diff --git a/t/52leaks.t b/t/52leaks.t index 6d3c53f..ea055a6 100644 --- a/t/52leaks.t +++ b/t/52leaks.t @@ -35,41 +35,41 @@ if ($ENV{DBICTEST_IN_PERSISTENT_ENV}) { use lib qw(t/lib); use DBICTest::RunMode; +use DBIx::Class; +use B 'svref_2object'; BEGIN { plan skip_all => "Your perl version $] appears to leak like a sieve - skipping test" - if DBICTest::RunMode->peepeeness; + if DBIx::Class::_ENV_::PEEPEENESS; } use Scalar::Util qw/refaddr reftype weaken/; -use Carp qw/longmess/; -use Try::Tiny; - -my $have_test_cycle; -BEGIN { - require DBIx::Class::Optional::Dependencies; - $have_test_cycle = DBIx::Class::Optional::Dependencies->req_ok_for ('test_leaks') - and import Test::Memory::Cycle; -} # this is what holds all weakened refs to be checked for leakage my $weak_registry = {}; +# whether or to invoke IC::DT +my $has_dt; + # Skip the heavy-duty leak tracing when just doing an install unless (DBICTest::RunMode->is_plain) { - # Some modules are known to install singletons on-load - # Load them before we swap out $bless_override - require DBI; - require DBD::SQLite; - require Errno; - require Class::Struct; - require FileHandle; - require Hash::Merge; - require Storable; + # have our own little stack maker - Carp infloops due to the bless override + my $trace = sub { + my $depth = 1; + my (@stack, @frame); + + while (@frame = caller($depth++)) { + push @stack, [@frame[3,1,2]]; + } + + $stack[0][0] = ''; + return join "\tinvoked as ", map { sprintf ("%s at %s line %d\n", @$_ ) } @stack; + }; + + # redefine the bless override so that we can catch each and every object created no warnings qw/redefine once/; no strict qw/refs/; - # redefine the bless override so that we can catch each and every object created $bless_override = sub { my $obj = CORE::bless( @@ -88,26 +88,41 @@ unless (DBICTest::RunMode->is_plain) { ); # weaken immediately to avoid weird side effects - $weak_registry->{$slot} = { weakref => $obj, strace => longmess() }; + $weak_registry->{$slot} = { weakref => $obj, strace => $trace->() }; weaken $weak_registry->{$slot}{weakref}; return $obj; }; + require Try::Tiny; for my $func (qw/try catch finally/) { my $orig = \&{"Try::Tiny::$func"}; *{"Try::Tiny::$func"} = sub (&;@) { my $slot = sprintf ('CODE(0x%x)', refaddr $_[0]); - $weak_registry->{$slot} = { weakref => $_[0], strace => longmess() }; + $weak_registry->{$slot} = { weakref => $_[0], strace => $trace->() }; weaken $weak_registry->{$slot}{weakref}; goto $orig; } } + + # Some modules are known to install singletons on-load + # Load them and empty the registry + + # this loads the DT armada + $has_dt = DBIx::Class::Optional::Dependencies->req_ok_for('test_dt_sqlite'); + + require Errno; + require DBI; + require DBD::SQLite; + require FileHandle; + + %$weak_registry = (); } +my @compose_ns_classes; { use_ok ('DBICTest'); @@ -115,6 +130,8 @@ unless (DBICTest::RunMode->is_plain) { my $rs = $schema->resultset ('Artist'); my $storage = $schema->storage; + @compose_ns_classes = map { "DBICTest::${_}" } keys %{$schema->source_registrations}; + ok ($storage->connected, 'we are connected'); my $row_obj = $rs->search({}, { rows => 1})->next; # so that commits/rollbacks work @@ -162,9 +179,43 @@ unless (DBICTest::RunMode->is_plain) { $schema->txn_rollback; } + # prefetching + my $cds_rs = $schema->resultset('CD'); + my $cds_with_artist = $cds_rs->search({}, { prefetch => 'artist' }); + my $cds_with_tracks = $cds_rs->search({}, { prefetch => 'tracks' }); + my $cds_with_stuff = $cds_rs->search({}, { prefetch => [ 'genre', { artist => { cds => { tracks => 'cd_single' } } } ] }); + + # implicit pref + my $cds_with_impl_artist = $cds_rs->search({}, { columns => [qw/me.title artist.name/], join => 'artist' }); + + # get_column + my $getcol_rs = $cds_rs->get_column('me.cdid'); + my $pref_getcol_rs = $cds_with_stuff->get_column('me.cdid'); + + # fire the column getters + my @throwaway = $pref_getcol_rs->all; + my $base_collection = { resultset => $rs, + pref_precursor => $cds_rs, + + pref_rs_single => $cds_with_artist, + pref_rs_multi => $cds_with_tracks, + pref_rs_nested => $cds_with_stuff, + + pref_rs_implicit => $cds_with_impl_artist, + + pref_row_single => $cds_with_artist->next, + pref_row_multi => $cds_with_tracks->next, + pref_row_nested => $cds_with_stuff->next, + + # even though this does not leak Storable croaks on it :((( + #pref_row_implicit => $cds_with_impl_artist->next, + + get_column_rs_plain => $getcol_rs, + get_column_rs_pref => $pref_getcol_rs, + # twice so that we make sure only one H::M object spawned chained_resultset => $rs->search_rs ({}, { '+columns' => [ 'foo' ] } ), chained_resultset2 => $rs->search_rs ({}, { '+columns' => [ 'bar' ] } ), @@ -175,24 +226,46 @@ unless (DBICTest::RunMode->is_plain) { result_source_handle => $rs->result_source->handle, - fresh_pager => $rs->page(5)->pager, - pager => $pager, pager_explicit_count => $pager_explicit_count, - }; + require Storable; %$base_collection = ( %$base_collection, refrozen => Storable::dclone( $base_collection ), rerefrozen => Storable::dclone( Storable::dclone( $base_collection ) ), + pref_row_implicit => $cds_with_impl_artist->next, schema => $schema, storage => $storage, sql_maker => $storage->sql_maker, dbh => $storage->_dbh, + fresh_pager => $rs->page(5)->pager, + pager => $pager, ); - memory_cycle_ok ($base_collection, 'No cycles in the object collection') - if $have_test_cycle; + if ($has_dt) { + my $rs = $base_collection->{icdt_rs} = $schema->resultset('Event'); + + my $now = DateTime->now; + for (1..5) { + $base_collection->{"icdt_row_$_"} = $rs->create({ + created_on => DateTime->new(year => 2011, month => 1, day => $_, time_zone => "-0${_}00" ), + starts_at => $now->clone->add(days => $_), + }); + } + + # re-search + my @dummy = $rs->all; + } + + # dbh's are created in XS space, so pull them separately + for ( grep { defined } map { @{$_->{ChildHandles}} } values %{ {DBI->installed_drivers()} } ) { + $base_collection->{"DBI handle $_"} = $_; + } + + if ( DBIx::Class::Optional::Dependencies->req_ok_for ('test_leaks') ) { + Test::Memory::Cycle::memory_cycle_ok ($base_collection, 'No cycles in the object collection') + } for (keys %$base_collection) { $weak_registry->{"basic $_"} = { weakref => $base_collection->{$_} }; @@ -232,6 +305,7 @@ unless (DBICTest::RunMode->is_plain) { reftype $phantom, refaddr $phantom, ); + $weak_registry->{$slot} = $phantom; weaken $weak_registry->{$slot}; } @@ -243,44 +317,54 @@ unless (DBICTest::RunMode->is_plain) { # Naturally we have some exceptions my $cleared; for my $slot (keys %$weak_registry) { - if ($slot =~ /^\QTest::Builder/) { + if ($slot =~ /^Test::Builder/) { # T::B 2.0 has result objects and other fancyness delete $weak_registry->{$slot}; } - elsif ($slot =~ /^\QSQL::Translator/) { + elsif ($slot =~ /^SQL::Translator/) { # SQLT is a piece of shit, leaks all over delete $weak_registry->{$slot}; } - elsif ($slot =~ /^\QHash::Merge/) { + elsif ($slot =~ /^Hash::Merge/) { # only clear one object of a specific behavior - more would indicate trouble delete $weak_registry->{$slot} unless $cleared->{hash_merge_singleton}{$weak_registry->{$slot}{weakref}{behavior}}++; } - elsif ($slot =~ /^__TxnScopeGuard__FIXUP__/) { + elsif (DBIx::Class::_ENV_::INVISIBLE_DOLLAR_AT and $slot =~ /^__TxnScopeGuard__FIXUP__/) { delete $weak_registry->{$slot} - if $] > 5.013001 and $] < 5.013008; + } + elsif ($slot =~ /^DateTime::TimeZone/) { + # DT is going through a refactor it seems - let it leak zones for now + delete $weak_registry->{$slot}; } } - -# FIXME -# For reasons I can not yet fully understand the table() god-method (located in -# ::ResultSourceProxy::Table) attaches an actual source instance to each class -# as virtually *immortal* class-data. -# For now just ignore these instances manually but there got to be a saner way -for ( map { $_->result_source_instance } ( +# every result class has a result source instance as classdata +# make sure these are all present and distinct before ignoring +# (distinct means only 1 reference) +for my $rs_class ( 'DBICTest::BaseResult', + @compose_ns_classes, map { DBICTest::Schema->class ($_) } DBICTest::Schema->sources -)) { - delete $weak_registry->{$_}; +) { + # need to store the SVref and examine it separately, to push the rsrc instance off the pad + my $SV = svref_2object($rs_class->result_source_instance); + is( $SV->REFCNT, 1, "Source instance of $rs_class referenced exactly once" ); + + # ignore it + delete $weak_registry->{$rs_class->result_source_instance}; } -# FIXME -# same problem goes for the schema - its classdata contains live result source -# objects, which to add insult to the injury are *different* instances from the -# ones we ignored above -for ( values %{DBICTest::Schema->source_registrations || {}} ) { - delete $weak_registry->{$_}; +# Schema classes also hold sources, but these are clones, since +# each source contains the schema (or schema class name in this case) +# Hence the clone so that the same source can be registered with +# multiple schemas +for my $moniker ( keys %{DBICTest::Schema->source_registrations || {}} ) { + + my $SV = svref_2object(DBICTest::Schema->source($moniker)); + is( $SV->REFCNT, 1, "Source instance registered under DBICTest::Schema as $moniker referenced exactly once" ); + + delete $weak_registry->{DBICTest::Schema->source($moniker)}; } for my $slot (sort keys %$weak_registry) { @@ -299,7 +383,6 @@ for my $slot (sort keys %$weak_registry) { }; } - # we got so far without a failure - this is a good thing # now let's try to rerun this script under a "persistent" environment # this is ugly and dirty but we do not yet have a Test::Embedded or