X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F51threadtxn.t;h=1245fab3059e4cab9f5f10c559cd05c1a77d4136;hb=2b3fc4088d96e40ac23b3871b26d4a1faff17aed;hp=e368771584ff64255deb8ba64a67671863f881ab;hpb=be21f2eb5af6b164bf0bff16217fab8a4d039e57;p=dbsrgits%2FDBIx-Class-Historic.git diff --git a/t/51threadtxn.t b/t/51threadtxn.t index e368771..1245fab 100644 --- a/t/51threadtxn.t +++ b/t/51threadtxn.t @@ -12,18 +12,22 @@ BEGIN { } BEGIN { - plan skip_all => 'Minimum of perl 5.8.3 required for thread tests (DBD::Pg mandated)' - if $] < '5.008003'; + plan skip_all => 'Minimum of perl 5.8.5 required for thread tests (DBD::Pg mandated)' + if $] < '5.008005'; } use threads; +use DBIx::Class::Optional::Dependencies (); use lib qw(t/lib); + my ($dsn, $user, $pass) = @ENV{map { "DBICTEST_PG_${_}" } qw/DSN USER PASS/}; plan skip_all => 'Set $ENV{DBICTEST_PG_DSN}, _USER and _PASS to run this test' . ' (note: creates and drops a table named artist!)' unless ($dsn && $user); +plan skip_all => 'Test needs ' . DBIx::Class::Optional::Dependencies->req_missing_for ('rdbms_pg') + unless DBIx::Class::Optional::Dependencies->req_ok_for ('rdbms_pg'); my $num_children = $ENV{DBICTEST_THREAD_STRESS} || 1; if($num_children !~ /^[0-9]+$/ || $num_children < 10) { @@ -32,9 +36,6 @@ if($num_children !~ /^[0-9]+$/ || $num_children < 10) { use_ok('DBICTest::Schema'); -diag "\n\nIt is ok if you see series of 'Attempt to free unreferenced scalar: ...' warnings during this test\n " - if $] < '5.008005'; - my $schema = DBICTest::Schema->connection($dsn, $user, $pass, { AutoCommit => 1, RaiseError => 1, PrintError => 0 }); my $parent_rs;