X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F14roundtrippin.t;h=2dd026b2d737f428a36fbd812cbc27b2eebeffcd;hb=cf5b7ab163f8ac123ebc9bb1156e79646cd5bd2f;hp=7df3010e53504fce36f8cc9ecbe2bd9badfc89fd;hpb=449e13208e09551b354d65df1fa055442be71ad0;p=scpubgit%2FQ-Branch.git

diff --git a/t/14roundtrippin.t b/t/14roundtrippin.t
index 7df3010..2dd026b 100644
--- a/t/14roundtrippin.t
+++ b/t/14roundtrippin.t
@@ -1,9 +1,10 @@
-#!/usr/bin/env perl
+use warnings;
+use strict;
 
 use Test::More;
 use Test::Exception;
 
-use SQL::Abstract::Test import => ['is_same_sql'];
+use SQL::Abstract::Test import => [qw(is_same_sql dumper)];
 use SQL::Abstract::Tree;
 
 my $sqlat = SQL::Abstract::Tree->new;
@@ -11,23 +12,77 @@ my $sqlat = SQL::Abstract::Tree->new;
 my @sql = (
   "INSERT INTO artist DEFAULT VALUES",
   "INSERT INTO artist VALUES ()",
-  "SELECT a, b, c FROM foo WHERE foo.a =1 and foo.b LIKE 'station'",
+  "SELECT a, b, c FROM foo WHERE foo.a = 1 and foo.b LIKE 'station'",
   "SELECT COUNT( * ) FROM foo",
+  "SELECT COUNT( * ), SUM( blah ) FROM foo",
   "SELECT * FROM (SELECT * FROM foobar) WHERE foo.a = 1 and foo.b LIKE 'station'",
-  "SELECT * FROM lolz WHERE ( foo.a =1 ) and foo.b LIKE 'station'",
+  "SELECT * FROM lolz WHERE ( foo.a = 1 ) and foo.b LIKE 'station'",
   "SELECT [screen].[id], [screen].[name], [screen].[section_id], [screen].[xtype] FROM [users_roles] [me] JOIN [roles] [role] ON [role].[id] = [me].[role_id] JOIN [roles_permissions] [role_permissions] ON [role_permissions].[role_id] = [role].[id] JOIN [permissions] [permission] ON [permission].[id] = [role_permissions].[permission_id] JOIN [permissionscreens] [permission_screens] ON [permission_screens].[permission_id] = [permission].[id] JOIN [screens] [screen] ON [screen].[id] = [permission_screens].[screen_id] WHERE ( [me].[user_id] = ? ) GROUP BY [screen].[id], [screen].[name], [screen].[section_id], [screen].[xtype]",
   "SELECT * FROM foo WHERE NOT EXISTS (SELECT bar FROM baz)",
+  "SELECT * FROM (SELECT SUM (CASE WHEN me.artist = 'foo' THEN 1 ELSE 0 END AS artist_sum) FROM foobar) WHERE foo.a = 1 and foo.b LIKE 'station'",
+  "SELECT * FROM (SELECT SUM (CASE WHEN GETUTCDATE() > DATEADD(second, 4 * 60, last_checkin) THEN 1 ELSE 0 END) FROM foobar) WHERE foo.a = 1 and foo.b LIKE 'station'",
+  "SELECT COUNT( * ) FROM foo me JOIN bar rel_bar ON rel_bar.id_bar = me.fk_bar WHERE NOT EXISTS (SELECT inner_baz.id_baz FROM baz inner_baz WHERE ( ( inner_baz.fk_a != ? AND ( fk_bar = me.fk_bar AND name = me.name ) ) ) )",
+  "SELECT foo AS bar FROM baz ORDER BY x + ? DESC, oomph, y - ? DESC, unf, baz.g / ? ASC, buzz * 0 DESC, foo DESC, ickk ASC",
+  "SELECT inner_forum_roles.forum_id FROM forum_roles AS inner_forum_roles LEFT JOIN user_roles AS inner_user_roles USING(user_role_type_id) WHERE inner_user_roles.user_id = users__row.user_id",
+  "SELECT * FROM foo WHERE foo.a @@ to_tsquery('word')",
+  "SELECT * FROM foo ORDER BY name + ?, [me].[id]",
+  "SELECT foo AS bar FROM baz ORDER BY x + ? DESC, baz.g",
+  "SELECT [me].[id], ROW_NUMBER() OVER (ORDER BY (SELECT 1)) AS [rno__row__index] FROM ( SELECT [me].[id] FROM [LogParents] [me]) [me]",
+  # deliberate batshit insanity
+  "SELECT foo FROM bar WHERE > 12",
+  'SELECT ilike_any_or FROM bar WHERE ( baz ILIKE ANY(?) OR bat ILIKE ANY(?) )',
+  'SELECT regexp_or FROM bar WHERE ( baz REGEXP ? OR bat REGEXP ? )',
 );
 
-for (@sql) {
-  # Needs whitespace preservation in the AST to work, pending
-  #local $SQL::Abstract::Test::mysql_functions = 1;
-  is_same_sql ($sqlat->format($_), $_, sprintf 'roundtrip works (%s...)', substr $_, 0, 20);
+# FIXME FIXME FIXME
+# The formatter/unparser accumulated a ton of technical debt,
+# and I don't have time to fix it all :( Some of the problems:
+# - format() does an implicit parenthesis unroll for prettyness
+#   which makes it hard to do exact comparisons
+# - there is no space preservation framework (also makes comparisons
+#   problematic)
+# - there is no operator case preservation framework either
+#
+# So what we do instead is resort to some monkey patching and
+# lowercasing and stuff to get something we can compare to the
+# original SQL string
+# Ugly but somewhat effective
+
+for my $orig (@sql) {
+  my $plain_formatted = $sqlat->format($orig);
+  is_same_sql( $plain_formatted, $orig, 'Formatted string is_same_sql()-matched' );
+
+  my $ast = $sqlat->parse($orig);
+  my $reassembled = do {
+    no warnings 'redefine';
+    local *SQL::Abstract::Tree::_parenthesis_unroll = sub {};
+    $sqlat->unparse($ast);
+  };
+
+  # deal with whitespace around parenthesis readjustment
+  $_ =~ s/ \s* ( [ \(\) ] ) \s* /$1/gx
+    for ($orig, $reassembled);
+
+  is (
+    lc($reassembled),
+    lc($orig),
+    sprintf( 'roundtrip works (%s...)', substr $orig, 0, 20 )
+  ) or do {
+    my ($ast1, $ast2) = map { dumper( $sqlat->parse($_) ) } ( $orig, $reassembled );
+
+    note "ast1: $ast1";
+    note "ast2: $ast2";
+  };
 }
 
-# delete this test when mysql_functions gets implemented
-my $sql = 'SELECT COUNT( * ) FROM foo';
-is($sqlat->format($sql), $sql, 'Roundtripping to mysql-compatible paren. syntax');
+# this is invalid SQL, we are just checking that the parser
+# does not inadvertently make it right
+my $sql = 'SELECT * FROM foo WHERE x IN ( ( 1 ) )';
+is(
+  $sqlat->unparse($sqlat->parse($sql)),
+  $sql,
+  'Multi-parens around IN survive',
+);
 
 lives_ok { $sqlat->unparse( $sqlat->parse( <<'EOS' ) ) } 'Able to parse/unparse grossly malformed sql';
 SELECT