X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F105view_deps.t;h=d056e9dc64e8535dd0ba4d3e573b7d0f3e82d0b8;hb=68de943862f06cabd397d2e74d12cd9cdc999779;hp=46953f6596ff9debf9b110a361cc806c37ad5c97;hpb=b7b008a2972e24c30d70d3ceeb7eb0bcfbe60b2c;p=dbsrgits%2FDBIx-Class.git

diff --git a/t/105view_deps.t b/t/105view_deps.t
index 46953f6..d056e9d 100644
--- a/t/105view_deps.t
+++ b/t/105view_deps.t
@@ -5,20 +5,23 @@ use warnings;
 
 use Test::More;
 use Test::Exception;
+use Test::Warn;
 use lib qw(t/lib);
 use ViewDeps;
-use Devel::Dwarn;
-use Data::Dumper;
-use Carp::Always;
+use ViewDepsBad;
 
 BEGIN {
-    #$ENV{DBIC_TRACE} = 1;
-    use_ok('DBIx::Class::ResultSource::View');
+    require DBIx::Class;
+    plan skip_all => 'Test needs ' .
+        DBIx::Class::Optional::Dependencies->req_missing_for('deploy')
+      unless DBIx::Class::Optional::Dependencies->req_ok_for('deploy');
 }
 
+use_ok('DBIx::Class::ResultSource::View');
+
 #################### SANITY
 
-my $view = DBIx::Class::ResultSource::View->new( { name => 'Quux' } );
+my $view = DBIx::Class::ResultSource::View->new;
 
 isa_ok( $view, 'DBIx::Class::ResultSource', 'A new view' );
 isa_ok( $view, 'DBIx::Class', 'A new view also' );
@@ -27,65 +30,88 @@ can_ok( $view, $_ ) for qw/new from deploy_depends_on/;
 
 #################### DEPS
 
-#if (-e "t/var/viewdeps.db") {
-#ok(unlink("t/var/viewdeps.db"),"Deleted old DB OK");
-#}
+my $schema
+    = ViewDeps->connect( 'dbi:SQLite::memory:', { quote_char => '"', } );
+ok( $schema, 'Connected to ViewDeps schema OK' );
 
-my @sql_files = glob("t/sql/ViewDeps*.sql");
-for (@sql_files) {
-    ok( unlink($_), "Deleted old SQL $_ OK" );
-}
+#################### DEPLOY
 
-my $schema = ViewDeps->connect( 'dbi:SQLite:dbname=t/var/viewdeps.db',
-    { quote_char => '"', } );
-ok( $schema, 'Connected to ViewDeps schema OK' );
+$schema->deploy( { add_drop_table => 1 } );
 
-my $deps_ref = {
-    map {
-        $schema->resultset($_)->result_source->name =>
-            $schema->resultset($_)->result_source->deploy_depends_on
-        }
-        grep {
-        $schema->resultset($_)
-            ->result_source->isa('DBIx::Class::ResultSource::View')
-        } @{ [ $schema->sources ] }
-};
+#################### DOES ORDERING WORK?
 
-#diag( Dwarn $deps_ref);
+my $sqlt_object = $schema->{sqlt};
 
-my @sorted_sources = sort {
-    keys %{ $deps_ref->{$a} || {} } <=> keys %{ $deps_ref->{$b} || {} }
-        || $a cmp $b
-    }
-    keys %$deps_ref;
+my @keys = keys %{ $sqlt_object->{views} };
 
-#diag( Dwarn @sorted_sources );
+my @sqlt_sources = sort {
+    $sqlt_object->{views}->{$a}->{order}
+        cmp $sqlt_object->{views}->{$b}->{order}
+} @keys;
 
-#################### DEPLOY
+my @expected
+    = qw/a_name_artists track_number_fives year_2010_cds ab_name_artists year_2010_cds_with_many_tracks aba_name_artists aba_name_artists_and_2010_cds_with_many_tracks/;
 
-my $ddl_dir = "t/sql";
-$schema->create_ddl_dir( [ 'PostgreSQL', 'MySQL', 'SQLite' ], 0.1, $ddl_dir );
+is_deeply( \@expected, \@sqlt_sources,
+    "SQLT view order triumphantly matches our order." );
 
-ok( -e $_, "$_ was created successfully" ) for @sql_files;
+#################### AND WHAT ABOUT USING THE SCHEMA?
 
-$schema->deploy( { add_drop_table => 1 } );
+lives_ok( sub { $schema->resultset($_)->next }, "Query on $_ succeeds" )
+    for grep {
+    $schema->resultset($_)
+        ->result_source->isa('DBIx::Class::ResultSource::View')
+    } @{ [ $schema->sources ] };
 
-#################### DOES ORDERING WORK?
+#################### AND WHAT ABOUT A BAD DEPS CHAIN IN A VIEW?
 
-my $tr = $schema->{sqlt};
-#diag("My TR isa: ", ref $tr);
-#diag( Dwarn keys %{$tr->{views}});
-my @keys = keys %{$tr->{views}};
+my $schema2
+    = ViewDepsBad->connect( 'dbi:SQLite::memory:', { quote_char => '"', } );
+ok( $schema2, 'Connected to ViewDepsBad schema OK' );
 
+#################### DEPLOY2
 
-my @sqlt_sources = 
-sort {
-    $tr->{views}->{$a}->{order} cmp $tr->{views}->{$b}->{order}
-}
-@keys;
+warnings_exist { $schema2->deploy( { add_drop_table => 1 } ); }
+[qr/no such table: main.aba_name_artists/],
+    "Deploying the bad schema produces a warning: aba_name_artists was not created.";
+
+#################### DOES ORDERING WORK 2?
+
+my $sqlt_object2 = $schema2->{sqlt};
+
+my @keys2 = keys %{ $sqlt_object->{views} };
+
+my @sqlt_sources2 = sort {
+    $sqlt_object->{views}->{$a}->{order}
+        cmp $sqlt_object->{views}->{$b}->{order}
+} @keys2;
 
-#diag(Dwarn @sqlt_sources);
+my @expected2
+    = qw/a_name_artists track_number_fives year_2010_cds ab_name_artists year_2010_cds_with_many_tracks aba_name_artists aba_name_artists_and_2010_cds_with_many_tracks/;
 
-is_deeply(\@sorted_sources,\@sqlt_sources,"SQLT view order triumphantly matchs our order.");
+is_deeply( \@expected2, \@sqlt_sources2,
+    "SQLT view order triumphantly matches our order." );
+
+#################### AND WHAT ABOUT USING THE SCHEMA2?
+
+lives_ok( sub { $schema2->resultset($_)->next }, "Query on $_ succeeds" )
+    for grep {
+    $schema2->resultset($_)
+        ->result_source->isa('DBIx::Class::ResultSource::View')
+    } grep { !/AbaNameArtistsAnd2010CDsWithManyTracks/ }
+    @{ [ $schema2->sources ] };
+
+dies_ok(
+    sub {
+        $schema2->resultset('AbaNameArtistsAnd2010CDsWithManyTracks')->next;
+    },
+    "Query on AbaNameArtistsAnd2010CDsWithManyTracks dies, because of incorrect deploy_depends_on in AbaNameArtists"
+);
+
+throws_ok {
+    $schema2->resultset('AbaNameArtistsAnd2010CDsWithManyTracks')->next;
+}
+qr/no such table: aba_name_artists_and_2010_cds_with_many_tracks/,
+    "Query on AbaNameArtistsAnd2010CDsWithManyTracks throws, because the table does not exist";
 
 done_testing;