X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F101populate_rs.t;h=4eca3b51d31d552d638f6c42c689f526b0fbaa49;hb=b0ca666f56fbdac8c0b4a08a292eed26ba8a21be;hp=39b59b900fe611b23651fc802f83eaf467034ff1;hpb=e8aef98d6294a6f9c538e2db7722293ab3150fb2;p=dbsrgits%2FDBIx-Class.git

diff --git a/t/101populate_rs.t b/t/101populate_rs.t
index 39b59b9..4eca3b5 100644
--- a/t/101populate_rs.t
+++ b/t/101populate_rs.t
@@ -8,7 +8,6 @@
 ## Also need to test some stuff that should generate errors.
 ## ----------------------------------------------------------------------------
 
-
 use strict;
 use warnings;
 
@@ -16,7 +15,8 @@ use Test::More;
 use lib qw(t/lib);
 use DBICTest;
 
-plan tests => 53;
+plan tests => 134;
+
 
 ## ----------------------------------------------------------------------------
 ## Get a Schema and some ResultSets we can play with.
@@ -32,6 +32,96 @@ ok( $cd_rs, 'Got Good CD Resultset');
 
 
 ## ----------------------------------------------------------------------------
+## Schema populate Tests
+## ----------------------------------------------------------------------------
+
+SCHEMA_POPULATE1: {
+
+	## Test to make sure that the old $schema->populate is using the new method
+	## for $resultset->populate when in void context and with sub objects.
+	
+	$schema->populate('Artist', [
+	
+		[qw/name cds/],
+		["001First Artist", [
+			{title=>"001Title1", year=>2000},
+			{title=>"001Title2", year=>2001},
+			{title=>"001Title3", year=>2002},
+		]],
+		["002Second Artist", []],
+		["003Third Artist", [
+			{title=>"003Title1", year=>2005},
+		]],
+		[undef, [
+			{title=>"004Title1", year=>2010}
+		]],
+	]);
+	
+	isa_ok $schema, 'DBIx::Class::Schema';
+	
+	my ($undef, $artist1, $artist2, $artist3 ) = $schema->resultset('Artist')->search({
+		name=>["001First Artist","002Second Artist","003Third Artist", undef]},
+		{order_by=>'name ASC'})->all;
+	
+	isa_ok  $artist1, 'DBICTest::Artist';
+	isa_ok  $artist2, 'DBICTest::Artist';
+	isa_ok  $artist3, 'DBICTest::Artist';
+	isa_ok  $undef, 'DBICTest::Artist';	
+	
+	ok $artist1->name eq '001First Artist', "Got Expected Artist Name for Artist001";
+	ok $artist2->name eq '002Second Artist', "Got Expected Artist Name for Artist002";
+	ok $artist3->name eq '003Third Artist', "Got Expected Artist Name for Artist003";
+	ok !defined $undef->name, "Got Expected Artist Name for Artist004";	
+	
+	ok $artist1->cds->count eq 3, "Got Right number of CDs for Artist1";
+	ok $artist2->cds->count eq 0, "Got Right number of CDs for Artist2";
+	ok $artist3->cds->count eq 1, "Got Right number of CDs for Artist3";
+	ok $undef->cds->count eq 1, "Got Right number of CDs for Artist4";	
+	
+	ARTIST1CDS: {
+	
+		my ($cd1, $cd2, $cd3) = $artist1->cds->search(undef, {order_by=>'year ASC'});
+		
+		isa_ok $cd1, 'DBICTest::CD';
+		isa_ok $cd2, 'DBICTest::CD';
+		isa_ok $cd3, 'DBICTest::CD';
+		
+		ok $cd1->year == 2000;
+		ok $cd2->year == 2001;
+		ok $cd3->year == 2002;
+		
+		ok $cd1->title eq '001Title1';
+		ok $cd2->title eq '001Title2';
+		ok $cd3->title eq '001Title3';
+	}
+	
+	ARTIST3CDS: {
+	
+		my ($cd1) = $artist3->cds->search(undef, {order_by=>'year ASC'});
+		
+		isa_ok $cd1, 'DBICTest::CD';
+
+		ok $cd1->year == 2005;
+		ok $cd1->title eq '003Title1';
+	}
+
+	ARTIST4CDS: {
+	
+		my ($cd1) = $undef->cds->search(undef, {order_by=>'year ASC'});
+		
+		isa_ok $cd1, 'DBICTest::CD';
+
+		ok $cd1->year == 2010;
+		ok $cd1->title eq '004Title1';
+	}
+	
+	## Need to do some cleanup so that later tests don't get borked
+	
+	$undef->delete;
+}
+
+
+## ----------------------------------------------------------------------------
 ## Array context tests
 ## ----------------------------------------------------------------------------
 
@@ -293,15 +383,23 @@ VOID_CONTEXT: {
 				cds => [
 					{ title => 'VOID_PK_One Hit Wonder', year => 2006 },
 				],					
-			},			
+			},	
+			{
+				artistid => ++$aid,
+				name => undef,
+				cds => [
+					{ title => 'VOID_PK_Zundef test', year => 2006 },
+				],					
+			},		
 		];
 		
 		## Get the result row objects.
 		
 		$art_rs->populate($artists);
 		
-		my ($girl, $formerly, $damn, $crap) = $art_rs->search(
-			{name=>[sort map {$_->{name}} @$artists]},
+		my ($undef, $girl, $formerly, $damn, $crap) = $art_rs->search(
+		
+			{name=>[ map { $_->{name} } @$artists]},
 			{order_by=>'name ASC'},
 		);
 		
@@ -311,22 +409,29 @@ VOID_CONTEXT: {
 		isa_ok( $girl, 'DBICTest::Artist', "Got 'Artist'");
 		isa_ok( $damn, 'DBICTest::Artist', "Got 'Artist'");	
 		isa_ok( $formerly, 'DBICTest::Artist', "Got 'Artist'");	
-		
+		isa_ok( $undef, 'DBICTest::Artist', "Got 'Artist'");		
+	
 		## Find the expected information?
 
-		ok( $crap->name eq 'VOID_PK_Manufactured Crap', "Got Correct name for result object");
+		ok( $crap->name eq 'VOID_PK_Manufactured Crap', "Got Correct name 'VOID_PK_Manufactured Crap' for result object");
 		ok( $girl->name eq 'VOID_PK_Angsty-Whiny Girl', "Got Correct name for result object");
 		ok( $damn->name eq 'VOID_PK_Like I Give a Damn', "Got Correct name for result object");	
 		ok( $formerly->name eq 'VOID_PK_Formerly Named', "Got Correct name for result object");
+		ok( !defined $undef->name, "Got Correct name 'is undef' for result object");		
 		
 		## Create the expected children sub objects?
-		use Data::Dump qw/dump/;
-		
+		ok( $crap->can('cds'), "Has cds relationship");
+		ok( $girl->can('cds'), "Has cds relationship");
+		ok( $damn->can('cds'), "Has cds relationship");
+		ok( $formerly->can('cds'), "Has cds relationship");
+		ok( $undef->can('cds'), "Has cds relationship");	
+	
 		ok( $crap->cds->count == 0, "got Expected Number of Cds");
 		ok( $girl->cds->count == 2, "got Expected Number of Cds");	
 		ok( $damn->cds->count == 3, "got Expected Number of Cds");
 		ok( $formerly->cds->count == 1, "got Expected Number of Cds");
-
+		ok( $undef->cds->count == 1, "got Expected Number of Cds");
+		
 		## Did the cds get expected information?
 		
 		my ($cd1, $cd2) = $girl->cds->search({},{order_by=>'year ASC'});
@@ -377,9 +482,7 @@ VOID_CONTEXT: {
 
 		## Test from a belongs_to perspective, should create artist first, 
 		## then CD with artistid.
-		
-		diag("Starting Void Context BelongsTO with No PKs");
-		
+				
 		my $cds = [
 			{
 				title => 'Some CD3BB',
@@ -390,12 +493,17 @@ VOID_CONTEXT: {
 				title => 'Some CD4BB',
 				year => '1997',
 				artist => { name => 'Fred BloggsDBB'},
+			},
+			{
+				title => 'Some CD5BB',
+				year => '1997',
+				artist => { name => undef},
 			},		
 		];
 		
 		$cd_rs->populate($cds);
 		
-		my ($cdA, $cdB) = $cd_rs->search(
+		my ($cdA, $cdB, $cdC) = $cd_rs->search(
 			{title=>[sort map {$_->{title}} @$cds]},
 			{order_by=>'title ASC'},
 		);
@@ -409,6 +517,11 @@ VOID_CONTEXT: {
 		isa_ok($cdB->artist, 'DBICTest::Artist', 'Set Artist');
 		is($cdB->title, 'Some CD4BB', 'Found Expected title');
 		is($cdB->artist->name, 'Fred BloggsDBB', 'Set Artist to FredDBB');
+		
+		isa_ok($cdC, 'DBICTest::CD', 'Created CD');
+		isa_ok($cdC->artist, 'DBICTest::Artist', 'Set Artist');
+		is($cdC->title, 'Some CD5BB', 'Found Expected title');
+		is( $cdC->artist->name, undef, 'Set Artist to something undefined');
 	}
 	
 	
@@ -416,8 +529,6 @@ VOID_CONTEXT: {
 	
 		## This first group of tests checks to make sure we can call populate
 		## with the parent having many children and let the keys be automatic
-		
-		diag("Starting Void Context Has Many with No PKs");
 
 		my $artists = [
 			{	
@@ -470,9 +581,10 @@ VOID_CONTEXT: {
 		ok( $formerly->name eq 'VOID_Formerly Named', "Got Correct name for result object");
 		
 		## Create the expected children sub objects?
-		use Data::Dump qw/dump/;
-		
-		warn dump map { $_->get_columns } $damn->cds;
+		ok( $crap->can('cds'), "Has cds relationship");
+		ok( $girl->can('cds'), "Has cds relationship");
+		ok( $damn->can('cds'), "Has cds relationship");
+		ok( $formerly->can('cds'), "Has cds relationship");
 		
 		ok( $crap->cds->count == 0, "got Expected Number of Cds");
 		ok( $girl->cds->count == 2, "got Expected Number of Cds");	
@@ -482,30 +594,11 @@ VOID_CONTEXT: {
 		## Did the cds get expected information?
 		
 		my ($cd1, $cd2) = $girl->cds->search({},{order_by=>'year ASC'});
-		
+
+		ok($cd1, "Got a got CD");
+		ok($cd2, "Got a got CD");
 		ok( $cd1->title eq "VOID_My First CD", "Got Expected CD Title");
 		ok( $cd2->title eq "VOID_Yet More Tweeny-Pop crap", "Got Expected CD Title");
 	}
 
-}
-
-__END__
-## ----------------------------------------------------------------------------
-## Error cases
-## ----------------------------------------------------------------------------
-
-SHOULD_CAUSE_ERRORS: {
-
-	## bad or missing PKs
-	## changing columns
-	## basically errors for non well formed data
-	## check for the first incomplete problem
-	## can we solve the problem of void context and no PKs?
-
-}
-
-
-
-
-
-
+}
\ No newline at end of file