X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F04_array.t;h=a75c3491db13ebf29fd123b50dbf1af869095d93;hb=345e7fd079ea47414f8d2601e47689a0dbd16c97;hp=c535f2f230bc53b039432e6ba7a82706ddeb02eb;hpb=7f441181df8805bd5eb1ea61bbe08930d607bef0;p=dbsrgits%2FDBM-Deep.git diff --git a/t/04_array.t b/t/04_array.t index c535f2f..a75c349 100644 --- a/t/04_array.t +++ b/t/04_array.t @@ -2,27 +2,18 @@ # DBM::Deep Test ## use strict; -use Test::More tests => 90; +use Test::More tests => 130; use Test::Exception; +use t::common qw( new_fh ); use_ok( 'DBM::Deep' ); -## -# basic file open -## -unlink "t/test.db"; +my ($fh, $filename) = new_fh(); my $db = DBM::Deep->new( - file => "t/test.db", - type => DBM::Deep->TYPE_ARRAY + file => $filename, + fh => $fh, + type => DBM::Deep->TYPE_ARRAY ); -if ($db->error()) { - die "ERROR: " . $db->error(); -} - -TODO: { - local $TODO = "How is this test ever supposed to pass?"; - ok( !$db->clear, "If the file has never been written to, clear() returns false" ); -} ## # basic put/get/push @@ -58,22 +49,36 @@ is( $db->[-2], $db->[3], "-2nd index is 3rd index" ); is( $db->[-3], $db->[2], "-3rd index is 2nd index" ); is( $db->[-4], $db->[1], "-4th index is 1st index" ); is( $db->[-5], $db->[0], "-5th index is 0th index" ); -is( $db->[-6], undef, "-6th index is undef" ); + +# This is for Perls older than 5.8.0 because of is()'s prototype +{ my $v = $db->[-6]; is( $v, undef, "-6th index is undef" ); } + is( $db->length, 5, "... and we have five elements after abortive -6 index lookup" ); +$db->[-1] = 'elem4.1'; +is( $db->[-1], 'elem4.1' ); +is( $db->[4], 'elem4.1' ); +is( $db->get(4), 'elem4.1' ); +is( $db->fetch(4), 'elem4.1' ); + +throws_ok { + $db->[-6] = 'whoops!'; +} qr/Modification of non-creatable array value attempted, subscript -6/, "Correct error thrown"; + my $popped = $db->pop; is( $db->length, 4, "... and we have four after popping" ); is( $db->[0], 'elem0', "0th element still there after popping" ); is( $db->[1], 'elem1', "1st element still there after popping" ); is( $db->[2], 'elem2', "2nd element still there after popping" ); is( $db->[3], 'elem3', "3rd element still there after popping" ); -is( $popped, 'elem4', "Popped value is correct" ); +is( $popped, 'elem4.1', "Popped value is correct" ); my $shifted = $db->shift; is( $db->length, 3, "... and we have three after shifting" ); is( $db->[0], 'elem1', "0th element still there after shifting" ); is( $db->[1], 'elem2', "1st element still there after shifting" ); is( $db->[2], 'elem3', "2nd element still there after shifting" ); +is( $db->[3], undef, "There is no third element now" ); is( $shifted, 'elem0', "Shifted value is correct" ); ## @@ -101,15 +106,9 @@ is( $db->length, 3, "... and we still have three after a DELETE on an out-of-ran $deleted = $db->delete(-2); is( $db->length, 3, "... and we still have three after deleting" ); is( $db->[0], undef, "0th element still undef" ); -TODO: { - local $TODO = "delete on a negative array element should work"; - is( $db->[1], undef, "1st element now undef" ); -} +is( $db->[1], undef, "1st element now undef" ); is( $db->[2], 'elem3', "2nd element still there after deleting" ); -TODO: { - local $TODO = "delete on a negative array element should return the deleted value"; - is( $deleted, 'elem2', "Deleted value is correct" ); -} +is( $deleted, 'elem2', "Deleted value is correct" ); $db->[1] = 'elem2'; @@ -117,12 +116,9 @@ $db->[1] = 'elem2'; # exists ## ok( $db->exists(1), "The 1st value exists" ); -ok( !$db->exists(0), "The 0th value doesn't exists" ); +ok( $db->exists(0), "The 0th value doesn't exist" ); ok( !$db->exists(22), "The 22nd value doesn't exists" ); -TODO: { - local $TODO = "exists on negative values should work"; - ok( $db->exists(-1), "The -1st value does exists" ); -} +ok( $db->exists(-1), "The -1st value does exists" ); ok( !$db->exists(-22), "The -22nd value doesn't exists" ); ## @@ -157,7 +153,9 @@ is($db->[2], "elem last", "Third element is 'elem last'"); ## # splice with length 1 ## -$db->splice( 1, 1, "middle A", "middle B" ); +my @returned = $db->splice( 1, 1, "middle A", "middle B" ); +is( scalar(@returned), 1, "One element was removed" ); +is( $returned[0], 'elem middle', "... and it was correctly removed" ); is($db->length(), 4); is($db->[0], "elem first"); is($db->[1], "middle A"); @@ -167,7 +165,8 @@ is($db->[3], "elem last"); ## # splice with length of 0 ## -$db->splice( -1, 0, "middle C" ); +@returned = $db->splice( -1, 0, "middle C" ); +is( scalar(@returned), 0, "No elements were removed" ); is($db->length(), 5); is($db->[0], "elem first"); is($db->[1], "middle A"); @@ -178,16 +177,118 @@ is($db->[4], "elem last"); ## # splice with length of 3 ## -$db->splice( 1, 3, "middle ABC" ); +my $returned = $db->splice( 1, 3, "middle ABC" ); +is( $returned, 'middle C', "Just the last element was returned" ); is($db->length(), 3); is($db->[0], "elem first"); is($db->[1], "middle ABC"); is($db->[2], "elem last"); -# These tests verify that the hash methods cannot be called on arraytypes. -# They will be removed once the ARRAY and HASH types are refactored into their own classes. +@returned = $db->splice( 1 ); +is($db->length(), 1); +is($db->[0], "elem first"); +is($returned[0], "middle ABC"); +is($returned[1], "elem last"); + +$db->push( @returned ); + +@returned = $db->splice( 1, -1 ); +is($db->length(), 2); +is($db->[0], "elem first"); +is($db->[1], "elem last"); +is($returned[0], "middle ABC"); + +@returned = $db->splice; +is( $db->length, 0 ); +is( $returned[0], "elem first" ); +is( $returned[1], "elem last" ); $db->[0] = [ 1 .. 3 ]; $db->[1] = { a => 'foo' }; is( $db->[0]->length, 3, "Reuse of same space with array successful" ); is( $db->[1]->fetch('a'), 'foo', "Reuse of same space with hash successful" ); + +# Test autovivification +$db->[9999]{bar} = 1; +ok( $db->[9999] ); +cmp_ok( $db->[9999]{bar}, '==', 1 ); + +# Test failures +throws_ok { + $db->fetch( 'foo' ); +} qr/Cannot use 'foo' as an array index/, "FETCH fails on an illegal key"; + +throws_ok { + $db->fetch(); +} qr/Cannot use an undefined array index/, "FETCH fails on an undefined key"; + +throws_ok { + $db->store( 'foo', 'bar' ); +} qr/Cannot use 'foo' as an array index/, "STORE fails on an illegal key"; + +throws_ok { + $db->store(); +} qr/Cannot use an undefined array index/, "STORE fails on an undefined key"; + +throws_ok { + $db->delete( 'foo' ); +} qr/Cannot use 'foo' as an array index/, "DELETE fails on an illegal key"; + +throws_ok { + $db->delete(); +} qr/Cannot use an undefined array index/, "DELETE fails on an undefined key"; + +throws_ok { + $db->exists( 'foo' ); +} qr/Cannot use 'foo' as an array index/, "EXISTS fails on an illegal key"; + +throws_ok { + $db->exists(); +} qr/Cannot use an undefined array index/, "EXISTS fails on an undefined key"; + +# Bug reported by Mike Schilli +# Also, RT #29583 reported by HANENKAMP +{ + my ($fh, $filename) = new_fh(); + my $db = DBM::Deep->new( + file => $filename, + fh => $fh, + type => DBM::Deep->TYPE_ARRAY + ); + + push @{$db}, 3, { foo => 1 }; + lives_ok { + shift @{$db}; + } "Shift doesn't die moving references around"; + is( $db->[0]{foo}, 1, "Right hashref there" ); + + lives_ok { + unshift @{$db}, [ 1 .. 3, [ 1 .. 3 ] ]; + unshift @{$db}, 1; + } "Unshift doesn't die moving references around"; + is( $db->[1][3][1], 2, "Right arrayref there" ); + is( $db->[2]{foo}, 1, "Right hashref there" ); + + # Add test for splice moving references around + lives_ok { + splice @{$db}, 0, 0, 1 .. 3; + } "Splice doesn't die moving references around"; + is( $db->[4][3][1], 2, "Right arrayref there" ); + is( $db->[5]{foo}, 1, "Right hashref there" ); +} + +{ # Make sure we do not trigger a deep recursion warning [RT #53575] + my $w; + local $SIG{__WARN__} = sub { $w = shift }; + my ($fh, $filename) = new_fh(); + my $db = DBM::Deep->new( file => $filename, fh => $fh, ); + my $a = []; + my $tmp = $a; + for(1..100) { + ($tmp) = @$tmp = []; + } + ok eval { + $db->{""} = $a; + }, 'deep recursion in array assignment' or diag $@; + is $w, undef, 'no warnings with deep recursion in array assignment'; +}