X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F02git_tag.t;h=350e9e5d10903147346af593e6bafd09ce34152c;hb=7b5bdee05283b67c7ee10d8c150ab19fec335541;hp=baa998388f2cc0d693f5783ba5fe3b9b7070801f;hpb=bc33a9b1ad2ff2573fb6b2cb5184cefa002f5354;p=catagits%2FGitalist.git

diff --git a/t/02git_tag.t b/t/02git_tag.t
index baa9983..350e9e5 100644
--- a/t/02git_tag.t
+++ b/t/02git_tag.t
@@ -13,12 +13,15 @@ use Data::Dumper;
 
 BEGIN { use_ok 'Gitalist::Git::Tag' }
 
+my $ref_sha1 = '3f7567c7bdf7e7ebf410926493b92d398333116e';
 # Create an instance from for-each-ref output
-my $revline="36c6c6708b8360d7023e8a1649c45bcf9b3bd818 commit refs/tags/0.01   add dir1/file2\0Florian Ragwitz <rafl\@debian.org> 1173210275 +0100";
-#my $revline="a92fb1c9282f7319099ce7f783c8be7d5360f6e3\0refs/heads/model-cleanup\0Zachary Stevens <zts\@cryptocracy.com> 1277601094 +0100";
+my $revline="36c6c6708b8360d7023e8a1649c45bcf9b3bd818 commit refs/tags/0.01 $ref_sha1 add dir1/file2\0Florian Ragwitz <rafl\@debian.org> 1173210275 +0100";
+
 my $instance = Gitalist::Git::Tag->new($revline);
 isa_ok($instance, 'Gitalist::Git::Tag');
 
+ok($instance->$_, $_) for $instance->meta->get_attribute_list;
+
 # Create an instance, passing last_change as a DateTime
 use DateTime;
 my $timespec = [1173210275, '+0100'];
@@ -34,3 +37,12 @@ my $head = Gitalist::Git::Tag->new(
     last_change => $dt,
 );
 isa_ok($head, 'Gitalist::Git::Tag');
+
+my $oldtag = "d6602ec5194c87b0fc87103ca4d67251c76f233a tag refs/tags/v0.99 a3eb250f996bf5e12376ec88622c4ccaabf20ea8 commit Test-release for wider distribution.";
+
+ok(!Gitalist::Git::Tag::is_valid_tag($oldtag), 'Gitalist::Git::Tag::is_valid_tag ancient tag');
+ok(Gitalist::Git::Tag::is_valid_tag($revline), 'Gitalist::Git::Tag::is_valid_tag regular tag');
+
+# Tags don't necessarily have a refname, check we deal with its absence.
+$revline =~ s/$ref_sha1//;
+ok(Gitalist::Git::Tag::is_valid_tag($revline), 'Gitalist::Git::Tag::is_valid_tag regular tag sans ref sha1');