X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F01generate.t;h=9dbc5044002f9f2d37fd88d4b7f09568997d3ca3;hb=75151f36d04ceeb6bcd18af4daf155d0a1051f66;hp=419d3e4f6ec48d97699ee0c66106186f9b4a952e;hpb=b3be7bd08ab2e97184d5700fee0930f651b0c9a2;p=dbsrgits%2FSQL-Abstract.git diff --git a/t/01generate.t b/t/01generate.t index 419d3e4..9dbc504 100644 --- a/t/01generate.t +++ b/t/01generate.t @@ -3,6 +3,8 @@ use strict; use warnings; use Test::More; +use Test::Warn; +use Test::Exception; use SQL::Abstract::Test import => ['is_same_sql_bind']; @@ -188,6 +190,13 @@ my @tests = ( stmt_q => 'INSERT INTO `test`.`table` (`high_limit`, `low_limit`) VALUES (max(all_limits), ?)', bind => ['4'], }, + { + func => 'insert', + args => ['test.table', [ \'max(all_limits)', 4 ] ], + stmt => 'INSERT INTO test.table VALUES (max(all_limits), ?)', + stmt_q => 'INSERT INTO `test`.`table` VALUES (max(all_limits), ?)', + bind => ['4'], + }, #23 { func => 'insert', @@ -222,10 +231,10 @@ my @tests = ( #26 { func => 'select', - args => ['test', '*', {priority => [ -and => {'!=', 2}, {'!=', 1} ]}], - stmt => 'SELECT * FROM test WHERE ( ( ( priority != ? ) AND ( priority != ? ) ) )', - stmt_q => 'SELECT * FROM `test` WHERE ( ( ( `priority` != ? ) AND ( `priority` != ? ) ) )', - bind => [qw(2 1)], + args => ['test', '*', {priority => [ -and => {'!=', 2}, { -not_like => '3%'} ]}], + stmt => 'SELECT * FROM test WHERE ( ( ( priority != ? ) AND ( priority NOT LIKE ? ) ) )', + stmt_q => 'SELECT * FROM `test` WHERE ( ( ( `priority` != ? ) AND ( `priority` NOT LIKE ? ) ) )', + bind => [qw(2 3%)], }, #27 { @@ -244,13 +253,10 @@ my @tests = ( tasty => { '!=', [qw(yes YES)] }, -nest => [ face => [ -or => {'=', 'mr.happy'}, {'=', undef} ] ] }, ], -# LDNOTE : modified the test below, same reasons as #14 in 00where.t stmt => 'UPDATE taco_punches SET one = ?, three = ? WHERE ( ( ( ( ( face = ? ) OR ( face IS NULL ) ) ) )' -# . ' AND ( ( bland != ? ) AND ( bland != ? ) ) AND ( ( tasty != ? ) OR ( tasty != ? ) ) )', - . ' AND ( ( bland != ? ) AND ( bland != ? ) ) AND ( ( tasty != ? ) AND ( tasty != ? ) ) )', + . ' AND ( ( bland != ? ) AND ( bland != ? ) ) AND ( ( tasty != ? ) OR ( tasty != ? ) ) )', stmt_q => 'UPDATE `taco_punches` SET `one` = ?, `three` = ? WHERE ( ( ( ( ( `face` = ? ) OR ( `face` IS NULL ) ) ) )' -# . ' AND ( ( `bland` != ? ) AND ( `bland` != ? ) ) AND ( ( `tasty` != ? ) OR ( `tasty` != ? ) ) )', - . ' AND ( ( `bland` != ? ) AND ( `bland` != ? ) ) AND ( ( `tasty` != ? ) AND ( `tasty` != ? ) ) )', + . ' AND ( ( `bland` != ? ) AND ( `bland` != ? ) ) AND ( ( `tasty` != ? ) OR ( `tasty` != ? ) ) )', bind => [qw(2 4 mr.happy yes YES yes YES)], }, #29 @@ -259,26 +265,18 @@ my @tests = ( args => ['jeff', '*', { name => {'like', '%smith%', -not_in => ['Nate','Jim','Bob','Sally']}, -nest => [ -or => [ -and => [age => { -between => [20,30] }, age => {'!=', 25} ], yob => {'<', 1976} ] ] } ], -# LDNOTE : original test below was WRONG with respect to the doc. -# [-and, [cond1, cond2], cond3] should mean (cond1 OR cond2) AND cond3 -# instead of (cond1 AND cond2) OR cond3. -# Probably a misconception because of '=>' notation -# in [-and => [cond1, cond2], cond3]. -# Also some differences in parentheses, but without impact on semantics. -# stmt => 'SELECT * FROM jeff WHERE ( ( ( ( ( ( ( age BETWEEN ? AND ? ) AND ( age != ? ) ) ) OR ( yob < ? ) ) ) )' -# . ' AND name NOT IN ( ?, ?, ?, ? ) AND name LIKE ? )', -# stmt_q => 'SELECT * FROM `jeff` WHERE ( ( ( ( ( ( ( `age` BETWEEN ? AND ? ) AND ( `age` != ? ) ) ) OR ( `yob` < ? ) ) ) )' -# . ' AND `name` NOT IN ( ?, ?, ?, ? ) AND `name` LIKE ? )', - stmt => 'SELECT * FROM jeff WHERE ( ( ( ( ( age BETWEEN ? AND ? ) OR ( age != ? ) ) AND ( yob < ? ) ) )' - . ' AND ( name NOT IN ( ?, ?, ?, ? ) AND name LIKE ? ) )', - stmt_q => 'SELECT * FROM `jeff` WHERE ( ( ( ( ( `age` BETWEEN ? AND ? ) OR ( `age` != ? ) ) AND ( `yob` < ? ) ) )' - . ' AND ( `name` NOT IN ( ?, ?, ?, ? ) AND `name` LIKE ? ) )', + stmt => 'SELECT * FROM jeff WHERE ( ( ( ( ( ( ( age BETWEEN ? AND ? ) AND ( age != ? ) ) ) OR ( yob < ? ) ) ) )' + . ' AND name NOT IN ( ?, ?, ?, ? ) AND name LIKE ? )', + stmt_q => 'SELECT * FROM `jeff` WHERE ( ( ( ( ( ( ( `age` BETWEEN ? AND ? ) AND ( `age` != ? ) ) ) OR ( `yob` < ? ) ) ) )' + . ' AND `name` NOT IN ( ?, ?, ?, ? ) AND `name` LIKE ? )', bind => [qw(20 30 25 1976 Nate Jim Bob Sally %smith%)] }, #30 { func => 'update', # LDNOTE : removed the "-maybe", because we no longer admit unknown ops +# +# acked by RIBASUSHI # args => ['fhole', {fpoles => 4}, [-maybe => {race => [-and => [qw(black white asian)]]}, args => ['fhole', {fpoles => 4}, [ {race => [-and => [qw(black white asian)]]}, {-nest => {firsttime => [-or => {'=','yes'}, undef]}}, @@ -302,6 +300,8 @@ my @tests = ( func => 'select', # LDNOTE: modified test below because we agreed with MST that literal SQL # should not automatically insert a '='; the user has to do it +# +# acked by MSTROUT # args => ['test', '*', { a => \["to_date(?, 'MM/DD/YY')", '02/02/02']}], args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", '02/02/02']}], stmt => q{SELECT * FROM test WHERE ( a = to_date(?, 'MM/DD/YY') )}, @@ -360,28 +360,290 @@ my @tests = ( stmt_q => 'SELECT * FROM `test` WHERE ( `a` < to_date(?, \'MM/DD/YY\') AND `b` = ? )', bind => ['02/02/02', 8], }, + #39 + { #TODO in SQLA >= 2.0 it will die instead (we kept this just because old SQLA passed it through) + func => 'insert', + args => ['test', {a => 1, b => 2, c => 3, d => 4, e => { answer => 42 }}], + stmt => 'INSERT INTO test (a, b, c, d, e) VALUES (?, ?, ?, ?, ?)', + stmt_q => 'INSERT INTO `test` (`a`, `b`, `c`, `d`, `e`) VALUES (?, ?, ?, ?, ?)', + bind => [qw/1 2 3 4/, { answer => 42}], + warning_like => qr/HASH ref as bind value in insert is not supported/i, + }, + #40 + { + func => 'update', + args => ['test', {a => 1, b => \["42"]}, {a => {'between', [1,2]}}], + stmt => 'UPDATE test SET a = ?, b = 42 WHERE ( a BETWEEN ? AND ? )', + stmt_q => 'UPDATE `test` SET `a` = ?, `b` = 42 WHERE ( `a` BETWEEN ? AND ? )', + bind => [qw(1 1 2)], + }, + #41 + { + func => 'insert', + args => ['test', {a => 1, b => \["42"]}], + stmt => 'INSERT INTO test (a, b) VALUES (?, 42)', + stmt_q => 'INSERT INTO `test` (`a`, `b`) VALUES (?, 42)', + bind => [qw(1)], + }, + #42 + { + func => 'select', + args => ['test', '*', { a => \["= 42"], b => 1}], + stmt => q{SELECT * FROM test WHERE ( a = 42 ) AND (b = ? )}, + stmt_q => q{SELECT * FROM `test` WHERE ( `a` = 42 ) AND ( `b` = ? )}, + bind => [qw(1)], + }, + #43 + { + func => 'select', + args => ['test', '*', { a => {'<' => \["42"]}, b => 8 }], + stmt => 'SELECT * FROM test WHERE ( a < 42 AND b = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` < 42 AND `b` = ? )', + bind => [qw(8)], + }, + #44 + { + func => 'insert', + new => {bindtype => 'columns'}, + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", [dummy => '02/02/02']]}], + stmt => 'INSERT INTO test (a, b) VALUES (?, to_date(?, \'MM/DD/YY\'))', + stmt_q => 'INSERT INTO `test` (`a`, `b`) VALUES (?, to_date(?, \'MM/DD/YY\'))', + bind => [[a => '1'], [dummy => '02/02/02']], + }, + #45 + { + func => 'update', + new => {bindtype => 'columns'}, + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", [dummy => '02/02/02']]}, {a => {'between', [1,2]}}], + stmt => 'UPDATE test SET a = ?, b = to_date(?, \'MM/DD/YY\') WHERE ( a BETWEEN ? AND ? )', + stmt_q => 'UPDATE `test` SET `a` = ?, `b` = to_date(?, \'MM/DD/YY\') WHERE ( `a` BETWEEN ? AND ? )', + bind => [[a => '1'], [dummy => '02/02/02'], [a => '1'], [a => '2']], + }, + #46 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", [dummy => '02/02/02']]}], + stmt => q{SELECT * FROM test WHERE ( a = to_date(?, 'MM/DD/YY') )}, + stmt_q => q{SELECT * FROM `test` WHERE ( `a` = to_date(?, 'MM/DD/YY') )}, + bind => [[dummy => '02/02/02']], + }, + #47 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => {'<' => \["to_date(?, 'MM/DD/YY')", [dummy => '02/02/02']]}, b => 8 }], + stmt => 'SELECT * FROM test WHERE ( a < to_date(?, \'MM/DD/YY\') AND b = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` < to_date(?, \'MM/DD/YY\') AND `b` = ? )', + bind => [[dummy => '02/02/02'], [b => 8]], + }, + #48 + { + func => 'insert', + new => {bindtype => 'columns'}, + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", '02/02/02']}], + exception_like => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/, + }, + #49 + { + func => 'update', + new => {bindtype => 'columns'}, + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", '02/02/02']}, {a => {'between', [1,2]}}], + exception_like => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/, + }, + #49 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", '02/02/02']}], + exception_like => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/, + }, + #50 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => {'<' => \["to_date(?, 'MM/DD/YY')", '02/02/02']}, b => 8 }], + exception_like => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/, + }, + #51 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => {-in => \["(SELECT d FROM to_date(?, 'MM/DD/YY') AS d)", [dummy => '02/02/02']]}, b => 8 }], + stmt => 'SELECT * FROM test WHERE ( a IN (SELECT d FROM to_date(?, \'MM/DD/YY\') AS d) AND b = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` IN (SELECT d FROM to_date(?, \'MM/DD/YY\') AS d) AND `b` = ? )', + bind => [[dummy => '02/02/02'], [b => 8]], + }, + #52 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => {-in => \["(SELECT d FROM to_date(?, 'MM/DD/YY') AS d)", '02/02/02']}, b => 8 }], + exception_like => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/, + }, + #53 + { + func => 'insert', + new => {bindtype => 'columns'}, + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", [{dummy => 1} => '02/02/02']]}], + stmt => 'INSERT INTO test (a, b) VALUES (?, to_date(?, \'MM/DD/YY\'))', + stmt_q => 'INSERT INTO `test` (`a`, `b`) VALUES (?, to_date(?, \'MM/DD/YY\'))', + bind => [[a => '1'], [{dummy => 1} => '02/02/02']], + }, + #54 + { + func => 'update', + new => {bindtype => 'columns'}, + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", [{dummy => 1} => '02/02/02']]}, {a => {'between', [1,2]}}], + stmt => 'UPDATE test SET a = ?, b = to_date(?, \'MM/DD/YY\') WHERE ( a BETWEEN ? AND ? )', + stmt_q => 'UPDATE `test` SET `a` = ?, `b` = to_date(?, \'MM/DD/YY\') WHERE ( `a` BETWEEN ? AND ? )', + bind => [[a => '1'], [{dummy => 1} => '02/02/02'], [a => '1'], [a => '2']], + }, + #55 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", [{dummy => 1} => '02/02/02']]}], + stmt => q{SELECT * FROM test WHERE ( a = to_date(?, 'MM/DD/YY') )}, + stmt_q => q{SELECT * FROM `test` WHERE ( `a` = to_date(?, 'MM/DD/YY') )}, + bind => [[{dummy => 1} => '02/02/02']], + }, + #56 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => {'<' => \["to_date(?, 'MM/DD/YY')", [{dummy => 1} => '02/02/02']]}, b => 8 }], + stmt => 'SELECT * FROM test WHERE ( a < to_date(?, \'MM/DD/YY\') AND b = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` < to_date(?, \'MM/DD/YY\') AND `b` = ? )', + bind => [[{dummy => 1} => '02/02/02'], [b => 8]], + }, + #57 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { -or => [ -and => [ a => 'a', b => 'b' ], -and => [ c => 'c', d => 'd' ] ] }], + stmt => 'SELECT * FROM test WHERE ( a = ? AND b = ? ) OR ( c = ? AND d = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` = ? AND `b` = ? ) OR ( `c` = ? AND `d` = ? )', + bind => [[a => 'a'], [b => 'b'], [ c => 'c'],[ d => 'd']], + }, + #58 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', [ { a => 1, b => 1}, [ a => 2, b => 2] ] ], + stmt => 'SELECT * FROM test WHERE ( a = ? AND b = ? ) OR ( a = ? OR b = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` = ? AND `b` = ? ) OR ( `a` = ? OR `b` = ? )', + bind => [[a => 1], [b => 1], [ a => 2], [ b => 2]], + }, + #59 + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', [ [ a => 1, b => 1], { a => 2, b => 2 } ] ], + stmt => 'SELECT * FROM test WHERE ( a = ? OR b = ? ) OR ( a = ? AND b = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` = ? OR `b` = ? ) OR ( `a` = ? AND `b` = ? )', + bind => [[a => 1], [b => 1], [ a => 2], [ b => 2]], + }, + #60 + { + func => 'insert', + args => ['test', [qw/1 2 3 4 5/], { returning => 'id' }], + stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?) RETURNING id', + stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?) RETURNING `id`', + bind => [qw/1 2 3 4 5/], + }, + #60 + { + func => 'insert', + args => ['test', [qw/1 2 3 4 5/], { returning => 'id, foo, bar' }], + stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?) RETURNING id, foo, bar', + stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?) RETURNING `id, foo, bar`', + bind => [qw/1 2 3 4 5/], + }, + #61 + { + func => 'insert', + args => ['test', [qw/1 2 3 4 5/], { returning => [qw(id foo bar) ] }], + stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?) RETURNING id, foo, bar', + stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?) RETURNING `id`, `foo`, `bar`', + bind => [qw/1 2 3 4 5/], + }, + #62 + { + func => 'insert', + args => ['test', [qw/1 2 3 4 5/], { returning => \'id, foo, bar' }], + stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?) RETURNING id, foo, bar', + stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?) RETURNING id, foo, bar', + bind => [qw/1 2 3 4 5/], + }, + #63 + { + func => 'insert', + args => ['test', [qw/1 2 3 4 5/], { returning => \'id' }], + stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?) RETURNING id', + stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?) RETURNING id', + bind => [qw/1 2 3 4 5/], + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', [ Y => { -max => { -LENGTH => { -min => 'x' } } } ] ], + stmt => 'SELECT * FROM test WHERE ( Y = MAX( LENGTH( MIN( ? ) ) ) )', + stmt_q => 'SELECT * FROM `test` WHERE ( `Y` = MAX( LENGTH( MIN( ? ) ) ) )', + bind => [[Y => 'x']], + }, ); -plan tests => scalar(@tests) * 2; +plan tests => scalar(grep { !$_->{warning_like} } @tests) * 2 + + scalar(grep { $_->{warning_like} } @tests) * 4; for (@tests) { local $"=', '; my $new = $_->{new} || {}; $new->{debug} = $ENV{DEBUG} || 0; - my $sql = SQL::Abstract->new(%$new); - #print "testing with args (@{$_->{args}}): "; - my $func = $_->{func}; - my($stmt, @bind) = $sql->$func(@{$_->{args}}); - is_same_sql_bind($stmt, \@bind, $_->{stmt}, $_->{bind}); + # test without quoting labels + { + my $sql = SQL::Abstract->new(%$new); + + my $func = $_->{func}; + my($stmt, @bind); + my $test = sub { + ($stmt, @bind) = $sql->$func(@{$_->{args}}) + }; + if ($_->{exception_like}) { + throws_ok { &$test } $_->{exception_like}, "throws the expected exception ($_->{exception_like})"; + } else { + if ($_->{warning_like}) { + warning_like { &$test } $_->{warning_like}, "throws the expected warning ($_->{warning_like})"; + } else { + &$test; + } + is_same_sql_bind($stmt, \@bind, $_->{stmt}, $_->{bind}); + } + } # test with quoted labels - my $sql_q = SQL::Abstract->new(%$new, quote_char => '`', name_sep => '.'); + { + my $sql_q = SQL::Abstract->new(%$new, quote_char => '`', name_sep => '.'); - my $func_q = $_->{func}; - my($stmt_q, @bind_q) = $sql_q->$func_q(@{$_->{args}}); + my $func_q = $_->{func}; + my($stmt_q, @bind_q); + my $test = sub { + ($stmt_q, @bind_q) = $sql_q->$func_q(@{$_->{args}}) + }; + if ($_->{exception_like}) { + throws_ok { &$test } $_->{exception_like}, "throws the expected exception ($_->{exception_like})"; + } else { + if ($_->{warning_like}) { + warning_like { &$test } $_->{warning_like}, "throws the expected warning ($_->{warning_like})"; + } else { + &$test; + } - is_same_sql_bind($stmt_q, \@bind_q, $_->{stmt_q}, $_->{bind}); + is_same_sql_bind($stmt_q, \@bind_q, $_->{stmt_q}, $_->{bind}); + } + } }