X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=t%2F01generate.t;h=245ca557c301e43c29c66170686cb27a47c9e88b;hb=40f2f2311d048aece00793477ab4b734d20f57bc;hp=0211b53bea15cbac9eaba967fe93a623fcc39340;hpb=cd87fd4cb496d50172d60c241bff1060879e431b;p=dbsrgits%2FSQL-Abstract.git diff --git a/t/01generate.t b/t/01generate.t index 0211b53..245ca55 100644 --- a/t/01generate.t +++ b/t/01generate.t @@ -1,16 +1,23 @@ -#!/usr/bin/perl - use strict; use warnings; use Test::More; use Test::Warn; +use Test::Exception; -use SQL::Abstract::Test import => ['is_same_sql_bind']; +use SQL::Abstract::Test import => [qw( is_same_sql_bind diag_where dumper )]; use SQL::Abstract; +#### WARNING #### +# +# -nest has been undocumented on purpose, but is still supported for the +# foreseable future. Do not rip out the -nest tests before speaking to +# someone on the DBIC mailing list or in irc.perl.org#dbix-class +# +################# + + my @tests = ( - #1 { func => 'select', args => ['test', '*'], @@ -18,7 +25,6 @@ my @tests = ( stmt_q => 'SELECT * FROM `test`', bind => [] }, - #2 { func => 'select', args => ['test', [qw(one two three)]], @@ -26,104 +32,77 @@ my @tests = ( stmt_q => 'SELECT `one`, `two`, `three` FROM `test`', bind => [] }, - #3 { func => 'select', args => ['test', '*', { a => 0 }, [qw/boom bada bing/]], stmt => 'SELECT * FROM test WHERE ( a = ? ) ORDER BY boom, bada, bing', stmt_q => 'SELECT * FROM `test` WHERE ( `a` = ? ) ORDER BY `boom`, `bada`, `bing`', bind => [0] - }, - #4 - { + }, + { func => 'select', args => ['test', '*', [ { a => 5 }, { b => 6 } ]], stmt => 'SELECT * FROM test WHERE ( ( a = ? ) OR ( b = ? ) )', stmt_q => 'SELECT * FROM `test` WHERE ( ( `a` = ? ) OR ( `b` = ? ) )', bind => [5,6] - }, - #5 - { + }, + { func => 'select', args => ['test', '*', undef, ['id']], stmt => 'SELECT * FROM test ORDER BY id', stmt_q => 'SELECT * FROM `test` ORDER BY `id`', bind => [] - }, - #6 - { + }, + { func => 'select', args => ['test', '*', { a => 'boom' } , ['id']], stmt => 'SELECT * FROM test WHERE ( a = ? ) ORDER BY id', stmt_q => 'SELECT * FROM `test` WHERE ( `a` = ? ) ORDER BY `id`', bind => ['boom'] - }, - #7 - { + }, + { func => 'select', args => ['test', '*', { a => ['boom', 'bang'] }], stmt => 'SELECT * FROM test WHERE ( ( ( a = ? ) OR ( a = ? ) ) )', stmt_q => 'SELECT * FROM `test` WHERE ( ( ( `a` = ? ) OR ( `a` = ? ) ) )', bind => ['boom', 'bang'] - }, - #8 - { - func => 'select', - args => [[qw/test1 test2/], '*', { 'test1.a' => { 'In', ['boom', 'bang'] } }], - stmt => 'SELECT * FROM test1, test2 WHERE ( test1.a IN ( ?, ? ) )', - stmt_q => 'SELECT * FROM `test1`, `test2` WHERE ( `test1`.`a` IN ( ?, ? ) )', - bind => ['boom', 'bang'] - }, - #9 - { - func => 'select', - args => ['test', '*', { a => { 'between', ['boom', 'bang'] } }], - stmt => 'SELECT * FROM test WHERE ( a BETWEEN ? AND ? )', - stmt_q => 'SELECT * FROM `test` WHERE ( `a` BETWEEN ? AND ? )', - bind => ['boom', 'bang'] - }, - #10 - { + }, + { func => 'select', args => ['test', '*', { a => { '!=', 'boom' } }], stmt => 'SELECT * FROM test WHERE ( a != ? )', stmt_q => 'SELECT * FROM `test` WHERE ( `a` != ? )', bind => ['boom'] - }, - #11 - { + }, + { func => 'update', args => ['test', {a => 'boom'}, {a => undef}], stmt => 'UPDATE test SET a = ? WHERE ( a IS NULL )', stmt_q => 'UPDATE `test` SET `a` = ? WHERE ( `a` IS NULL )', bind => ['boom'] - }, - #12 - { + }, + { func => 'update', args => ['test', {a => 'boom'}, { a => {'!=', "bang" }} ], stmt => 'UPDATE test SET a = ? WHERE ( a != ? )', stmt_q => 'UPDATE `test` SET `a` = ? WHERE ( `a` != ? )', bind => ['boom', 'bang'] - }, - #13 - { + }, + { func => 'update', args => ['test', {'a-funny-flavored-candy' => 'yummy', b => 'oops'}, { a42 => "bang" }], stmt => 'UPDATE test SET a-funny-flavored-candy = ?, b = ? WHERE ( a42 = ? )', stmt_q => 'UPDATE `test` SET `a-funny-flavored-candy` = ?, `b` = ? WHERE ( `a42` = ? )', bind => ['yummy', 'oops', 'bang'] - }, - #14 - { + }, + { func => 'delete', args => ['test', {requestor => undef}], stmt => 'DELETE FROM test WHERE ( requestor IS NULL )', stmt_q => 'DELETE FROM `test` WHERE ( `requestor` IS NULL )', bind => [] - }, - #15 - { + }, + { func => 'delete', args => [[qw/test1 test2 test3/], { 'test1.field' => \'!= test2.field', @@ -132,83 +111,80 @@ my @tests = ( stmt => 'DELETE FROM test1, test2, test3 WHERE ( test1.field != test2.field AND user != ? )', stmt_q => 'DELETE FROM `test1`, `test2`, `test3` WHERE ( `test1`.`field` != test2.field AND `user` != ? )', # test2.field is a literal value, cannnot be quoted. bind => ['nwiger'] - }, - #16 - { + }, + { func => 'insert', args => ['test', {a => 1, b => 2, c => 3, d => 4, e => 5}], stmt => 'INSERT INTO test (a, b, c, d, e) VALUES (?, ?, ?, ?, ?)', stmt_q => 'INSERT INTO `test` (`a`, `b`, `c`, `d`, `e`) VALUES (?, ?, ?, ?, ?)', bind => [qw/1 2 3 4 5/], - }, - #17 - { + }, + { func => 'insert', args => ['test', [qw/1 2 3 4 5/]], stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?)', stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?)', bind => [qw/1 2 3 4 5/], - }, - #18 - { + }, + { func => 'insert', args => ['test', [qw/1 2 3 4 5/, undef]], stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?, ?)', stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?, ?)', bind => [qw/1 2 3 4 5/, undef], - }, - #19 - { + }, + { func => 'update', args => ['test', {a => 1, b => 2, c => 3, d => 4, e => 5}], stmt => 'UPDATE test SET a = ?, b = ?, c = ?, d = ?, e = ?', stmt_q => 'UPDATE `test` SET `a` = ?, `b` = ?, `c` = ?, `d` = ?, `e` = ?', bind => [qw/1 2 3 4 5/], - }, - #20 - { + }, + { func => 'update', args => ['test', {a => 1, b => 2, c => 3, d => 4, e => 5}, {a => {'in', [1..5]}}], stmt => 'UPDATE test SET a = ?, b = ?, c = ?, d = ?, e = ? WHERE ( a IN ( ?, ?, ?, ?, ? ) )', stmt_q => 'UPDATE `test` SET `a` = ?, `b` = ?, `c` = ?, `d` = ?, `e` = ? WHERE ( `a` IN ( ?, ?, ?, ?, ? ) )', bind => [qw/1 2 3 4 5 1 2 3 4 5/], - }, - #21 - { + }, + { func => 'update', args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", '02/02/02']}, {a => {'between', [1,2]}}], stmt => 'UPDATE test SET a = ?, b = to_date(?, \'MM/DD/YY\') WHERE ( a BETWEEN ? AND ? )', stmt_q => 'UPDATE `test` SET `a` = ?, `b` = to_date(?, \'MM/DD/YY\') WHERE ( `a` BETWEEN ? AND ? )', bind => [qw(1 02/02/02 1 2)], - }, - #22 - { + }, + { func => 'insert', args => ['test.table', {high_limit => \'max(all_limits)', low_limit => 4} ], stmt => 'INSERT INTO test.table (high_limit, low_limit) VALUES (max(all_limits), ?)', stmt_q => 'INSERT INTO `test`.`table` (`high_limit`, `low_limit`) VALUES (max(all_limits), ?)', bind => ['4'], - }, - #23 - { + }, + { + func => 'insert', + args => ['test.table', [ \'max(all_limits)', 4 ] ], + stmt => 'INSERT INTO test.table VALUES (max(all_limits), ?)', + stmt_q => 'INSERT INTO `test`.`table` VALUES (max(all_limits), ?)', + bind => ['4'], + }, + { func => 'insert', new => {bindtype => 'columns'}, args => ['test.table', {one => 2, three => 4, five => 6} ], stmt => 'INSERT INTO test.table (five, one, three) VALUES (?, ?, ?)', stmt_q => 'INSERT INTO `test`.`table` (`five`, `one`, `three`) VALUES (?, ?, ?)', bind => [['five', 6], ['one', 2], ['three', 4]], # alpha order, man... - }, - #24 - { + }, + { func => 'select', new => {bindtype => 'columns', case => 'lower'}, args => ['test.table', [qw/one two three/], {one => 2, three => 4, five => 6} ], stmt => 'select one, two, three from test.table where ( five = ? and one = ? and three = ? )', stmt_q => 'select `one`, `two`, `three` from `test`.`table` where ( `five` = ? and `one` = ? and `three` = ? )', bind => [['five', 6], ['one', 2], ['three', 4]], # alpha order, man... - }, - #25 - { + }, + { func => 'update', new => {bindtype => 'columns', cmp => 'like'}, args => ['testin.table2', {One => 22, Three => 44, FIVE => 66}, @@ -219,78 +195,61 @@ my @tests = ( . '( `Beer` LIKE ? AND ( ( `IT` LIKE ? ) OR ( `IT` LIKE ? ) OR ( `IT` LIKE ? ) ) AND `Yummy` LIKE ? )', bind => [['FIVE', 66], ['One', 22], ['Three', 44], ['Beer','is'], ['IT','IS'], ['IT','REALLY'], ['IT','GOOD'], ['Yummy','%YES%']], - }, - #26 - { + }, + { func => 'select', - args => ['test', '*', {priority => [ -and => {'!=', 2}, {'!=', 1} ]}], - stmt => 'SELECT * FROM test WHERE ( ( ( priority != ? ) AND ( priority != ? ) ) )', - stmt_q => 'SELECT * FROM `test` WHERE ( ( ( `priority` != ? ) AND ( `priority` != ? ) ) )', - bind => [qw(2 1)], - }, - #27 - { + args => ['test', '*', {priority => [ -and => {'!=', 2}, { -not_like => '3%'} ]}], + stmt => 'SELECT * FROM test WHERE ( ( ( priority != ? ) AND ( priority NOT LIKE ? ) ) )', + stmt_q => 'SELECT * FROM `test` WHERE ( ( ( `priority` != ? ) AND ( `priority` NOT LIKE ? ) ) )', + bind => [qw(2 3%)], + }, + { func => 'select', - args => ['Yo Momma', '*', { user => 'nwiger', + args => ['Yo Momma', '*', { user => 'nwiger', -nest => [ workhrs => {'>', 20}, geo => 'ASIA' ] }], stmt => 'SELECT * FROM Yo Momma WHERE ( ( ( workhrs > ? ) OR ( geo = ? ) ) AND user = ? )', stmt_q => 'SELECT * FROM `Yo Momma` WHERE ( ( ( `workhrs` > ? ) OR ( `geo` = ? ) ) AND `user` = ? )', bind => [qw(20 ASIA nwiger)], - }, - #28 - { + }, + { func => 'update', args => ['taco_punches', { one => 2, three => 4 }, { bland => [ -and => {'!=', 'yes'}, {'!=', 'YES'} ], tasty => { '!=', [qw(yes YES)] }, -nest => [ face => [ -or => {'=', 'mr.happy'}, {'=', undef} ] ] }, ], -# LDNOTE : modified the test below, same reasons as #14 in 00where.t + warns => qr/\QA multi-element arrayref as an argument to the inequality op '!=' is technically equivalent to an always-true 1=1/, + stmt => 'UPDATE taco_punches SET one = ?, three = ? WHERE ( ( ( ( ( face = ? ) OR ( face IS NULL ) ) ) )' -# . ' AND ( ( bland != ? ) AND ( bland != ? ) ) AND ( ( tasty != ? ) OR ( tasty != ? ) ) )', - . ' AND ( ( bland != ? ) AND ( bland != ? ) ) AND ( ( tasty != ? ) AND ( tasty != ? ) ) )', + . ' AND ( ( bland != ? ) AND ( bland != ? ) ) AND ( ( tasty != ? ) OR ( tasty != ? ) ) )', stmt_q => 'UPDATE `taco_punches` SET `one` = ?, `three` = ? WHERE ( ( ( ( ( `face` = ? ) OR ( `face` IS NULL ) ) ) )' -# . ' AND ( ( `bland` != ? ) AND ( `bland` != ? ) ) AND ( ( `tasty` != ? ) OR ( `tasty` != ? ) ) )', - . ' AND ( ( `bland` != ? ) AND ( `bland` != ? ) ) AND ( ( `tasty` != ? ) AND ( `tasty` != ? ) ) )', + . ' AND ( ( `bland` != ? ) AND ( `bland` != ? ) ) AND ( ( `tasty` != ? ) OR ( `tasty` != ? ) ) )', bind => [qw(2 4 mr.happy yes YES yes YES)], - }, - #29 - { + }, + { func => 'select', - args => ['jeff', '*', { name => {'like', '%smith%', -not_in => ['Nate','Jim','Bob','Sally']}, + args => ['jeff', '*', { name => {'ilike', '%smith%', -not_in => ['Nate','Jim','Bob','Sally']}, -nest => [ -or => [ -and => [age => { -between => [20,30] }, age => {'!=', 25} ], yob => {'<', 1976} ] ] } ], -# LDNOTE : original test below was WRONG with respect to the doc. -# [-and, [cond1, cond2], cond3] should mean (cond1 OR cond2) AND cond3 -# instead of (cond1 AND cond2) OR cond3. -# Probably a misconception because of '=>' notation -# in [-and => [cond1, cond2], cond3]. -# Also some differences in parentheses, but without impact on semantics. -# stmt => 'SELECT * FROM jeff WHERE ( ( ( ( ( ( ( age BETWEEN ? AND ? ) AND ( age != ? ) ) ) OR ( yob < ? ) ) ) )' -# . ' AND name NOT IN ( ?, ?, ?, ? ) AND name LIKE ? )', -# stmt_q => 'SELECT * FROM `jeff` WHERE ( ( ( ( ( ( ( `age` BETWEEN ? AND ? ) AND ( `age` != ? ) ) ) OR ( `yob` < ? ) ) ) )' -# . ' AND `name` NOT IN ( ?, ?, ?, ? ) AND `name` LIKE ? )', - stmt => 'SELECT * FROM jeff WHERE ( ( ( ( ( age BETWEEN ? AND ? ) OR ( age != ? ) ) AND ( yob < ? ) ) )' - . ' AND ( name NOT IN ( ?, ?, ?, ? ) AND name LIKE ? ) )', - stmt_q => 'SELECT * FROM `jeff` WHERE ( ( ( ( ( `age` BETWEEN ? AND ? ) OR ( `age` != ? ) ) AND ( `yob` < ? ) ) )' - . ' AND ( `name` NOT IN ( ?, ?, ?, ? ) AND `name` LIKE ? ) )', + stmt => 'SELECT * FROM jeff WHERE ( ( ( ( ( ( ( age BETWEEN ? AND ? ) AND ( age != ? ) ) ) OR ( yob < ? ) ) ) )' + . ' AND name NOT IN ( ?, ?, ?, ? ) AND name ILIKE ? )', + stmt_q => 'SELECT * FROM `jeff` WHERE ( ( ( ( ( ( ( `age` BETWEEN ? AND ? ) AND ( `age` != ? ) ) ) OR ( `yob` < ? ) ) ) )' + . ' AND `name` NOT IN ( ?, ?, ?, ? ) AND `name` ILIKE ? )', bind => [qw(20 30 25 1976 Nate Jim Bob Sally %smith%)] - }, - #30 - { + }, + { func => 'update', -# LDNOTE : removed the "-maybe", because we no longer admit unknown ops -# args => ['fhole', {fpoles => 4}, [-maybe => {race => [-and => [qw(black white asian)]]}, - args => ['fhole', {fpoles => 4}, [ {race => [-and => [qw(black white asian)]]}, - {-nest => {firsttime => [-or => {'=','yes'}, undef]}}, - [ -and => {firstname => {-not_like => 'candace'}}, {lastname => {-in => [qw(jugs canyon towers)]}} ] ] ], + args => ['fhole', {fpoles => 4}, [ + { race => [qw/-or black white asian /] }, + { -nest => { firsttime => [-or => {'=','yes'}, undef] } }, + { -and => [ { firstname => {-not_like => 'candace'} }, { lastname => {-in => [qw(jugs canyon towers)] } } ] }, + ] ], stmt => 'UPDATE fhole SET fpoles = ? WHERE ( ( ( ( ( ( ( race = ? ) OR ( race = ? ) OR ( race = ? ) ) ) ) ) )' - . ' OR ( ( ( ( firsttime = ? ) OR ( firsttime IS NULL ) ) ) ) OR ( ( ( firstname NOT LIKE ? ) ) AND ( lastname IN ( ?, ?, ? ) ) ) )', + . ' OR ( ( ( ( firsttime = ? ) OR ( firsttime IS NULL ) ) ) ) OR ( ( ( firstname NOT LIKE ? ) ) AND ( lastname IN (?, ?, ?) ) ) )', stmt_q => 'UPDATE `fhole` SET `fpoles` = ? WHERE ( ( ( ( ( ( ( `race` = ? ) OR ( `race` = ? ) OR ( `race` = ? ) ) ) ) ) )' - . ' OR ( ( ( ( `firsttime` = ? ) OR ( `firsttime` IS NULL ) ) ) ) OR ( ( ( `firstname` NOT LIKE ? ) ) AND ( `lastname` IN ( ?, ?, ? ) ) ) )', + . ' OR ( ( ( ( `firsttime` = ? ) OR ( `firsttime` IS NULL ) ) ) ) OR ( ( ( `firstname` NOT LIKE ? ) ) AND ( `lastname` IN( ?, ?, ? )) ) )', bind => [qw(4 black white asian yes candace jugs canyon towers)] }, - #31 { func => 'insert', args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", '02/02/02']}], @@ -298,18 +257,13 @@ my @tests = ( stmt_q => 'INSERT INTO `test` (`a`, `b`) VALUES (?, to_date(?, \'MM/DD/YY\'))', bind => [qw(1 02/02/02)], }, - #32 { func => 'select', -# LDNOTE: modified test below because we agreed with MST that literal SQL -# should not automatically insert a '='; the user has to do it -# args => ['test', '*', { a => \["to_date(?, 'MM/DD/YY')", '02/02/02']}], args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", '02/02/02']}], stmt => q{SELECT * FROM test WHERE ( a = to_date(?, 'MM/DD/YY') )}, stmt_q => q{SELECT * FROM `test` WHERE ( `a` = to_date(?, 'MM/DD/YY') )}, bind => ['02/02/02'], }, - #33 { func => 'insert', new => {array_datatypes => 1}, @@ -318,7 +272,6 @@ my @tests = ( stmt_q => 'INSERT INTO `test` (`a`, `b`) VALUES (?, ?)', bind => [1, [1, 1, 2, 3, 5, 8]], }, - #34 { func => 'insert', new => {bindtype => 'columns', array_datatypes => 1}, @@ -327,7 +280,6 @@ my @tests = ( stmt_q => 'INSERT INTO `test` (`a`, `b`) VALUES (?, ?)', bind => [[a => 1], [b => [1, 1, 2, 3, 5, 8]]], }, - #35 { func => 'update', new => {array_datatypes => 1}, @@ -336,7 +288,6 @@ my @tests = ( stmt_q => 'UPDATE `test` SET `a` = ?, `b` = ?', bind => [1, [1, 1, 2, 3, 5, 8]], }, - #36 { func => 'update', new => {bindtype => 'columns', array_datatypes => 1}, @@ -345,40 +296,35 @@ my @tests = ( stmt_q => 'UPDATE `test` SET `a` = ?, `b` = ?', bind => [[a => 1], [b => [1, 1, 2, 3, 5, 8]]], }, - #37 { func => 'select', args => ['test', '*', { a => {'>', \'1 + 1'}, b => 8 }], stmt => 'SELECT * FROM test WHERE ( a > 1 + 1 AND b = ? )', stmt_q => 'SELECT * FROM `test` WHERE ( `a` > 1 + 1 AND `b` = ? )', bind => [8], - }, - #38 + }, { func => 'select', args => ['test', '*', { a => {'<' => \["to_date(?, 'MM/DD/YY')", '02/02/02']}, b => 8 }], stmt => 'SELECT * FROM test WHERE ( a < to_date(?, \'MM/DD/YY\') AND b = ? )', stmt_q => 'SELECT * FROM `test` WHERE ( `a` < to_date(?, \'MM/DD/YY\') AND `b` = ? )', bind => ['02/02/02', 8], - }, - #39 + }, { #TODO in SQLA >= 2.0 it will die instead (we kept this just because old SQLA passed it through) func => 'insert', args => ['test', {a => 1, b => 2, c => 3, d => 4, e => { answer => 42 }}], stmt => 'INSERT INTO test (a, b, c, d, e) VALUES (?, ?, ?, ?, ?)', stmt_q => 'INSERT INTO `test` (`a`, `b`, `c`, `d`, `e`) VALUES (?, ?, ?, ?, ?)', bind => [qw/1 2 3 4/, { answer => 42}], - warning_like => qr/HASH ref as bind value in insert is not supported/i, - }, - #40 - { + warns => qr/HASH ref as bind value in insert is not supported/i, + }, + { func => 'update', args => ['test', {a => 1, b => \["42"]}, {a => {'between', [1,2]}}], stmt => 'UPDATE test SET a = ?, b = 42 WHERE ( a BETWEEN ? AND ? )', stmt_q => 'UPDATE `test` SET `a` = ?, `b` = 42 WHERE ( `a` BETWEEN ? AND ? )', bind => [qw(1 1 2)], - }, - #41 + }, { func => 'insert', args => ['test', {a => 1, b => \["42"]}], @@ -386,7 +332,6 @@ my @tests = ( stmt_q => 'INSERT INTO `test` (`a`, `b`) VALUES (?, 42)', bind => [qw(1)], }, - #42 { func => 'select', args => ['test', '*', { a => \["= 42"], b => 1}], @@ -394,95 +339,341 @@ my @tests = ( stmt_q => q{SELECT * FROM `test` WHERE ( `a` = 42 ) AND ( `b` = ? )}, bind => [qw(1)], }, - #43 { func => 'select', args => ['test', '*', { a => {'<' => \["42"]}, b => 8 }], stmt => 'SELECT * FROM test WHERE ( a < 42 AND b = ? )', stmt_q => 'SELECT * FROM `test` WHERE ( `a` < 42 AND `b` = ? )', bind => [qw(8)], - }, - - #44 + }, { func => 'insert', new => {bindtype => 'columns'}, - args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", '02/02/02']}], + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", [dummy => '02/02/02']]}], stmt => 'INSERT INTO test (a, b) VALUES (?, to_date(?, \'MM/DD/YY\'))', stmt_q => 'INSERT INTO `test` (`a`, `b`) VALUES (?, to_date(?, \'MM/DD/YY\'))', - bind => [[a => '1'], [b => '02/02/02']], + bind => [[a => '1'], [dummy => '02/02/02']], }, - #45 - { + { func => 'update', new => {bindtype => 'columns'}, - args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", '02/02/02']}, {a => {'between', [1,2]}}], + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", [dummy => '02/02/02']]}, {a => {'between', [1,2]}}], stmt => 'UPDATE test SET a = ?, b = to_date(?, \'MM/DD/YY\') WHERE ( a BETWEEN ? AND ? )', stmt_q => 'UPDATE `test` SET `a` = ?, `b` = to_date(?, \'MM/DD/YY\') WHERE ( `a` BETWEEN ? AND ? )', - bind => [[a => '1'], [b => '02/02/02'], [a => '1'], [a => '2']], - }, - #46 + bind => [[a => '1'], [dummy => '02/02/02'], [a => '1'], [a => '2']], + }, { func => 'select', new => {bindtype => 'columns'}, - args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", '02/02/02']}], + args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", [dummy => '02/02/02']]}], stmt => q{SELECT * FROM test WHERE ( a = to_date(?, 'MM/DD/YY') )}, stmt_q => q{SELECT * FROM `test` WHERE ( `a` = to_date(?, 'MM/DD/YY') )}, - bind => [[a => '02/02/02']], + bind => [[dummy => '02/02/02']], + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => {'<' => \["to_date(?, 'MM/DD/YY')", [dummy => '02/02/02']]}, b => 8 }], + stmt => 'SELECT * FROM test WHERE ( a < to_date(?, \'MM/DD/YY\') AND b = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` < to_date(?, \'MM/DD/YY\') AND `b` = ? )', + bind => [[dummy => '02/02/02'], [b => 8]], + }, + { + func => 'insert', + new => {bindtype => 'columns'}, + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", '02/02/02']}], + throws => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/, + }, + { + func => 'update', + new => {bindtype => 'columns'}, + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", '02/02/02']}, {a => {'between', [1,2]}}], + throws => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/, + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", '02/02/02']}], + throws => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/, }, - #47 { func => 'select', new => {bindtype => 'columns'}, args => ['test', '*', { a => {'<' => \["to_date(?, 'MM/DD/YY')", '02/02/02']}, b => 8 }], + throws => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/, + }, + { + func => 'select', + args => ['test', '*', { foo => { '>=' => [] }} ], + throws => qr/\Qoperator '>=' applied on an empty array (field 'foo')/, + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => {-in => \["(SELECT d FROM to_date(?, 'MM/DD/YY') AS d)", [dummy => '02/02/02']]}, b => 8 }], + stmt => 'SELECT * FROM test WHERE ( a IN (SELECT d FROM to_date(?, \'MM/DD/YY\') AS d) AND b = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` IN (SELECT d FROM to_date(?, \'MM/DD/YY\') AS d) AND `b` = ? )', + bind => [[dummy => '02/02/02'], [b => 8]], + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => {-in => \["(SELECT d FROM to_date(?, 'MM/DD/YY') AS d)", '02/02/02']}, b => 8 }], + throws => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/, + }, + { + func => 'insert', + new => {bindtype => 'columns'}, + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", [{dummy => 1} => '02/02/02']]}], + stmt => 'INSERT INTO test (a, b) VALUES (?, to_date(?, \'MM/DD/YY\'))', + stmt_q => 'INSERT INTO `test` (`a`, `b`) VALUES (?, to_date(?, \'MM/DD/YY\'))', + bind => [[a => '1'], [{dummy => 1} => '02/02/02']], + }, + { + func => 'update', + new => {bindtype => 'columns'}, + args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", [{dummy => 1} => '02/02/02']], c => { -lower => 'foo' }}, {a => {'between', [1,2]}}], + stmt => "UPDATE test SET a = ?, b = to_date(?, 'MM/DD/YY'), c = LOWER ? WHERE ( a BETWEEN ? AND ? )", + stmt_q => "UPDATE `test` SET `a` = ?, `b` = to_date(?, 'MM/DD/YY'), `c` = LOWER ? WHERE ( `a` BETWEEN ? AND ? )", + bind => [[a => '1'], [{dummy => 1} => '02/02/02'], [c => 'foo'], [a => '1'], [a => '2']], + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", [{dummy => 1} => '02/02/02']]}], + stmt => q{SELECT * FROM test WHERE ( a = to_date(?, 'MM/DD/YY') )}, + stmt_q => q{SELECT * FROM `test` WHERE ( `a` = to_date(?, 'MM/DD/YY') )}, + bind => [[{dummy => 1} => '02/02/02']], + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { a => {'<' => \["to_date(?, 'MM/DD/YY')", [{dummy => 1} => '02/02/02']]}, b => 8 }], stmt => 'SELECT * FROM test WHERE ( a < to_date(?, \'MM/DD/YY\') AND b = ? )', stmt_q => 'SELECT * FROM `test` WHERE ( `a` < to_date(?, \'MM/DD/YY\') AND `b` = ? )', - bind => [[a => '02/02/02'], [b => 8]], - }, + bind => [[{dummy => 1} => '02/02/02'], [b => 8]], + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', { -or => [ -and => [ a => 'a', b => 'b' ], -and => [ c => 'c', d => 'd' ] ] }], + stmt => 'SELECT * FROM test WHERE ( a = ? AND b = ? ) OR ( c = ? AND d = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` = ? AND `b` = ? ) OR ( `c` = ? AND `d` = ? )', + bind => [[a => 'a'], [b => 'b'], [ c => 'c'],[ d => 'd']], + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', [ { a => 1, b => 1}, [ a => 2, b => 2] ] ], + stmt => 'SELECT * FROM test WHERE ( a = ? AND b = ? ) OR ( a = ? OR b = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` = ? AND `b` = ? ) OR ( `a` = ? OR `b` = ? )', + bind => [[a => 1], [b => 1], [ a => 2], [ b => 2]], + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', [ [ a => 1, b => 1], { a => 2, b => 2 } ] ], + stmt => 'SELECT * FROM test WHERE ( a = ? OR b = ? ) OR ( a = ? AND b = ? )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` = ? OR `b` = ? ) OR ( `a` = ? AND `b` = ? )', + bind => [[a => 1], [b => 1], [ a => 2], [ b => 2]], + }, + { + func => 'insert', + args => ['test', [qw/1 2 3 4 5/], { returning => 'id' }], + stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?) RETURNING id', + stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?) RETURNING `id`', + bind => [qw/1 2 3 4 5/], + }, + { + func => 'insert', + args => ['test', [qw/1 2 3 4 5/], { returning => 'id, foo, bar' }], + stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?) RETURNING id, foo, bar', + stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?) RETURNING `id, foo, bar`', + bind => [qw/1 2 3 4 5/], + }, + { + func => 'insert', + args => ['test', [qw/1 2 3 4 5/], { returning => [qw(id foo bar) ] }], + stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?) RETURNING id, foo, bar', + stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?) RETURNING `id`, `foo`, `bar`', + bind => [qw/1 2 3 4 5/], + }, + { + func => 'insert', + args => ['test', [qw/1 2 3 4 5/], { returning => \'id, foo, bar' }], + stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?) RETURNING id, foo, bar', + stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?) RETURNING id, foo, bar', + bind => [qw/1 2 3 4 5/], + }, + { + func => 'insert', + args => ['test', [qw/1 2 3 4 5/], { returning => \'id' }], + stmt => 'INSERT INTO test VALUES (?, ?, ?, ?, ?) RETURNING id', + stmt_q => 'INSERT INTO `test` VALUES (?, ?, ?, ?, ?) RETURNING id', + bind => [qw/1 2 3 4 5/], + }, + { + func => 'select', + new => {bindtype => 'columns'}, + args => ['test', '*', [ Y => { '=' => { -max => { -LENGTH => { -min => 'x' } } } } ] ], + stmt => 'SELECT * FROM test WHERE ( Y = ( MAX( LENGTH( MIN ? ) ) ) )', + stmt_q => 'SELECT * FROM `test` WHERE ( `Y` = ( MAX( LENGTH( MIN ? ) ) ) )', + bind => [[Y => 'x']], + }, + { + func => 'select', + args => ['test', '*', { a => { '=' => undef }, b => { -is => undef }, c => { -like => undef } }], + stmt => 'SELECT * FROM test WHERE ( a IS NULL AND b IS NULL AND c IS NULL )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` IS NULL AND `b` IS NULL AND `c` IS NULL )', + bind => [], + warns => qr/\QSupplying an undefined argument to 'LIKE' is deprecated/, + }, + { + func => 'select', + args => ['test', '*', { a => { '!=' => undef }, b => { -is_not => undef }, c => { -not_like => undef } }], + stmt => 'SELECT * FROM test WHERE ( a IS NOT NULL AND b IS NOT NULL AND c IS NOT NULL )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` IS NOT NULL AND `b` IS NOT NULL AND `c` IS NOT NULL )', + bind => [], + warns => qr/\QSupplying an undefined argument to 'NOT LIKE' is deprecated/, + }, + { + func => 'select', + args => ['test', '*', { a => { IS => undef }, b => { LIKE => undef } }], + stmt => 'SELECT * FROM test WHERE ( a IS NULL AND b IS NULL )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` IS NULL AND `b` IS NULL )', + bind => [], + warns => qr/\QSupplying an undefined argument to 'LIKE' is deprecated/, + }, + { + func => 'select', + args => ['test', '*', { a => { 'IS NOT' => undef }, b => { 'NOT LIKE' => undef } }], + stmt => 'SELECT * FROM test WHERE ( a IS NOT NULL AND b IS NOT NULL )', + stmt_q => 'SELECT * FROM `test` WHERE ( `a` IS NOT NULL AND `b` IS NOT NULL )', + bind => [], + warns => qr/\QSupplying an undefined argument to 'NOT LIKE' is deprecated/, + }, ); +# check is( not) => undef +for my $op ( qw(not is is_not), 'is not' ) { + (my $sop = uc $op) =~ s/_/ /gi; -plan tests => scalar(grep { !$_->{warning_like} } @tests) * 2 - + scalar(grep { $_->{warning_like} } @tests) * 4; + $sop = 'IS NOT' if $sop eq 'NOT'; -for (@tests) { - local $"=', '; + for my $uc (0, 1) { + for my $prefix ('', '-') { + push @tests, { + func => 'where', + args => [{ a => { ($prefix . ($uc ? uc $op : lc $op) ) => undef } }], + stmt => "WHERE a $sop NULL", + stmt_q => "WHERE `a` $sop NULL", + bind => [], + }; + } + } +} - my $new = $_->{new} || {}; - $new->{debug} = $ENV{DEBUG} || 0; +# check single-element inequality ops for no warnings +for my $op ( qw(!= <>) ) { + for my $val (undef, 42) { + push @tests, { + func => 'where', + args => [ { x => { "$_$op" => [ $val ] } } ], + stmt => "WHERE x " . ($val ? "$op ?" : 'IS NOT NULL'), + stmt_q => "WHERE `x` " . ($val ? "$op ?" : 'IS NOT NULL'), + bind => [ $val || () ], + } for ('', '-'); # with and without - + } +} - # test without quoting labels - { - my $sql = SQL::Abstract->new(%$new); +# check single-element not-like ops for no warnings, and NULL exception +# (the last two "is not X" are a weird syntax, but mebbe a dialect...) +for my $op (qw(not_like not_rlike), 'not like', 'not rlike', 'is not like','is not rlike') { + (my $sop = uc $op) =~ s/_/ /gi; - my $func = $_->{func}; - my($stmt, @bind); - my $test = sub { - ($stmt, @bind) = $sql->$func(@{$_->{args}}) - }; - if ($_->{warning_like}) { - warning_like { &$test } $_->{warning_like}, "throws the expected warning ($_->{warning_like})"; - } else { - &$test; - } - is_same_sql_bind($stmt, \@bind, $_->{stmt}, $_->{bind}); + for my $val (undef, 42) { + push @tests, { + func => 'where', + args => [ { x => { "$_$op" => [ $val ] } } ], + $val ? ( + stmt => "WHERE x $sop ?", + stmt_q => "WHERE `x` $sop ?", + bind => [ $val ], + ) : ( + stmt => "WHERE x IS NOT NULL", + stmt_q => "WHERE `x` IS NOT NULL", + bind => [], + warns => qr/\QSupplying an undefined argument to '$sop' is deprecated/, + ), + } for ('', '-'); # with and without - } +} + +# check all multi-element inequality/not-like ops for warnings +for my $op ( qw(!= <> not_like not_rlike), 'not like', 'not rlike', 'is not like','is not rlike') { + (my $sop = uc $op) =~ s/_/ /gi; - # test with quoted labels - { - my $sql_q = SQL::Abstract->new(%$new, quote_char => '`', name_sep => '.'); + push @tests, { + func => 'where', + args => [ { x => { "$_$op" => [ 42, 69 ] } } ], + stmt => "WHERE x $sop ? OR x $sop ?", + stmt_q => "WHERE `x` $sop ? OR `x` $sop ?", + bind => [ 42, 69 ], + warns => qr/\QA multi-element arrayref as an argument to the inequality op '$sop' is technically equivalent to an always-true 1=1/, + } for ('', '-'); # with and without - +} + +# check all like/not-like ops for empty-arrayref warnings +for my $op ( qw(like rlike not_like not_rlike), 'not like', 'not rlike', 'is like', 'is not like', 'is rlike', 'is not rlike') { + (my $sop = uc $op) =~ s/_/ /gi; + + push @tests, { + func => 'where', + args => [ { x => { "$_$op" => [] } } ], + stmt => ( $sop =~ /NOT/ ? "WHERE 1=1" : "WHERE 0=1" ), + stmt_q => ( $sop =~ /NOT/ ? "WHERE 1=1" : "WHERE 0=1" ), + bind => [], + warns => qr/\QSupplying an empty arrayref to '$sop' is deprecated/, + } for ('', '-'); # with and without - +} + +for my $t (@tests) { + my $new = $t->{new} || {}; + + for my $quoted (0, 1) { - my $func_q = $_->{func}; - my($stmt_q, @bind_q); - my $test = sub { - ($stmt_q, @bind_q) = $sql_q->$func_q(@{$_->{args}}) + my $maker = SQL::Abstract->new(%$new, $quoted + ? (quote_char => '`', name_sep => '.') + : () + ); + + my($stmt, @bind); + + my $cref = sub { + my $op = $t->{func}; + ($stmt, @bind) = $maker->$op (@ { $t->{args} } ); }; - if ($_->{warning_like}) { - warning_like { &$test } $_->{warning_like}, "throws the expected warning ($_->{warning_like})"; - } else { - &$test; + + if (my $e = $t->{throws}) { + throws_ok( + sub { $cref->() }, + $e, + ) || diag dumper ({ args => $t->{args}, result => $stmt }); } + else { + warnings_like( + sub { $cref->() }, + $t->{warns} || [], + ) || diag dumper ({ args => $t->{args}, result => $stmt }); - is_same_sql_bind($stmt_q, \@bind_q, $_->{stmt_q}, $_->{bind}); + is_same_sql_bind( + $stmt, + \@bind, + $quoted ? $t->{stmt_q}: $t->{stmt}, + $t->{bind} + ); + } } } + +done_testing;