X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=regcomp.c;h=8046c76056890111c4b5a93c5cb37ee6f8fb07d2;hb=f63f8e2fd0961bccc25f9a9f7fffef07b3c2a65a;hp=90500a46786426c2cf31dcde83e54332c0988643;hpb=0407a77bc74fb10c233a2d09d551311e3628eba5;p=p5sagit%2Fp5-mst-13.2.git

diff --git a/regcomp.c b/regcomp.c
index 90500a4..8046c76 100644
--- a/regcomp.c
+++ b/regcomp.c
@@ -69,7 +69,7 @@
  *
  ****    Alterations to Henry's code are...
  ****
- ****    Copyright (c) 1991-1999, Larry Wall
+ ****    Copyright (c) 1991-2000, Larry Wall
  ****
  ****    You may distribute under the terms of either the GNU General Public
  ****    License or the Artistic License, as specified in the README file.
@@ -277,6 +277,7 @@ S_cl_is_anything(pTHX_ struct regnode_charclass_class *cl)
 STATIC void
 S_cl_init(pTHX_ struct regnode_charclass_class *cl)
 {
+    Zero(cl, 1, struct regnode_charclass_class);
     cl->type = ANYOF;
     cl_anything(cl);
 }
@@ -284,10 +285,9 @@ S_cl_init(pTHX_ struct regnode_charclass_class *cl)
 STATIC void
 S_cl_init_zero(pTHX_ struct regnode_charclass_class *cl)
 {
+    Zero(cl, 1, struct regnode_charclass_class);
     cl->type = ANYOF;
     cl_anything(cl);
-    ANYOF_CLASS_ZERO(cl);
-    ANYOF_BITMAP_ZERO(cl);
     if (LOC)
 	cl->flags |= ANYOF_LOCALE;
 }
@@ -765,10 +765,10 @@ S_study_chunk(pTHX_ regnode **scanp, I32 *deltap, regnode *last, scan_data_t *da
 		}
 		if (!scan) 		/* It was not CURLYX, but CURLY. */
 		    scan = next;
-		if (ckWARN(WARN_UNSAFE) && (minnext + deltanext == 0) 
+		if (ckWARN(WARN_REGEXP) && (minnext + deltanext == 0) 
 		    && !(data->flags & (SF_HAS_PAR|SF_IN_PAR))
 		    && maxcount <= REG_INFTY/3) /* Complement check for big count */
-		    Perl_warner(aTHX_ WARN_UNSAFE,
+		    Perl_warner(aTHX_ WARN_REGEXP,
 				"Strange *+?{} on zero-length expression");
 		min += minnext * mincount;
 		is_inf_internal |= (maxcount == REG_INFTY 
@@ -1339,8 +1339,9 @@ Perl_pregcomp(pTHX_ char *exp, char *xend, PMOP *pm)
     if (exp == NULL)
 	FAIL("NULL regexp argument");
 
-    if (PL_curcop == &PL_compiling ? (PL_hints & HINT_UTF8) : IN_UTF8)
+    if (pm->op_pmdynflags & PMdf_UTF8) {
 	PL_reg_flags |= RF_utf8;
+    }
     else
 	PL_reg_flags = 0;
 
@@ -1387,6 +1388,10 @@ Perl_pregcomp(pTHX_ char *exp, char *xend, PMOP *pm)
 	 char, regexp);
     if (r == NULL)
 	FAIL("regexp out of space");
+#ifdef DEBUGGING
+    /* avoid reading uninitialized memory in DEBUGGING code in study_chunk() */
+    Zero(r, sizeof(regexp) + (unsigned)PL_regsize * sizeof(regnode), char);
+#endif
     r->refcnt = 1;
     r->prelen = xend - exp;
     r->precomp = PL_regprecomp;
@@ -1602,7 +1607,7 @@ Perl_pregcomp(pTHX_ char *exp, char *xend, PMOP *pm)
 	    r->reganch &= ~ROPT_SKIP;	/* Used in find_byclass(). */
 	    DEBUG_r((sv = sv_newmortal(),
 		     regprop(sv, (regnode*)data.start_class),
-		     PerlIO_printf(Perl_debug_log, "synthetic stclass.\n",
+		     PerlIO_printf(Perl_debug_log, "synthetic stclass `%s'.\n",
 				   SvPVX(sv))));
 	}
 
@@ -1651,7 +1656,7 @@ Perl_pregcomp(pTHX_ char *exp, char *xend, PMOP *pm)
 	    r->reganch &= ~ROPT_SKIP;	/* Used in find_byclass(). */
 	    DEBUG_r((sv = sv_newmortal(),
 		     regprop(sv, (regnode*)data.start_class),
-		     PerlIO_printf(Perl_debug_log, "synthetic stclass.\n",
+		     PerlIO_printf(Perl_debug_log, "synthetic stclass `%s'.\n",
 				   SvPVX(sv))));
 	}
     }
@@ -2201,8 +2206,8 @@ S_regpiece(pTHX_ I32 *flagp)
 	goto do_curly;
     }
   nest_check:
-    if (ckWARN(WARN_UNSAFE) && !SIZE_ONLY && !(flags&HASWIDTH) && max > REG_INFTY/3) {
-	Perl_warner(aTHX_ WARN_UNSAFE, "%.*s matches null string many times",
+    if (ckWARN(WARN_REGEXP) && !SIZE_ONLY && !(flags&HASWIDTH) && max > REG_INFTY/3) {
+	Perl_warner(aTHX_ WARN_REGEXP, "%.*s matches null string many times",
 	    PL_regcomp_parse - origparse, origparse);
     }
 
@@ -2629,8 +2634,8 @@ tryagain:
 			    FAIL("trailing \\ in regexp");
 			/* FALL THROUGH */
 		    default:
-			if (!SIZE_ONLY && ckWARN(WARN_UNSAFE) && isALPHA(*p))
-			    Perl_warner(aTHX_ WARN_UNSAFE, 
+			if (!SIZE_ONLY && ckWARN(WARN_REGEXP) && isALPHA(*p))
+			    Perl_warner(aTHX_ WARN_REGEXP, 
 					"/%.127s/: Unrecognized escape \\%c passed through",
 					PL_regprecomp,
 					*p);
@@ -2821,9 +2826,9 @@ S_regpposixcc(pTHX_ I32 value)
 			    posixcc[skip + 1] == ']'))))
 			Perl_croak(aTHX_ "Character class [:%.*s:] unknown",
 				   t - s - 1, s + 1); 
-		} else if (ckWARN(WARN_UNSAFE) && !SIZE_ONLY)
+		} else if (ckWARN(WARN_REGEXP) && !SIZE_ONLY)
 		    /* [[=foo=]] and [[.foo.]] are still future. */
-		    Perl_warner(aTHX_ WARN_UNSAFE,
+		    Perl_warner(aTHX_ WARN_REGEXP,
 				"Character class syntax [%c %c] is reserved for future extensions", c, c);
 	    } else {
 		/* Maternal grandfather:
@@ -2839,7 +2844,7 @@ S_regpposixcc(pTHX_ I32 value)
 STATIC void
 S_checkposixcc(pTHX)
 {
-    if (!SIZE_ONLY && ckWARN(WARN_UNSAFE) &&
+    if (!SIZE_ONLY && ckWARN(WARN_REGEXP) &&
 	(*PL_regcomp_parse == ':' ||
 	 *PL_regcomp_parse == '=' ||
 	 *PL_regcomp_parse == '.')) {
@@ -2849,10 +2854,10 @@ S_checkposixcc(pTHX)
 	while(*s && isALNUM(*s))
 	    s++;
 	if (*s && c == *s && s[1] == ']') {
-	    Perl_warner(aTHX_ WARN_UNSAFE,
+	    Perl_warner(aTHX_ WARN_REGEXP,
 			"Character class syntax [%c %c] belongs inside character classes", c, c);
 	    if (c == '=' || c == '.')
-		Perl_warner(aTHX_ WARN_UNSAFE,
+		Perl_warner(aTHX_ WARN_REGEXP,
 			    "Character class syntax [%c %c] is reserved for future extensions", c, c);
 	}
     }
@@ -2891,7 +2896,7 @@ S_regclass(pTHX)
 	    ANYOF_FLAGS(ret) |= ANYOF_INVERT;
     }
 
-    if (!SIZE_ONLY && ckWARN(WARN_UNSAFE))
+    if (!SIZE_ONLY && ckWARN(WARN_REGEXP))
 	checkposixcc();
 
     if (*PL_regcomp_parse == ']' || *PL_regcomp_parse == '-')
@@ -2939,8 +2944,8 @@ S_regclass(pTHX)
 		PL_regcomp_parse += numlen;
 		break;
 	    default:
-		if (!SIZE_ONLY && ckWARN(WARN_UNSAFE) && isALPHA(value))
-		    Perl_warner(aTHX_ WARN_UNSAFE, 
+		if (!SIZE_ONLY && ckWARN(WARN_REGEXP) && isALPHA(value))
+		    Perl_warner(aTHX_ WARN_REGEXP, 
 				"/%.127s/: Unrecognized escape \\%c in character class passed through",
 				PL_regprecomp,
 				(int)value);
@@ -2953,8 +2958,8 @@ S_regclass(pTHX)
 	    need_class = 1;
 	    if (range) { /* a-\d, a-[:digit:] */
 		if (!SIZE_ONLY) {
-		    if (ckWARN(WARN_UNSAFE))
-			Perl_warner(aTHX_ WARN_UNSAFE,
+		    if (ckWARN(WARN_REGEXP))
+			Perl_warner(aTHX_ WARN_REGEXP,
 				    "/%.127s/: false [] range \"%*.*s\" in regexp",
 				    PL_regprecomp,
 				    PL_regcomp_parse - rangebegin,
@@ -3238,8 +3243,8 @@ S_regclass(pTHX)
 		PL_regcomp_parse[1] != ']') {
 		PL_regcomp_parse++;
 		if (namedclass > OOB_NAMEDCLASS) { /* \w-, [:word:]- */
-		    if (ckWARN(WARN_UNSAFE))
-			Perl_warner(aTHX_ WARN_UNSAFE,
+		    if (ckWARN(WARN_REGEXP))
+			Perl_warner(aTHX_ WARN_REGEXP,
 				    "/%.127s/: false [] range \"%*.*s\" in regexp",
 				    PL_regprecomp,
 				    PL_regcomp_parse - rangebegin,
@@ -3332,7 +3337,7 @@ S_regclassutf8(pTHX)
 	listsv = newSVpvn("# comment\n",10);
     }
 
-    if (!SIZE_ONLY && ckWARN(WARN_UNSAFE))
+    if (!SIZE_ONLY && ckWARN(WARN_REGEXP))
 	checkposixcc();
 
     if (*PL_regcomp_parse == ']' || *PL_regcomp_parse == '-')
@@ -3372,10 +3377,10 @@ S_regclassutf8(pTHX)
 		if (!SIZE_ONLY) {
 		    if (value == 'p')
 			Perl_sv_catpvf(aTHX_ listsv,
-				       "+utf8::%.*s\n", n, PL_regcomp_parse);
+				       "+utf8::%.*s\n", (int)n, PL_regcomp_parse);
 		    else
 			Perl_sv_catpvf(aTHX_ listsv,
-				       "!utf8::%.*s\n", n, PL_regcomp_parse);
+				       "!utf8::%.*s\n", (int)n, PL_regcomp_parse);
 		}
 		PL_regcomp_parse = e + 1;
 		lastvalue = OOB_UTF8;
@@ -3417,8 +3422,8 @@ S_regclassutf8(pTHX)
 		PL_regcomp_parse += numlen;
 		break;
 	    default:
-		if (!SIZE_ONLY && ckWARN(WARN_UNSAFE) && isALPHA(value))
-		    Perl_warner(aTHX_ WARN_UNSAFE, 
+		if (!SIZE_ONLY && ckWARN(WARN_REGEXP) && isALPHA(value))
+		    Perl_warner(aTHX_ WARN_REGEXP, 
 				"/%.127s/: Unrecognized escape \\%c in character class passed through",
 				PL_regprecomp,
 				(int)value);
@@ -3428,8 +3433,8 @@ S_regclassutf8(pTHX)
 	if (namedclass > OOB_NAMEDCLASS) {
 	    if (range) { /* a-\d, a-[:digit:] */
 		if (!SIZE_ONLY) {
-		    if (ckWARN(WARN_UNSAFE))
-			Perl_warner(aTHX_ WARN_UNSAFE,
+		    if (ckWARN(WARN_REGEXP))
+			Perl_warner(aTHX_ WARN_REGEXP,
 				    "/%.127s/: false [] range \"%*.*s\" in regexp",
 				    PL_regprecomp,
 				    PL_regcomp_parse - rangebegin,
@@ -3516,8 +3521,8 @@ S_regclassutf8(pTHX)
 		PL_regcomp_parse[1] != ']') {
 		PL_regcomp_parse++;
 		if (namedclass > OOB_NAMEDCLASS) { /* \w-, [:word:]- */
-		    if (ckWARN(WARN_UNSAFE))
-			Perl_warner(aTHX_ WARN_UNSAFE,
+		    if (ckWARN(WARN_REGEXP))
+			Perl_warner(aTHX_ WARN_REGEXP,
 				    "/%.127s/: false [] range \"%*.*s\" in regexp",
 				    PL_regprecomp,
 				    PL_regcomp_parse - rangebegin,
@@ -3641,7 +3646,7 @@ S_reguni(pTHX_ UV uv, char* s, I32* lenp)
 {
     dTHR;
     if (SIZE_ONLY) {
-	U8 tmpbuf[10];
+	U8 tmpbuf[UTF8_MAXLEN];
 	*lenp = uv_to_utf8(tmpbuf, uv) - tmpbuf;
     }
     else
@@ -3936,7 +3941,7 @@ Perl_regprop(pTHX_ SV *sv, regnode *o)
     else if (k == WHILEM && o->flags)			/* Ordinal/of */
 	Perl_sv_catpvf(aTHX_ sv, "[%d/%d]", o->flags & 0xf, o->flags>>4);
     else if (k == REF || k == OPEN || k == CLOSE || k == GROUPP )
-	Perl_sv_catpvf(aTHX_ sv, "%d", ARG(o));	/* Parenth number */
+	Perl_sv_catpvf(aTHX_ sv, "%d", (int)ARG(o));	/* Parenth number */
     else if (k == LOGICAL)
 	Perl_sv_catpvf(aTHX_ sv, "[%d]", o->flags);	/* 2: embedded, otherwise 1 */
     else if (k == ANYOF) {