X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=op.c;h=98239d9dd80cdcb243e0b2e07fe0670174fb1978;hb=78da6883f07d155aeb421dce0d6958c4526de8e6;hp=c7c53e436f60b4fb6931dd4fcd8db6d6bc0d12c0;hpb=1fcf4c126eb604a2803256137e52891a03090e84;p=p5sagit%2Fp5-mst-13.2.git

diff --git a/op.c b/op.c
index c7c53e4..98239d9 100644
--- a/op.c
+++ b/op.c
@@ -2326,11 +2326,7 @@ Perl_fold_constants(pTHX_ register OP *o)
 	    SvIV_please(sv);
 #endif
 	}
-	o = newSVOP(OP_CONST, 0, sv);
-	/* We don't want folded constants to trigger OCTMODE warnings,
-	   so we cheat a bit and mark them OCTAL. AMS 20010709 */
-	o->op_private |= OPpCONST_OCTAL;
-	return o;
+	return newSVOP(OP_CONST, 0, sv);
     }
 
   nope:
@@ -2955,7 +2951,7 @@ Perl_newPMOP(pTHX_ I32 type, I32 flags)
  #ifdef USE_ITHREADS
         {
                 SV* repointer = newSViv(0);
-                av_push(PL_regex_padav,repointer);
+                av_push(PL_regex_padav,SvREFCNT_inc(repointer));
                 pmop->op_pmoffset = av_len(PL_regex_padav);
                 PL_regex_pad = AvARRAY(PL_regex_padav);
         }
@@ -6132,39 +6128,6 @@ Perl_ck_null(pTHX_ OP *o)
 }
 
 OP *
-Perl_ck_octmode(pTHX_ OP *o)
-{
-    OP *p;
-
-    if ((ckWARN(WARN_OCTMODE)
-	/* Add WARN_MKDIR instead of getting rid of WARN_{CHMOD,UMASK}.
-	   Backwards compatibility and consistency are terrible things.
-	   AMS 20010705 */
-	|| (o->op_type == OP_CHMOD && ckWARN(WARN_CHMOD))
-	|| (o->op_type == OP_UMASK && ckWARN(WARN_UMASK))
-	|| (o->op_type == OP_MKDIR && ckWARN(WARN_MKDIR)))
-	&& o->op_flags & OPf_KIDS)
-    {
-	if (o->op_type == OP_MKDIR)
-	    p = cLISTOPo->op_last;		/* mkdir $foo, 0777 */
-	else if (o->op_type == OP_CHMOD)
-	    p = cLISTOPo->op_first->op_sibling;	/* chmod 0777, $foo */
-	else
-	    p = cUNOPo->op_first;		/* umask 0222 */
-
-	if (p->op_type == OP_CONST && !(p->op_private & OPpCONST_OCTAL)) {
-	    int mode = SvIV(cSVOPx_sv(p));
-
-	    Perl_warner(aTHX_ WARN_OCTMODE,
-			"Non-octal literal mode (%d) specified", mode);
-	    Perl_warner(aTHX_ WARN_OCTMODE,
-			"\t(Did you mean 0%d instead?)\n", mode);
-	}
-    }
-    return ck_fun(o);
-}
-
-OP *
 Perl_ck_open(pTHX_ OP *o)
 {
     HV *table = GvHV(PL_hintgv);