X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2Fstrictures.pm;h=05d7d9ff09dcc277b8d9a024ce1ceb68e4ca42e9;hb=7bda951e2e1e9f7ce235459bce6ac6d40633af5a;hp=f4577f8e5cadc9dab0c4d05b6ad16f29af5a1eba;hpb=96c8649be0383f4beae9c4f9157d59c73ac913a5;p=p5sagit%2Fstrictures.git diff --git a/lib/strictures.pm b/lib/strictures.pm index f4577f8..05d7d9f 100644 --- a/lib/strictures.pm +++ b/lib/strictures.pm @@ -7,18 +7,17 @@ BEGIN { *_PERL_LT_5_8_4 = ($] < 5.008004) ? sub(){1} : sub(){0}; } -our $VERSION = '1.004004'; # 1.4.4 +our $VERSION = '1.005005'; sub VERSION { - for ($_[1]) { + my ($class, $version) = @_; + for ($version) { last unless defined && !ref && int != 1; die "Major version specified as $_ - this is strictures version 1"; } - # disable this since Foo->VERSION(undef) correctly returns the version - # and that can happen either if our caller passes undef explicitly or - # because the for above autovivified $_[1] - I could make it stop but - # it's pointless since we don't want to blow up if the caller does - # something valid either. + # passing undef here may either warn or die depending on the version of perl. + # we can't match the caller's warning state in this case, so just disable the + # warning. no warnings 'uninitialized'; shift->SUPER::VERSION(@_); } @@ -41,7 +40,7 @@ sub import { } $ENV{PERL_STRICTURES_EXTRA}; } elsif (! _PERL_LT_5_8_4) { - !!((caller)[1] =~ /^(?:t|xt|lib|blib)/ + !!((caller)[1] =~ /^(?:t|xt|lib|blib)[\\\/]/ and $Smells_Like_VCS) } };