X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2Fgetopts.pl;h=852aae89b18d868694a7c07402ef3a20287d8398;hb=6b8afdafd43a19a5a652c59255c9895c9bcbe27b;hp=7effafa195c9296b05f354d82acf1fd0210113d6;hpb=bf38876a182e0df9dd73362f56cf0ab8b43aa789;p=p5sagit%2Fp5-mst-13.2.git

diff --git a/lib/getopts.pl b/lib/getopts.pl
index 7effafa..852aae8 100644
--- a/lib/getopts.pl
+++ b/lib/getopts.pl
@@ -7,21 +7,23 @@
 sub Getopts {
     local($argumentative) = @_;
     local(@args,$_,$first,$rest);
+    local($errs) = 0;
 
     @args = split( / */, $argumentative );
-    while(($_ = $ARGV[0]) =~ /^-(.)(.*)/) {
+    while(@ARGV && ($_ = $ARGV[0]) =~ /^-(.)(.*)/) {
 	($first,$rest) = ($1,$2);
 	$pos = index($argumentative,$first);
-	if($pos >= $[) {
-	    if($args[$pos+1] eq ':') {
+	if($pos >= 0) {
+	    if($pos < $#args && $args[$pos+1] eq ':') {
 		shift(@ARGV);
 		if($rest eq '') {
+		    ++$errs unless @ARGV;
 		    $rest = shift(@ARGV);
 		}
-		eval "\$opt_$first = \$rest;";
+		${"opt_$first"} = $rest;
 	    }
 	    else {
-		eval "\$opt_$first = 1";
+		${"opt_$first"} = 1;
 		if($rest eq '') {
 		    shift(@ARGV);
 		}
@@ -31,7 +33,8 @@ sub Getopts {
 	    }
 	}
 	else {
-	    print stderr "Unknown option: $first\n";
+	    print STDERR "Unknown option: $first\n";
+	    ++$errs;
 	    if($rest ne '') {
 		$ARGV[0] = "-$rest";
 	    }
@@ -40,6 +43,7 @@ sub Getopts {
 	    }
 	}
     }
+    $errs == 0;
 }
 
 1;