X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2Fbase.pm;h=37f220f63a9641bc68eae51b062d49259587419a;hb=b94834e7ae8798fd802ec459d4401f55ab151f05;hp=cb5840e660d3cc65d10e01d2763d4d12eff61e98;hpb=f30a114324770080b9e0b2bcfb9c2278f5e0a290;p=p5sagit%2Fp5-mst-13.2.git diff --git a/lib/base.pm b/lib/base.pm index cb5840e..37f220f 100644 --- a/lib/base.pm +++ b/lib/base.pm @@ -30,7 +30,7 @@ Cs them. Whether to C a base class package is determined by the absence of a global $VERSION in the base package. If $VERSION is not detected even after loading it, will define $VERSION in the base package, setting it to the string -C<-1, defined by base.pm>. +C<-1, set by base.pm>. =head1 HISTORY @@ -43,8 +43,9 @@ L =cut package base; -use vars qw($VERSION); -$VERSION = "1.01"; + +use 5.006_001; +our $VERSION = "1.03"; sub import { my $class = shift; @@ -53,8 +54,10 @@ sub import { foreach my $base (@_) { next if $pkg->isa($base); - push @{"$pkg\::ISA"}, $base; - unless (exists ${"$base\::"}{VERSION}) { + my $vglob; + if ($vglob = ${"$base\::"}{VERSION} and *$vglob{SCALAR}) { + $$vglob = "-1, set by base.pm" unless defined $$vglob; + } else { eval "require $base"; # Only ignore "Can't locate" errors from our eval require. # Other fatal errors (syntax etc) must be reported. @@ -65,9 +68,9 @@ sub import { "\t(Perhaps you need to 'use' the module ", "which defines that package first.)"); } - ${"$base\::VERSION"} = "-1, set by base.pm" - unless exists ${"$base\::"}{VERSION}; + ${"$base\::VERSION"} = "-1, set by base.pm" unless defined ${"$base\::VERSION"}; } + push @{"$pkg\::ISA"}, $base; # A simple test like (defined %{"$base\::FIELDS"}) will # sometimes produce typo warnings because it would create