X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FSQL%2FTranslator%2FProducer.pm;h=9119da62fd026f13de157af25b896d0d1a8aa188;hb=06baeb2195df54daf9e50033a2050b473271b07d;hp=b2ba10e44b1b4f738e4d6f62b085e8f05fa2b9e8;hpb=1c8ec56e310980f823b2ea35fab59d7a139fa96a;p=dbsrgits%2FSQL-Translator.git diff --git a/lib/SQL/Translator/Producer.pm b/lib/SQL/Translator/Producer.pm index b2ba10e..9119da6 100644 --- a/lib/SQL/Translator/Producer.pm +++ b/lib/SQL/Translator/Producer.pm @@ -20,6 +20,7 @@ package SQL::Translator::Producer; use strict; use vars qw($VERSION); +use Scalar::Util (); $VERSION = '1.59'; sub produce { "" } @@ -32,7 +33,9 @@ sub produce { "" } ## They are special per Producer, and provide support for the old 'now()' ## default value exceptions sub _apply_default_value { - my (undef, $field_ref, $default, $exceptions) = @_; + my (undef, $field, $field_ref, $exceptions) = @_; + my $default = $field->default_value; + return if !defined $default; if ($exceptions and ! ref $default) { for (my $i = 0; $i < @$exceptions; $i += 2) { @@ -47,8 +50,14 @@ sub _apply_default_value { } } + my $type = lc $field->data_type; + my $is_numeric_datatype = ($type =~ /^(?:(?:big|medium|small|tiny)?int(?:eger)?|decimal|double|float|num(?:ber|eric)?|real)$/); + if (ref $default) { $$field_ref .= " DEFAULT $$default"; + } elsif ($is_numeric_datatype && Scalar::Util::looks_like_number ($default) ) { + # we need to check the data itself in addition to the datatype, for basic safety + $$field_ref .= " DEFAULT $default"; } else { $$field_ref .= " DEFAULT '$default'"; }