X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FSQL%2FTranslator%2FProducer%2FPostgreSQL.pm;h=458b9ae1cb823123622c23f768950ed124516672;hb=b178940934ec79968ed16511ec2644f3736c92f2;hp=1c995b9ac794842fe9b19a414e2732deeb119d8e;hpb=50840472b86d71a07ebda8332c4b1bcd74dab01b;p=dbsrgits%2FSQL-Translator.git diff --git a/lib/SQL/Translator/Producer/PostgreSQL.pm b/lib/SQL/Translator/Producer/PostgreSQL.pm index 1c995b9..458b9ae 100644 --- a/lib/SQL/Translator/Producer/PostgreSQL.pm +++ b/lib/SQL/Translator/Producer/PostgreSQL.pm @@ -1,11 +1,9 @@ package SQL::Translator::Producer::PostgreSQL; # ------------------------------------------------------------------- -# $Id: PostgreSQL.pm,v 1.13 2003-08-17 00:46:23 rossta Exp $ +# $Id: PostgreSQL.pm,v 1.22 2004-02-09 23:02:15 kycl4rk Exp $ # ------------------------------------------------------------------- -# Copyright (C) 2003 Ken Y. Clark , -# darren chamberlain , -# Chris Mungall +# Copyright (C) 2002-4 SQLFairy Authors # # This program is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License as @@ -26,11 +24,21 @@ package SQL::Translator::Producer::PostgreSQL; SQL::Translator::Producer::PostgreSQL - PostgreSQL producer for SQL::Translator +=head1 SYNOPSIS + + my $t = SQL::Translator->new( parser => '...', producer => 'PostgreSQL' ); + $t->translate; + +=head1 DESCRIPTION + +Creates a DDL suitable for PostgreSQL. Very heavily based on the Oracle +producer. + =cut use strict; use vars qw[ $DEBUG $WARN $VERSION ]; -$VERSION = sprintf "%d.%02d", q$Revision: 1.13 $ =~ /(\d+)\.(\d+)/; +$VERSION = sprintf "%d.%02d", q$Revision: 1.22 $ =~ /(\d+)\.(\d+)/; $DEBUG = 1 unless defined $DEBUG; use SQL::Translator::Schema::Constants; @@ -42,14 +50,14 @@ my %translate = ( # MySQL types # bigint => 'bigint', - double => 'double precision', - decimal => 'decimal', - float => 'double precision', + double => 'numeric', + decimal => 'numeric', + float => 'numeric', int => 'integer', mediumint => 'integer', smallint => 'smallint', tinyint => 'smallint', - char => 'char', + char => 'character', varchar => 'character varying', longtext => 'text', mediumtext => 'text', @@ -71,7 +79,7 @@ my %translate = ( # Oracle types # number => 'integer', - char => 'char', + char => 'character', varchar2 => 'character varying', long => 'text', CLOB => 'bytea', @@ -85,11 +93,11 @@ my %translate = ( varchar => 'character varying', datetime => 'timestamp', text => 'text', - real => 'double precision', + real => 'numeric', comment => 'text', bit => 'bit', tinyint => 'smallint', - float => 'double precision', + float => 'numeric', ); my %reserved = map { $_, 1 } qw[ @@ -110,7 +118,7 @@ my %reserved = map { $_, 1 } qw[ UNION UNIQUE USER USING VERBOSE WHEN WHERE ]; -my $max_id_length = 30; +my $max_id_length = 62; my %used_identifiers = (); my %global_names; my %unreserve; @@ -170,6 +178,7 @@ sub produce { $output .= header_comment unless ($no_comments); my %used_index_names; + my @fks; for my $table ( $schema->get_tables ) { my $table_name = $table->name or next; $table_name = mk_name( $table_name, '', undef, 1 ); @@ -197,37 +206,30 @@ sub produce { my $data_type = lc $field->data_type; my %extra = $field->extra; my $list = $extra{'list'} || []; - # \todo deal with embedded quotes - my $commalist = "'" . join("','", @$list) . "'"; + # todo deal with embedded quotes + my $commalist = join( ', ', map { qq['$_'] } @$list ); my $seq_name; if ( $data_type eq 'enum' ) { my $len = 0; $len = ($len < length($_)) ? length($_) : $len for (@$list); - my $check_name = mk_name( $table_name.'_'.$field_name, 'chk' ); + my $chk_name = mk_name( $table_name.'_'.$field_name, 'chk' ); push @constraint_defs, - "CONSTRAINT $check_name CHECK (\"$field_name\" IN ($commalist))"; + qq[Constraint "$chk_name" CHECK ("$field_name" ]. + qq[IN ($commalist))]; $data_type = 'character varying'; } elsif ( $data_type eq 'set' ) { - # XXX add a CHECK constraint maybe - # (trickier and slower, than enum :) -# my $len = length $commalist; -# $field_def .= " character varying($len) /* set $commalist */"; $data_type = 'character varying'; } elsif ( $field->is_auto_increment ) { if ( defined $size[0] && $size[0] > 11 ) { - $data_type = ' bigserial'; + $data_type = 'bigserial'; } else { - $data_type = ' serial'; + $data_type = 'serial'; } undef @size; - -# $seq_name = mk_name( $table_name.'_'.$field_name, 'sq' ); -# push @sequence_defs, qq[DROP SEQUENCE "$seq_name";]; -# push @sequence_defs, qq[CREATE SEQUENCE "$seq_name";]; } else { $data_type = defined $translate{ $data_type } ? @@ -236,39 +238,44 @@ sub produce { } if ( $data_type =~ /timestamp/i ) { - if ( defined $size[0] && $size[0] > 13 ) { - $size[0] = 13; + if ( defined $size[0] && $size[0] > 6 ) { + $size[0] = 6; } } if ( $data_type eq 'integer' ) { if ( defined $size[0] ) { - if ( $size[0] > 10 ) { # - $data_type = ' bigint'; + if ( $size[0] > 10 ) { + $data_type = 'bigint'; } elsif ( $size[0] < 5 ) { - $data_type = ' smallint'; + $data_type = 'smallint'; } else { - $data_type = ' integer'; + $data_type = 'integer'; } } else { - $data_type = ' integer'; + $data_type = 'integer'; } - undef @size; } + + # + # PG doesn't need a size for integers or text + # + undef @size if $data_type =~ m/(integer|smallint|bigint|text)/; $field_def .= " $data_type"; if ( defined $size[0] && $size[0] > 0 ) { - $field_def .= '(' . join( ', ', @size ) . ')'; + $field_def .= '(' . join( ',', @size ) . ')'; } # - # Default value + # Default value -- disallow for timestamps # - my $default = $field->default_value; + my $default = $data_type =~ /(timestamp|date)/i + ? undef : $field->default_value; if ( defined $default ) { $field_def .= sprintf( ' DEFAULT %s', ( $field->is_auto_increment && $seq_name ) @@ -292,6 +299,11 @@ sub produce { my $idx_name_default; for my $index ( $table->get_indices ) { my $name = $index->name || ''; + if ( $name ) { + $name = next_unused_name($name, \%used_index_names); + $used_index_names{$name} = $name; + } + my $type = $index->type || NORMAL; my @fields = map { $_ =~ s/\(.+\)//; $_ } @@ -299,33 +311,21 @@ sub produce { $index->fields; next unless @fields; + my $def_start = qq[Constraint "$name" ]; if ( $type eq PRIMARY_KEY ) { - $name ||= mk_name( $table_name, 'pk' ); - $name = next_unused_name($name, \%used_index_names); - # how do I get next_unused_name() to do: ? - $used_index_names{$name} = $name; - push @constraint_defs, 'CONSTRAINT '.$name.' PRIMARY KEY '. + push @constraint_defs, "${def_start}PRIMARY KEY ". '("' . join( '", "', @fields ) . '")'; } elsif ( $type eq UNIQUE ) { - $name ||= mk_name( - $table_name, $name || ++$idx_name_default - ); - $name = next_unused_name($name, \%used_index_names); - $used_index_names{$name} = $name; - push @constraint_defs, 'CONSTRAINT ' . $name . ' UNIQUE ' . + push @constraint_defs, "${def_start}UNIQUE " . '("' . join( '", "', @fields ) . '")'; } elsif ( $type eq NORMAL ) { - $name ||= mk_name( - $table_name, $name || ++$idx_name_default - ); - $name = next_unused_name($name, \%used_index_names); - $used_index_names{$name} = $name; push @index_defs, - qq[CREATE INDEX "$name" on $table_name_ur ("]. - join( '", "', @fields ). - '");'; + 'CREATE INDEX "' . $name . "\" on $table_name_ur (". + join( ', ', map { qq["$_"] } @fields ). + ');' + ; } else { warn "Unknown index type ($type) on table $table_name.\n" @@ -339,40 +339,42 @@ sub produce { my $c_name_default; for my $c ( $table->get_constraints ) { my $name = $c->name || ''; + if ( $name ) { + $name = next_unused_name($name, \%used_index_names); + $used_index_names{$name} = $name; + } + my @fields = map { $_ =~ s/\(.+\)//; $_ } map { unreserve( $_, $table_name ) } $c->fields; + my @rfields = map { $_ =~ s/\(.+\)//; $_ } map { unreserve( $_, $table_name ) } $c->reference_fields; - next unless @fields; + next if !@fields && $c->type ne CHECK_C; + + my $def_start = $name ? qq[Constraint "$name" ] : ''; if ( $c->type eq PRIMARY_KEY ) { - $name ||= mk_name( $table_name, 'pk' ); - $name = next_unused_name($name, \%used_index_names); - $used_index_names{$name} = $name; - push @constraint_defs, "CONSTRAINT $name PRIMARY KEY ". + push @constraint_defs, "${def_start}PRIMARY KEY ". '("' . join( '", "', @fields ) . '")'; } elsif ( $c->type eq UNIQUE ) { - $name ||= mk_name( - $table_name, $name || ++$c_name_default - ); $name = next_unused_name($name, \%used_index_names); $used_index_names{$name} = $name; - push @constraint_defs, "CONSTRAINT $name UNIQUE " . + push @constraint_defs, "${def_start}UNIQUE " . '("' . join( '", "', @fields ) . '")'; } + elsif ( $c->type eq CHECK_C ) { + my $expression = $c->expression; + push @constraint_defs, "${def_start}CHECK ($expression)"; + } elsif ( $c->type eq FOREIGN_KEY ) { - my $def = join(' ', - map { $_ || () } 'FOREIGN KEY', $c->name - ); - - $def .= ' ("' . join( '", "', @fields ) . '")'; - - $def .= ' REFERENCES ' . $c->reference_table; + my $def .= "ALTER TABLE $table_name ADD FOREIGN KEY (" . + join( ', ', map { qq["$_"] } @fields ) . ')' . + "\n REFERENCES " . $c->reference_table; if ( @rfields ) { $def .= ' ("' . join( '", "', @rfields ) . '")'; @@ -391,7 +393,7 @@ sub produce { $def .= ' ON UPDATE '.join( ' ', $c->on_update ); } - push @constraint_defs, $def; + push @fks, "$def;"; } } @@ -412,6 +414,11 @@ sub produce { ); } + if ( @fks ) { + $output .= "--\n-- Foreign Key Definitions\n--\n\n" unless $no_comments; + $output .= join( "\n\n", @fks ); + } + if ( $WARN ) { if ( %truncated ) { warn "Truncated " . keys( %truncated ) . " names:\n"; @@ -518,8 +525,12 @@ sub next_unused_name { =pod +=head1 SEE ALSO + +SQL::Translator, SQL::Translator::Producer::Oracle. + =head1 AUTHOR -Ken Y. Clark Ekclark@cpan.orgE +Ken Y. Clark Ekclark@cpan.orgE. =cut