X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FSQL%2FTranslator%2FProducer%2FOracle.pm;h=ba0b9de2ec095b9580abeaa0620bd029cb6f2bf1;hb=34248db809db43ae0a4202bae70d6bfbec176c2d;hp=29ed316efb3b9a25d31d90fbf660c0d263ac9445;hpb=1ced2a25380c28174c07743b19820ec6d1d4f74f;p=dbsrgits%2FSQL-Translator.git diff --git a/lib/SQL/Translator/Producer/Oracle.pm b/lib/SQL/Translator/Producer/Oracle.pm index 29ed316..ba0b9de 100644 --- a/lib/SQL/Translator/Producer/Oracle.pm +++ b/lib/SQL/Translator/Producer/Oracle.pm @@ -1,23 +1,5 @@ package SQL::Translator::Producer::Oracle; -# ------------------------------------------------------------------- -# Copyright (C) 2002-2009 SQLFairy Authors -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; version 2. -# -# This program is distributed in the hope that it will be useful, but -# WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -# General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA -# 02111-1307 USA -# ------------------------------------------------------------------- - =head1 NAME SQL::Translator::Producer::Oracle - Oracle SQL producer @@ -106,8 +88,9 @@ context the slash will be still there to ensure compatibility with SQLPlus. =cut use strict; -use vars qw[ $VERSION $DEBUG $WARN ]; -$VERSION = '1.59'; +use warnings; +our ( $DEBUG, $WARN ); +our $VERSION = '1.59'; $DEBUG = 0 unless defined $DEBUG; use SQL::Translator::Schema::Constants; @@ -118,9 +101,9 @@ my %translate = ( # MySQL types # bigint => 'number', - double => 'number', + double => 'float', decimal => 'number', - float => 'number', + float => 'float', int => 'number', integer => 'number', mediumint => 'number', @@ -133,7 +116,7 @@ my %translate = ( mediumblob => 'blob', longblob => 'blob', tinytext => 'varchar2', - text => [ 'varchar2', 4000 ], + text => 'clob', longtext => 'clob', mediumtext => 'clob', enum => 'varchar2', @@ -184,6 +167,7 @@ my %translate = ( # my %max_size = ( char => 2000, + float => 126, nchar => 2000, nvarchar2 => 4000, number => [ 38, 127 ], @@ -200,7 +184,6 @@ my %truncated; # Quote used to escape table, field, sequence and trigger names my $quote_char = '"'; -# ------------------------------------------------------------------- sub produce { my $translator = shift; $DEBUG = $translator->debug; @@ -213,20 +196,20 @@ sub produce { my ($output, $create, @table_defs, @fk_defs, @trigger_defs, @index_defs, @constraint_defs); $create .= header_comment unless ($no_comments); - my $qt = 1 if $translator->quote_table_names; - my $qf = 1 if $translator->quote_field_names; + my $qt = 1 if $translator->quote_table_names; + my $qf = 1 if $translator->quote_field_names; if ( $translator->parser_type =~ /mysql/i ) { - $create .= + $create .= "-- We assume that default NLS_DATE_FORMAT has been changed\n". "-- but we set it here anyway to be self-consistent.\n" unless $no_comments; - $create .= + $create .= "ALTER SESSION SET NLS_DATE_FORMAT = 'YYYY-MM-DD HH24:MI:SS';\n\n"; } - for my $table ( $schema->get_tables ) { + for my $table ( $schema->get_tables ) { my ( $table_def, $fk_def, $trigger_def, $index_def, $constraint_def ) = create_table( $table, { @@ -234,8 +217,8 @@ sub produce { show_warnings => $WARN, no_comments => $no_comments, delay_constraints => $delay_constraints, - quote_table_names => $qt, - quote_field_names => $qf, + quote_table_names => $qt, + quote_field_names => $qf, } ); push @table_defs, @$table_def; @@ -251,7 +234,7 @@ sub produce { $view, { add_drop_view => $add_drop_table, - quote_table_names => $qt, + quote_table_names => $qt, } ); push @view_defs, @$view_def; @@ -262,7 +245,7 @@ sub produce { } else { $create .= join (";\n\n", @table_defs, @view_defs, @fk_defs, @index_defs, @constraint_defs); - $create .= ";\n\n"; + $create .= ";\n\n"; # If wantarray is not set we have to add "/" in this statement # DBI->do() needs them omitted # triggers may NOT end with a semicolon @@ -275,10 +258,10 @@ sub produce { sub create_table { my ($table, $options) = @_; - my $qt = $options->{quote_table_names}; - my $qf = $options->{quote_field_names}; + my $qt = $options->{quote_table_names}; + my $qf = $options->{quote_field_names}; my $table_name = $table->name; - my $table_name_q = quote($table_name,$qt); + my $table_name_q = quote($table_name,$qt); my $item = ''; my $drop; @@ -306,7 +289,7 @@ sub create_table { my ( $key, $value ) = each %$opt; if ( ref $value eq 'ARRAY' ) { push @table_options, "$key\n(\n". join ("\n", - map { " $_->[0]\t$_->[1]" } + map { " $_->[0]\t$_->[1]" } map { [ each %$_ ] } @$value )."\n)"; @@ -326,32 +309,36 @@ sub create_table { for my $c ( $table->get_constraints ) { my $name = $c->name || ''; my @fields = map { quote($_,$qf) } $c->fields; - my @rfields = quote($c->reference_fields,$qf); + my @rfields = map { quote($_,$qf) } $c->reference_fields; + next if !@fields && $c->type ne CHECK_C; if ( $c->type eq PRIMARY_KEY ) { # create a name if delay_constraints $name ||= mk_name( $table_name, 'pk' ) if $options->{delay_constraints}; - $name = quote($name,$qf); + $name = quote($name,$qf); push @constraint_defs, ($name ? "CONSTRAINT $name " : '') . - 'PRIMARY KEY (' . join( ', ', @fields ) . ')'; + 'PRIMARY KEY (' . join( ', ', @fields ) . ')'; } elsif ( $c->type eq UNIQUE ) { - # Don't create UNIQUE constraints identical to the primary key - if ( my $pk = $table->primary_key ) { - my $u_fields = join(":", @fields); - my $pk_fields = join(":", $pk->fields); - next if $u_fields eq $pk_fields; - } - if ($name) { - # Force prepend of table_name as ORACLE doesn't allow duplicate - # CONSTRAINT names even for different tables (ORA-02264) - $name = "${table_name}_$name" unless $name =~ /^$table_name/; - } else { + # Don't create UNIQUE constraints identical to the primary key + if ( my $pk = $table->primary_key ) { + my $u_fields = join(":", @fields); + my $pk_fields = join(":", $pk->fields); + next if $u_fields eq $pk_fields; + } + + if ($name) { + # Force prepend of table_name as ORACLE doesn't allow duplicate + # CONSTRAINT names even for different tables (ORA-02264) + $name = mk_name( "${table_name}_$name", 'u' ) unless $name =~ /^$table_name/; + } + else { $name = mk_name( $table_name, 'u' ); - } - $name = quote($name, $qf); + } + + $name = quote($name, $qf); for my $f ( $c->fields ) { my $field_def = $table->get_field( $f ) or next; @@ -368,13 +355,15 @@ sub create_table { } elsif ( $c->type eq CHECK_C ) { $name ||= mk_name( $name || $table_name, 'ck' ); - $name = quote($name, $qf); + $name = quote($name, $qf); my $expression = $c->expression || ''; push @constraint_defs, "CONSTRAINT $name CHECK ($expression)"; } elsif ( $c->type eq FOREIGN_KEY ) { $name = mk_name( join('_', $table_name, $c->fields). '_fk' ); - $name = quote($name, $qf); + $name = quote($name, $qf); + my $on_delete = uc ($c->on_delete || ''); + my $def = "CONSTRAINT $name FOREIGN KEY "; if ( @fields ) { @@ -390,17 +379,17 @@ sub create_table { } if ( $c->match_type ) { - $def .= ' MATCH ' . + $def .= ' MATCH ' . ( $c->match_type =~ /full/i ) ? 'FULL' : 'PARTIAL'; } - if ( $c->on_delete ) { - $def .= ' ON DELETE '.join( ' ', $c->on_delete ); + if ( $on_delete && $on_delete ne "RESTRICT") { + $def .= ' ON DELETE '.$c->on_delete; } # disabled by plu 2007-12-29 - doesn't exist for oracle #if ( $c->on_update ) { - # $def .= ' ON UPDATE '.join( ' ', $c->on_update ); + # $def .= ' ON UPDATE '. $c->on_update; #} push @fk_defs, sprintf("ALTER TABLE %s ADD %s", $table_name_q, $def); @@ -423,7 +412,7 @@ sub create_table { my ( $key, $value ) = each %$opt; if ( ref $value eq 'ARRAY' ) { push @table_options, "$key\n(\n". join ("\n", - map { " $_->[0]\t$_->[1]" } + map { " $_->[0]\t$_->[1]" } map { [ each %$_ ] } @$value )."\n)"; @@ -440,29 +429,29 @@ sub create_table { ? "\n".join("\n", @index_options) : ''; if ( $index_type eq PRIMARY_KEY ) { - $index_name = $index_name ? mk_name( $index_name ) + $index_name = $index_name ? mk_name( $index_name ) : mk_name( $table_name, 'pk' ); - $index_name = quote($index_name, $qf); + $index_name = quote($index_name, $qf); push @field_defs, 'CONSTRAINT '.$index_name.' PRIMARY KEY '. '(' . join( ', ', @fields ) . ')'; } elsif ( $index_type eq NORMAL ) { - $index_name = $index_name ? mk_name( $index_name ) + $index_name = $index_name ? mk_name( $index_name ) : mk_name( $table_name, $index_name || 'i' ); - $index_name = quote($index_name, $qf); - push @index_defs, + $index_name = quote($index_name, $qf); + push @index_defs, "CREATE INDEX $index_name on $table_name_q (". - join( ', ', @fields ). + join( ', ', @fields ). ")$index_options"; } elsif ( $index_type eq UNIQUE ) { - $index_name = $index_name ? mk_name( $index_name ) + $index_name = $index_name ? mk_name( $index_name ) : mk_name( $table_name, $index_name || 'i' ); - $index_name = quote($index_name, $qf); - push @index_defs, + $index_name = quote($index_name, $qf); + push @index_defs, "CREATE UNIQUE INDEX $index_name on $table_name_q (". - join( ', ', @fields ). - ")$index_options"; + join( ', ', @fields ). + ")$index_options"; } else { warn "Unknown index type ($index_type) on table $table_name.\n" @@ -480,7 +469,7 @@ sub create_table { } } - my $table_options = @table_options + my $table_options = @table_options ? "\n".join("\n", @table_options) : ''; push @create, "CREATE TABLE $table_name_q (\n" . join( ",\n", map { " $_" } @field_defs, @@ -503,7 +492,7 @@ sub create_table { sub alter_field { my ($from_field, $to_field, $options) = @_; - my $qt = $options->{quote_table_names}; + my $qt = $options->{quote_table_names}; my ($field_create, $field_defs, $trigger_defs, $field_comments) = create_field($to_field, $options, {}); @@ -522,7 +511,7 @@ sub alter_field { sub add_field { my ($new_field, $options) = @_; - my $qt = $options->{quote_table_names}; + my $qt = $options->{quote_table_names}; my ($field_create, $field_defs, $trigger_defs, $field_comments) = create_field($new_field, $options, {}); @@ -536,8 +525,8 @@ sub add_field { sub create_field { my ($field, $options, $field_name_scope) = @_; - my $qf = $options->{quote_field_names}; - my $qt = $options->{quote_table_names}; + my $qf = $options->{quote_field_names}; + my $qt = $options->{quote_table_names}; my (@create, @field_defs, @trigger_defs, @field_comments); @@ -550,7 +539,7 @@ sub create_field { my $field_name = mk_name( $field->name, '', $field_name_scope, 1 ); - my $field_name_q = quote($field_name, $qf); + my $field_name_q = quote($field_name, $qf); my $field_def = quote($field_name, $qf); $field->name( $field_name ); @@ -570,21 +559,21 @@ sub create_field { $data_type = 'varchar2'; } elsif ( $data_type eq 'set' ) { - # XXX add a CHECK constraint maybe + # XXX add a CHECK constraint maybe # (trickier and slower, than enum :) $data_type = 'varchar2'; } else { - if (defined $translate{ $data_type }) { - if (ref $translate{ $data_type } eq "ARRAY") { - ($data_type,$size[0]) = @{$translate{ $data_type }}; - } else { - $data_type = $translate{ $data_type }; - } - } + if (defined $translate{ $data_type }) { + if (ref $translate{ $data_type } eq "ARRAY") { + ($data_type,$size[0]) = @{$translate{ $data_type }}; + } else { + $data_type = $translate{ $data_type }; + } + } $data_type ||= 'varchar2'; } - + # ensure size is not bigger than max size oracle allows for data type if ( defined $max_size{$data_type} ) { for ( my $i = 0 ; $i < scalar @size ; $i++ ) { @@ -597,7 +586,7 @@ sub create_field { } # - # Fixes ORA-02329: column of datatype LOB cannot be + # Fixes ORA-02329: column of datatype LOB cannot be # unique or a primary key # if ( $data_type eq 'clob' && $field->is_primary_key ) { @@ -621,6 +610,16 @@ sub create_field { undef @size; } + # + # Fixes ORA-00906: missing right parenthesis + # if size is 0 or undefined + # + for (qw/varchar2/) { + if ( $data_type =~ /^($_)$/i ) { + $size[0] ||= $max_size{$_}; + } + } + $field_def .= " $data_type"; if ( defined $size[0] && $size[0] > 0 ) { $field_def .= '(' . join( ',', @size ) . ')'; @@ -632,7 +631,7 @@ sub create_field { my $default = $field->default_value; if ( defined $default ) { # - # Wherein we try to catch a string being used as + # Wherein we try to catch a string being used as # a default value for a numerical field. If "true/false," # then sub "1/0," otherwise just test the truthity of the # argument and use that (naive?). @@ -641,8 +640,8 @@ sub create_field { $default = $$default; } elsif (ref $default) { $default = 'NULL'; - } elsif ( - $data_type =~ /^number$/i && + } elsif ( + $data_type =~ /^number$/i && $default !~ /^-?\d+$/ && $default !~ m/null/i ) { @@ -653,17 +652,17 @@ sub create_field { } else { $default = $default ? "'1'" : "'0'"; } - } elsif ( + } elsif ( $data_type =~ /date/ && ( - $default eq 'current_timestamp' + $default eq 'current_timestamp' || - $default eq 'now()' + $default eq 'now()' ) ) { $default = 'SYSDATE'; } else { $default = $default =~ m/null/i ? 'NULL' : "'$default'" - } + } $field_def .= " DEFAULT $default", } @@ -699,14 +698,14 @@ sub create_field { " INTO :new." . $field_name_q."\n" . " FROM dual;\n" . "END;\n"; - + push @trigger_defs, $trigger; } if ( lc $field->data_type eq 'timestamp' ) { my $base_name = $table_name . "_". $field_name; my $trig_name = quote(mk_name( $base_name, 'ts' ), $qt); - my $trigger = + my $trigger = "CREATE OR REPLACE TRIGGER $trig_name\n". "BEFORE INSERT OR UPDATE ON $table_name_q\n". "FOR EACH ROW WHEN (new.$field_name_q IS NULL)\n". @@ -721,7 +720,7 @@ sub create_field { if ( my $comment = $field->comments ) { $comment =~ s/'/''/g; - push @field_comments, + push @field_comments, "COMMENT ON COLUMN $table_name_q.$field_name_q is\n '" . $comment . "';" unless $options->{no_comments}; } @@ -733,9 +732,9 @@ sub create_field { sub create_view { my ($view, $options) = @_; - my $qt = $options->{quote_table_names}; + my $qt = $options->{quote_table_names}; my $view_name = quote($view->name,$qt); - + my @create; push @create, qq[DROP VIEW $view_name] if $options->{add_drop_view}; @@ -747,18 +746,17 @@ sub create_view { return \@create; } -# ------------------------------------------------------------------- sub mk_name { - my $basename = shift || ''; - my $type = shift || ''; + my $basename = shift || ''; + my $type = shift || ''; $type = '' if $type =~ /^\d/; - my $scope = shift || ''; + my $scope = shift || ''; my $critical = shift || ''; my $basename_orig = $basename; - my $max_name = $type - ? $max_id_length - (length($type) + 1) + my $max_name = $type + ? $max_id_length - (length($type) + 1) : $max_id_length; - $basename = substr( $basename, 0, $max_name ) + $basename = substr( $basename, 0, $max_name ) if length( $basename ) > $max_name; my $name = $type ? "${type}_$basename" : $basename; @@ -788,10 +786,9 @@ sub mk_name { 1; -# ------------------------------------------------------------------- sub quote { my ($name, $q) = @_; - $q && $name ? "$quote_char$name$quote_char" : $name; + $q && $name ? "$quote_char$name$quote_char" : $name; }