X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FSQL%2FTranslator%2FProducer%2FOracle.pm;h=55f1d59f83654cea2816f7ad6e1140a8ad2b288b;hb=021dbce8c0efdaff0a5e470ef04d5aeec01af17d;hp=98f3e2d878daeb156bbafdba47c3035fd257e1a0;hpb=25966689ee94b8c13be69b30e845aee8d95ced45;p=dbsrgits%2FSQL-Translator.git diff --git a/lib/SQL/Translator/Producer/Oracle.pm b/lib/SQL/Translator/Producer/Oracle.pm index 98f3e2d..55f1d59 100644 --- a/lib/SQL/Translator/Producer/Oracle.pm +++ b/lib/SQL/Translator/Producer/Oracle.pm @@ -1,7 +1,7 @@ package SQL::Translator::Producer::Oracle; # ------------------------------------------------------------------- -# $Id: Oracle.pm,v 1.16 2003-08-15 16:16:05 kycl4rk Exp $ +# $Id: Oracle.pm,v 1.24 2003-08-27 02:28:21 kycl4rk Exp $ # ------------------------------------------------------------------- # Copyright (C) 2003 Ken Y. Clark , # darren chamberlain , @@ -24,7 +24,7 @@ package SQL::Translator::Producer::Oracle; use strict; use vars qw[ $VERSION $DEBUG $WARN ]; -$VERSION = sprintf "%d.%02d", q$Revision: 1.16 $ =~ /(\d+)\.(\d+)/; +$VERSION = sprintf "%d.%02d", q$Revision: 1.24 $ =~ /(\d+)\.(\d+)/; $DEBUG = 0 unless defined $DEBUG; use SQL::Translator::Schema::Constants; @@ -45,14 +45,14 @@ my %translate = ( tinyint => 'number', char => 'char', varchar => 'varchar2', - tinyblob => 'CLOB', - blob => 'CLOB', - mediumblob => 'CLOB', - longblob => 'CLOB', - longtext => 'long', - mediumtext => 'long', - text => 'long', - tinytext => 'long', + tinyblob => 'blob', + blob => 'blob', + mediumblob => 'blob', + longblob => 'blob', + tinytext => 'varchar2', + text => 'clob', + longtext => 'clob', + mediumtext => 'clob', enum => 'varchar2', set => 'varchar2', date => 'date', @@ -86,6 +86,13 @@ my %translate = ( macaddr => 'varchar2', bit => 'number', 'bit varying' => 'number', + + # + # Oracle types + # + number => 'number', + varchar2 => 'varchar2', + long => 'clob', ); # @@ -174,10 +181,11 @@ sub produce { my @size = $field->size; my %extra = $field->extra; my $list = $extra{'list'} || []; - my $commalist = join ",", @$list; + # \todo deal with embedded quotes + my $commalist = join( ', ', map { qq['$_'] } @$list ); if ( $data_type eq 'enum' ) { - $check = "CHECK ($field_name IN ($commalist))"; + $check = "CHECK ($field_name_ur IN ($commalist))"; $data_type = 'varchar2'; } elsif ( $data_type eq 'set' ) { @@ -190,28 +198,75 @@ sub produce { $translate{ $data_type } : die "Unknown datatype: $data_type\n"; } + + # + # Fixes ORA-02329: column of datatype LOB cannot be + # unique or a primary key + # + if ( $data_type eq 'clob' && $field->is_primary_key ) { + $data_type = 'varchar2'; + $size[0] = 4000; + warn "CLOB cannot be a primary key, changing to VARCHAR2\n" + if $WARN; + } + + # + # Fixes ORA-00907: missing right parenthesis + # + if ( $data_type =~ /(date|clob)/i ) { + undef @size; + } $field_def .= " $data_type"; if ( defined $size[0] && $size[0] > 0 ) { $field_def .= '(' . join( ', ', @size ) . ')'; } - + # # Default value # my $default = $field->default_value; if ( defined $default ) { - $field_def .= sprintf( - ' DEFAULT %s', - $default =~ m/null/i ? 'NULL' : "'$default'" - ); + # + # Wherein we try to catch a string being used as + # a default value for a numerical field. If "true/false," + # then sub "1/0," otherwise just test the truthity of the + # argument and use that (naive?). + # + if ( + $data_type =~ /^number$/i && + $default !~ /^\d+$/ && + $default !~ m/null/i + ) { + if ( $default =~ /^true$/i ) { + $default = "'1'"; + } + elsif ( $default =~ /^false$/i ) { + $default = "'0'"; + } + else { + $default = $default ? "'1'" : "'0'"; + } + } + elsif ( + $data_type =~ /date/ && $default eq 'current_timestamp' + ) { + $default = 'SYSDATE'; + } + else { + $default = $default =~ m/null/i ? 'NULL' : "'$default'" + } + + $field_def .= " DEFAULT $default", } # # Not null constraint # unless ( $field->is_nullable ) { - my $constraint_name = mk_name($field_name_ur, 'nn'); + my $constraint_name = mk_name( + join('_', $table_name_ur, $field_name_ur ), 'nn' + ); $field_def .= ' CONSTRAINT ' . $constraint_name . ' NOT NULL'; } @@ -247,9 +302,9 @@ sub produce { push @trigger_defs, "CREATE OR REPLACE TRIGGER $trig_name\n". "BEFORE INSERT OR UPDATE ON $table_name_ur\n". - "FOR EACH ROW WHEN (new.$field_name_ur} IS NULL)\n". + "FOR EACH ROW WHEN (new.$field_name_ur IS NULL)\n". "BEGIN \n". - " SELECT sysdate INTO :new.$field_name_ur} FROM dual;\n". + " SELECT sysdate INTO :new.$field_name_ur FROM dual;\n". "END;\n/"; } @@ -265,13 +320,12 @@ sub produce { # # Table constraints # - my $constraint_name_default; for my $c ( $table->get_constraints ) { my $name = $c->name || ''; my @fields = map { unreserve( $_, $table_name ) } $c->fields; my @rfields = map { unreserve( $_, $table_name ) } $c->reference_fields; - next unless @fields; + next if !@fields && $c->type ne CHECK_C; if ( $c->type eq PRIMARY_KEY ) { $name ||= mk_name( $table_name, 'pk' ); @@ -279,19 +333,26 @@ sub produce { '(' . join( ', ', @fields ) . ')'; } elsif ( $c->type eq UNIQUE ) { - $name ||= mk_name( $table_name, ++$constraint_name_default ); + $name ||= mk_name( $table_name, 'u' ); push @constraint_defs, "CONSTRAINT $name UNIQUE " . '(' . join( ', ', @fields ) . ')'; } + elsif ( $c->type eq CHECK_C ) { + $name ||= mk_name( $table_name, 'ck' ); + my $expression = $c->expression || ''; + push @constraint_defs, "CONSTRAINT $name CHECK ($expression)"; + } elsif ( $c->type eq FOREIGN_KEY ) { - $name ||= mk_name( $table_name, ++$constraint_name_default ); + $name ||= mk_name( join('_', $table_name, $c->fields), 'fk' ); my $def = "CONSTRAINT $name FOREIGN KEY "; if ( @fields ) { - $def .= join( ', ', @fields ); + $def .= '(' . join( ', ', @fields ) . ')'; } - $def .= ' REFERENCES ' . $c->reference_table; + my $ref_table = unreserve($c->reference_table); + + $def .= " REFERENCES $ref_table"; if ( @rfields ) { $def .= ' (' . join( ', ', @rfields ) . ')'; @@ -318,7 +379,6 @@ sub produce { # Index Declarations # my @index_defs = (); - my $idx_name_default; for my $index ( $table->get_indices ) { my $index_name = $index->name || ''; my $index_type = $index->type || NORMAL; @@ -327,22 +387,12 @@ sub produce { next unless @fields; if ( $index_type eq PRIMARY_KEY ) { - $index_name = mk_name( $table_name, 'pk' ); + $index_name ||= mk_name( $table_name, 'pk' ); push @field_defs, 'CONSTRAINT '.$index_name.' PRIMARY KEY '. '(' . join( ', ', @fields ) . ')'; } - elsif ( $index_type eq UNIQUE ) { - $index_name = mk_name( - $table_name, $index_name || ++$idx_name_default - ); - push @field_defs, 'CONSTRAINT ' . $index_name . ' UNIQUE ' . - '(' . join( ', ', @fields ) . ')'; - } - elsif ( $index_type eq NORMAL ) { - $index_name = mk_name( - $table_name, $index_name || ++$idx_name_default - ); + $index_name ||= mk_name( $table_name, $index_name || 'i' ); push @index_defs, "CREATE INDEX $index_name on $table_name_ur (". join( ', ', @fields ). @@ -356,9 +406,17 @@ sub produce { my $create_statement; $create_statement = "DROP TABLE $table_name_ur;\n" if $add_drop_table; - $create_statement .= - join( ",\n", map { "-- $_" } $table->comments ) . - "CREATE TABLE $table_name_ur (\n" . + + if ( my @table_comments = $table->comments ) { + for my $comment ( @table_comments ) { + next unless $comment; + push @field_comments, "COMMENT ON TABLE $table_name is\n '". + $comment."';" + ; + } + } + + $create_statement .= "CREATE TABLE $table_name_ur (\n" . join( ",\n", map { " $_" } @field_defs, @constraint_defs ) . "\n);" ; @@ -393,6 +451,7 @@ sub produce { sub mk_name { my $basename = shift || ''; my $type = shift || ''; + $type = '' if $type =~ /^\d/; my $scope = shift || ''; my $critical = shift || ''; my $basename_orig = $basename;