X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FPerl%2FCritic%2FPolicy%2FDynamicMoose%2FRequireMethodModifiers.pm;h=92dea4909e5dfca5a584f2f303f0582bfeecfb54;hb=6b73059a541a2d93f7c0cbb375233eb938420876;hp=54a6efdd28588c982146c4e949908dcd9eb9cafd;hpb=4832e38cb3e0487a00304d59af6233c322670e7b;p=gitmo%2FPerl-Critic-Dynamic-Moose.git diff --git a/lib/Perl/Critic/Policy/DynamicMoose/RequireMethodModifiers.pm b/lib/Perl/Critic/Policy/DynamicMoose/RequireMethodModifiers.pm index 54a6efd..92dea49 100644 --- a/lib/Perl/Critic/Policy/DynamicMoose/RequireMethodModifiers.pm +++ b/lib/Perl/Critic/Policy/DynamicMoose/RequireMethodModifiers.pm @@ -1,6 +1,6 @@ package Perl::Critic::Policy::DynamicMoose::RequireMethodModifiers; use Moose; -extends 'Perl::Critic::Policy::DynamicMoose'; +extends 'Perl::Critic::DynamicMoosePolicy'; use Perl::Critic::Utils ':severities'; use Perl::Critic::Utils::Moose 'meta_type'; @@ -9,13 +9,13 @@ Readonly::Scalar my $EXPL => q{Method modifiers make it clear that you're overri sub default_severity { $SEVERITY_LOW } sub violates_metaclass { - my $self = shift; - my $meta = shift; + my $self = shift; + my $class = shift; my @violations; - for my $name ($meta->get_method_list) { - my $method = $meta->get_method($name); + for my $name ($class->get_method_list) { + my $method = $class->get_method($name); # override and augment modifiers are always fine. next if $method->isa('Moose::Meta::Method::Overridden') @@ -35,12 +35,12 @@ sub violates_metaclass { # XXX: this freaking sucks next if $name eq 'meta' || $name eq 'BUILD' || $name eq 'DEMOLISH'; - my $next = $meta->find_next_method_by_name($name); + my $next = $class->find_next_method_by_name($name); # Adding new methods is always fine. next if !$next; - push @violations, $self->violation("The '$name' method of class " . $meta->name . " does not use a method modifier to override its superclass implementation.", $EXPL); + push @violations, $self->violation("The '$name' method of class " . $class->name . " does not use a method modifier to override its superclass implementation.", $EXPL); } return @violations;