X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FPerl%2FCritic%2FPolicy%2FDynamicMoose%2FProhibitPublicBuilders.pm;h=2d93702c3eba0e7905e33a90d86bd9b1d7c25c31;hb=7b3c959c8a0ea21030251f148f37910e4cf3d6b0;hp=90155abcf281c612421066d32d980461d4cc29ff;hpb=8a69e820c5db791149ecb823a0a20e05757c7f97;p=gitmo%2FPerl-Critic-Dynamic-Moose.git diff --git a/lib/Perl/Critic/Policy/DynamicMoose/ProhibitPublicBuilders.pm b/lib/Perl/Critic/Policy/DynamicMoose/ProhibitPublicBuilders.pm index 90155ab..2d93702 100644 --- a/lib/Perl/Critic/Policy/DynamicMoose/ProhibitPublicBuilders.pm +++ b/lib/Perl/Critic/Policy/DynamicMoose/ProhibitPublicBuilders.pm @@ -2,6 +2,8 @@ package Perl::Critic::Policy::DynamicMoose::ProhibitPublicBuilders; use Moose; extends 'Perl::Critic::Policy::DynamicMoose'; +use Perl::Critic::Util::Moose 'meta_type'; + Readonly::Scalar my $EXPL => q{Prefix builder method names with an underscore}; augment applies_to_metaclass => sub { 'Moose::Meta::Role' }; @@ -30,7 +32,8 @@ sub violates_metaclass { } if ($builder !~ /^_/) { - my $desc = "Builder method '$builder' of attribute '$attribute' of class '$classname' is public"; + my $type = meta_type($meta); + my $desc = "Builder method '$builder' of attribute '$attribute' of $type '$classname' is public"; push @violations, $self->violation($desc, $EXPL); } }