X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FObject%2FRemote%2FReadChannel.pm;h=5d7e9f05c12fdd4f8055d1fde15423079984f1d2;hb=8506bc0849fa561ef232a09e0394c417bc437aa2;hp=5de5bf131a6edd0e8a69674b37f263ffc28404f2;hpb=5d59cb9859e004df5cde5d83aa7230e621a28b95;p=scpubgit%2FObject-Remote.git diff --git a/lib/Object/Remote/ReadChannel.pm b/lib/Object/Remote/ReadChannel.pm index 5de5bf1..5d7e9f0 100644 --- a/lib/Object/Remote/ReadChannel.pm +++ b/lib/Object/Remote/ReadChannel.pm @@ -1,8 +1,8 @@ package Object::Remote::ReadChannel; use CPS::Future; -use Scalar::Util qw(weaken); -use Object::Remote::Logging qw(:log); +use Scalar::Util qw(weaken openhandle); +use Object::Remote::Logging qw(:log :dlog); use Moo; has fh => ( @@ -29,10 +29,10 @@ has _receive_data_buffer => (is => 'ro', default => sub { my $x = ''; \$x }); sub _receive_data_from { my ($self, $fh) = @_; - log_trace { "Preparing to read data" }; + Dlog_trace { "Preparing to read data from $_" } $fh; my $rb = $self->_receive_data_buffer; - my $len = sysread($fh, $$rb, 1024, length($$rb)); - my $err = defined($len) ? '' : ": $!"; + my $len = sysread($fh, $$rb, 32768, length($$rb)); + my $err = defined($len) ? 'eof' : ": $!"; if (defined($len) and $len > 0) { log_trace { "Read $len bytes of data" }; while (my $cb = $self->on_line_call and $$rb =~ s/^(.*)\n//) { @@ -45,6 +45,7 @@ sub _receive_data_from { handle => $self->fh, on_read_ready => 1 ); + log_trace { "Invoking on_close_call() for dead read channel" }; $self->on_close_call->($err); } } @@ -53,11 +54,14 @@ sub DEMOLISH { my ($self, $gd) = @_; return if $gd; log_trace { "read channel is being demolished" }; + Object::Remote->current_loop ->unwatch_io( handle => $self->fh, on_read_ready => 1 ); + + } 1;