X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FObject%2FRemote%2FLogging%2FLogger.pm;h=888d9984bfbc5626e65f241531c34b9fb394105e;hb=d672a9bff87112bf8cfea0a5749e934d4c8c996e;hp=68adaf85363b063b4f3e92743c140a7b62b5f967;hpb=eb49c7df7a88ac9114188e9eeb1480205bea97ee;p=scpubgit%2FObject-Remote.git diff --git a/lib/Object/Remote/Logging/Logger.pm b/lib/Object/Remote/Logging/Logger.pm index 68adaf8..888d998 100644 --- a/lib/Object/Remote/Logging/Logger.pm +++ b/lib/Object/Remote/Logging/Logger.pm @@ -6,7 +6,7 @@ use Scalar::Util qw(weaken); has format => ( is => 'ro', required => 1, default => sub { '%l: %s' } ); has level_names => ( is => 'ro', required => 1 ); has min_level => ( is => 'ro', required => 1 ); -has max_level => ( is => 'ro' ); +has max_level => ( is => 'ro', required => 1, deafult => sub { 'info' } ); has _level_active => ( is => 'lazy' ); sub BUILD { @@ -68,7 +68,8 @@ sub _create_format_lookup { r => $self->_render_remote($metadata->{object_remote}), s => $self->_render_log(@$content), l => $level, c => $metadata->{controller}, p => $metadata->{package}, m => $method, - f => $metadata->{filename}, i => $metadata->{line}, + f => $metadata->{filename}, i => $metadata->{line}, + h => $metadata->{hostname}, P => $metadata->{pid}, }; } @@ -77,7 +78,7 @@ sub _get_format_var_value { my ($self, $name, $data) = @_; my $val = $data->{$name}; return $val if defined $val; - return ''; + return '(undefined)'; } sub _render_time { @@ -100,7 +101,7 @@ sub _render { my $var_table = $self->_create_format_lookup($level, $metadata, [@content]); my $template = $self->format; - $template =~ s/%([\w])/$self->_get_format_var_value($1, $var_table)/ge; + $template =~ s/%([\w%])/$self->_get_format_var_value($1, $var_table)/ge; chomp($template); $template =~ s/\n/\n /g;