X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FObject%2FRemote%2FLogging%2FLogger.pm;h=78f3890b899e661dc36d1125e676c7a129e5b7df;hb=a577b9530c7c091e6800bca9dca4fd03c37ce039;hp=65b42b95695f34131f0283f28c5dfbd8fd9bb68e;hpb=f21127fd8c611eee83f769422168bb7bf3b25f0a;p=scpubgit%2FObject-Remote.git diff --git a/lib/Object/Remote/Logging/Logger.pm b/lib/Object/Remote/Logging/Logger.pm index 65b42b9..78f3890 100644 --- a/lib/Object/Remote/Logging/Logger.pm +++ b/lib/Object/Remote/Logging/Logger.pm @@ -48,8 +48,8 @@ sub AUTOLOAD { } sub _build_max_level { - my ($self) = @_; - return $self->level_names->[-1]; + my ($self) = @_; + return $self->level_names->[-1]; } sub _build__level_active { @@ -88,7 +88,8 @@ sub _create_format_lookup { $method = '(none)' unless defined $method; return { - '%' => '%', t => $self->_render_time($metadata->{timestamp}), + '%' => '%', 'n' => "\n", + t => $self->_render_time($metadata->{timestamp}), r => $self->_render_remote($metadata->{object_remote}), s => $self->_render_log(@$content), l => $level, c => $metadata->{controller}, p => $metadata->{package}, m => $method, @@ -111,8 +112,10 @@ sub _render_time { sub _render_remote { my ($self, $remote) = @_; - return 'local' if ! defined $remote || ! defined $remote->{connection_id}; - return 'remote #' . $remote->{connection_id}; + return 'local' unless defined $remote; + my $conn_id = $remote->{connection_id}; + $conn_id = '(uninit)' unless defined $conn_id; + return "remote #$conn_id"; } sub _render_log { @@ -172,7 +175,7 @@ Object::Remote::Logging::Logger - Format and output a log message #router will hold this logger forever #and send it all log messages - router->connect(Object::Remote::Logging::WarnLogger->new( + router->connect(Object::Remote::Logging::Logger->new( level_names => arg_levels, format => '%s at %f line %i, log level: %l' min_level => 'warn', max_level => 'error', )); @@ -301,7 +304,7 @@ received the log message on the local interpreter if the log message was forward =item %r -Log::Remote connection information rendered into a string. +Object::Remote connection information rendered into a string. =item %c @@ -336,6 +339,10 @@ Process id of the Perl interpreter that generated the log message. A literal %. +=item %n + +A newline. + =back =back