X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FObject%2FRemote%2FConnection.pm;h=b8145abeaf7bc01d867a2fcd2972bd1d4486dc36;hb=fb94f5454a40bdf22df64315c968a8d9b35ae40c;hp=8e132a6c04c0de7853b226e3daa67b1bc4fb9d2e;hpb=353556c4b81bcb3a0c3fff934eff5ab2f19733d4;p=scpubgit%2FObject-Remote.git diff --git a/lib/Object/Remote/Connection.pm b/lib/Object/Remote/Connection.pm index 8e132a6..b8145ab 100644 --- a/lib/Object/Remote/Connection.pm +++ b/lib/Object/Remote/Connection.pm @@ -1,6 +1,6 @@ package Object::Remote::Connection; -use Object::Remote::Logging qw (:log :dlog); +use Object::Remote::Logging qw (:log :dlog router); use Object::Remote::Future; use Object::Remote::Null; use Object::Remote::Handle; @@ -18,6 +18,8 @@ use JSON::PP qw(encode_json); use Moo; BEGIN { + router()->exclude_forwarding; + #this will reap child processes as soon #as they are done executing so the process #table cleans up as fast as possible but @@ -55,8 +57,6 @@ END { kill(1, -2); } -our $DEBUG = !!$ENV{OBJECT_REMOTE_DEBUG}; - has _id => ( is => 'ro', required => 1, default => sub { our $NEXT_CONNECTION_ID++ } ); has send_to_fh => ( @@ -77,8 +77,8 @@ has read_channel => ( weaken($self); $ch->on_line_call(sub { $self->_receive(@_) }); $ch->on_close_call(sub { - log_trace { "invoking 'done' on on_close handler for connection id '$id'" }; - $self->on_close->done(@_); + log_trace { "invoking 'done' on on_close handler for connection id '$id'" }; + $self->on_close->done(@_); }); }, ); @@ -181,15 +181,15 @@ sub _build__json { } )->filter_json_single_key_object( __remote_tied_hash__ => sub { - my %tied_hash; - tie %tied_hash, 'Object::Remote::Tied', $self->_id_to_remote_object(@_); - return \%tied_hash; + my %tied_hash; + tie %tied_hash, 'Object::Remote::Tied', $self->_id_to_remote_object(@_); + return \%tied_hash; } )->filter_json_single_key_object( __remote_tied_array__ => sub { - my @tied_array; - tie @tied_array, 'Object::Remote::Tied', $self->_id_to_remote_object(@_); - return \@tied_array; + my @tied_array; + tie @tied_array, 'Object::Remote::Tied', $self->_id_to_remote_object(@_); + return \@tied_array; } ); } @@ -197,7 +197,7 @@ sub _build__json { sub _load_if_possible { my ($class) = @_; - eval "require $class"; + use_module($class); if ($@) { log_debug { "Attempt at loading '$class' failed with '$@'" }; @@ -355,7 +355,6 @@ sub _serialize { local our @New_Ids = (-1); return eval { my $flat = $self->_encode($self->_deobjectify($data)); - warn "$$ >>> ${flat}\n" if $DEBUG; $flat; } || do { my $err = $@; # won't get here if the eval doesn't die @@ -421,7 +420,6 @@ sub _deobjectify { sub _receive { my ($self, $flat) = @_; - warn "$$ <<< $flat\n" if $DEBUG; Dlog_trace { my $l = length($flat); "Starting to deserialize $l characters of data for connection $_" } $self->_id; my ($type, @rest) = eval { @{$self->_deserialize($flat)} } or do { warn "Deserialize failed for ${flat}: $@"; return };