X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FUtil.pm;h=5ee599042798de5eda9a074d571ae3956b7a1fac;hb=999072aba606906b12c2f18e0ebde72e224de4dc;hp=393bccf9940732a68df841d3c9234356f263be2b;hpb=823419c540f9e77090f31f11e04b14477c0372c4;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Util.pm b/lib/Mouse/Util.pm index 393bccf..5ee5990 100644 --- a/lib/Mouse/Util.pm +++ b/lib/Mouse/Util.pm @@ -48,7 +48,7 @@ BEGIN{ }, ); - our $VERSION = '0.70'; + our $VERSION = '0.82'; my $xs = !(defined(&is_valid_class_name) || $ENV{MOUSE_PUREPERL} || $ENV{PERL_ONLY}); @@ -274,29 +274,37 @@ sub is_class_loaded; sub apply_all_roles { my $consumer = Scalar::Util::blessed($_[0]) - ? shift # instance - : Mouse::Meta::Class->initialize(shift); # class or role name + ? $_[0] # instance + : Mouse::Meta::Class->initialize($_[0]); # class or role name my @roles; # Basis of Data::OptList my $max = scalar(@_); - for (my $i = 0; $i < $max ; $i++) { - if ($i + 1 < $max && ref($_[$i + 1])) { - push @roles, [ $_[$i] => $_[++$i] ]; - } else { - push @roles, [ $_[$i] => undef ]; + for (my $i = 1; $i < $max ; $i++) { + my $role = $_[$i]; + my $role_name; + if(ref $role) { + $role_name = $role->name; + } + else { + $role_name = $role; + load_class($role_name); + $role = get_metaclass_by_name($role_name); } - my $role_name = $roles[-1][0]; - load_class($role_name); - is_a_metarole( get_metaclass_by_name($role_name) ) + if ($i + 1 < $max && ref($_[$i + 1]) eq 'HASH') { + push @roles, [ $role => $_[++$i] ]; + } else { + push @roles, [ $role => undef ]; + } + is_a_metarole($role) || $consumer->meta->throw_error("You can only consume roles, $role_name is not a Mouse role"); } if ( scalar @roles == 1 ) { - my ( $role_name, $params ) = @{ $roles[0] }; - get_metaclass_by_name($role_name)->apply( $consumer, defined $params ? $params : () ); + my ( $role, $params ) = @{ $roles[0] }; + $role->apply( $consumer, defined $params ? $params : () ); } else { Mouse::Meta::Role->combine(@roles)->apply($consumer); @@ -326,7 +334,7 @@ sub quoted_english_list { sub not_supported{ my($feature) = @_; - $feature ||= ( caller(1) )[3]; # subroutine name + $feature ||= ( caller(1) )[3] . '()'; # subroutine name local $Carp::CarpLevel = $Carp::CarpLevel + 1; Carp::confess("Mouse does not currently support $feature"); @@ -380,7 +388,7 @@ Mouse::Util - Utilities for working with Mouse classes =head1 VERSION -This document describes Mouse version 0.70 +This document describes Mouse version 0.82 =head1 SYNOPSIS