X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FUtil%2FTypeConstraints.pm;h=732797fb87d2a2111e88b00310ee5fe0b9fce204;hb=7dbebb1bd235797a97c433d40c50a70628a07e3f;hp=bd71383296c93b907d71dc8682aa88b717763b0f;hpb=cceb0e252f64443a80ed5d90ebd2bcacbc338911;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Util/TypeConstraints.pm b/lib/Mouse/Util/TypeConstraints.pm index bd71383..732797f 100644 --- a/lib/Mouse/Util/TypeConstraints.pm +++ b/lib/Mouse/Util/TypeConstraints.pm @@ -6,6 +6,7 @@ use Carp (); use Scalar::Util qw/blessed looks_like_number openhandle/; my %TYPE; +my %TYPE_SOURCE; my %COERCE; my %COERCE_KEYS; @@ -71,12 +72,10 @@ my $optimized_constraints_base; GlobRef => sub { ref($_) eq 'GLOB' }, FileHandle => sub { - ref($_) eq 'GLOB' - && openhandle($_) + ref($_) eq 'GLOB' && openhandle($_) or - blessed($_) - && $_->isa("IO::Handle") - }, + blessed($_) && $_->isa("IO::Handle") + }, Object => sub { blessed($_) && blessed($_) ne 'Regexp' }, ); @@ -84,30 +83,37 @@ my $optimized_constraints_base; sub optimized_constraints { \%TYPE } my @TYPE_KEYS = keys %TYPE; sub list_all_builtin_type_constraints { @TYPE_KEYS } + + @TYPE_SOURCE{@TYPE_KEYS} = (__PACKAGE__) x @TYPE_KEYS; } sub _type { my $pkg = caller(0); my($name, %conf) = @_; if (my $type = $TYPE{$name}) { - Carp::croak "The type constraint '$name' has already been created, cannot be created again in $pkg"; + Carp::croak "The type constraint '$name' has already been created in $TYPE_SOURCE{$name} and cannot be created again in $pkg"; }; - my $stuff = $conf{where} || do { $TYPE{delete $conf{as} || 'Any' } }; - $TYPE{$name} = $stuff; + my $constraint = $conf{where} || do { $TYPE{delete $conf{as} || 'Any' } }; + + $TYPE_SOURCE{$name} = $pkg; + $TYPE{$name} = $constraint; } sub _subtype { my $pkg = caller(0); my($name, %conf) = @_; if (my $type = $TYPE{$name}) { - Carp::croak "The type constraint '$name' has already been created, cannot be created again in $pkg"; + Carp::croak "The type constraint '$name' has already been created in $TYPE_SOURCE{$name} and cannot be created again in $pkg"; }; - my $stuff = $conf{where} || do { $TYPE{delete $conf{as} || 'Any' } }; - my $as = $conf{as} || ''; + my $constraint = $conf{where} || do { $TYPE{delete $conf{as} || 'Any' } }; + my $as = $conf{as} || ''; + + $TYPE_SOURCE{$name} = $pkg; + if ($as = $TYPE{$as}) { - $TYPE{$name} = sub { $as->($_) && $stuff->($_) }; + $TYPE{$name} = sub { $as->($_) && $constraint->($_) }; } else { - $TYPE{$name} = $stuff; + $TYPE{$name} = $constraint; } }