X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FTypeConstraint.pm;h=ca8671be9532a84bd55cf288fc85b115d82d1817;hb=ca352580a7df280fb48f1265862d03f46313031a;hp=9b1acc789f08b4c665b5f321504e64a053bffa38;hpb=2125ee6b834fe1e8e917df6e1bf7f7059d9579fc;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Meta/TypeConstraint.pm b/lib/Mouse/Meta/TypeConstraint.pm index 9b1acc7..ca8671b 100644 --- a/lib/Mouse/Meta/TypeConstraint.pm +++ b/lib/Mouse/Meta/TypeConstraint.pm @@ -2,11 +2,10 @@ package Mouse::Meta::TypeConstraint; use Mouse::Util qw(:meta); # enables strict and warnings use overload - '""' => sub { shift->{name} }, # stringify to tc name + '""' => sub { $_[0]->name }, # stringify to tc name fallback => 1; -use Carp qw(confess); -use Scalar::Util qw(blessed reftype); +use Carp (); my $null_check = sub { 1 }; @@ -32,7 +31,7 @@ sub new { $check = $args{constraint}; if(defined($check) && ref($check) ne 'CODE'){ - confess("Constraint for $args{name} is not a CODE reference"); + Carp::confess("Constraint for $args{name} is not a CODE reference"); } $args{package_defined_in} ||= caller; @@ -147,18 +146,18 @@ sub _add_type_coercions{ my $action = $_[++$i]; if(exists $has{$from}){ - confess("A coercion action already exists for '$from'"); + Carp::confess("A coercion action already exists for '$from'"); } my $type = Mouse::Util::TypeConstraints::find_or_parse_type_constraint($from) - or confess("Could not find the type constraint ($from) to coerce from"); + or Carp::confess("Could not find the type constraint ($from) to coerce from"); push @{$coercions}, [ $type => $action ]; } # compile if(exists $self->{type_constraints}){ # union type - confess("Cannot add additional type coercions to Union types"); + Carp::confess("Cannot add additional type coercions to Union types"); } else{ $self->{_compiled_type_coercion} = sub { @@ -183,13 +182,11 @@ sub check { sub coerce { my $self = shift; - if(!$self->{_compiled_type_coercion}){ - confess("Cannot coerce without a type coercion ($self)"); - } return $_[0] if $self->_compiled_type_constraint->(@_); - return $self->{_compiled_type_coercion}->(@_); + my $coercion = $self->_compiled_type_coercion; + return $coercion ? $coercion->(@_) : $_[0]; } sub get_message { @@ -208,7 +205,7 @@ sub is_a_type_of{ my($self, $other) = @_; # ->is_a_type_of('__ANON__') is always false - return 0 if !blessed($other) && $other eq '__ANON__'; + return 0 if !ref($other) && $other eq '__ANON__'; (my $other_name = $other) =~ s/\s+//g; @@ -237,7 +234,7 @@ Mouse::Meta::TypeConstraint - The Mouse Type Constraint metaclass =head1 VERSION -This document describes Mouse version 0.40 +This document describes Mouse version 0.40_01 =head1 DESCRIPTION