X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FRole.pm;h=b2d4aae40dfbe5c10628e7939c8dfade95b66c35;hb=98a8fd12ede46b22edc10d229680d9d2e8deeade;hp=e1f3f7187ff679a6afab8a9e7db594452c003a9c;hpb=cb60d0b55962e6ff8cdc07e51e59f7dd5feafd43;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Meta/Role.pm b/lib/Mouse/Meta/Role.pm index e1f3f71..b2d4aae 100644 --- a/lib/Mouse/Meta/Role.pm +++ b/lib/Mouse/Meta/Role.pm @@ -149,13 +149,13 @@ sub _apply_modifiers{ } for my $modifier_type (qw/before around after/) { - my $modifiers = $role->{"${modifier_type}_method_modifiers"} + my $table = $role->{"${modifier_type}_method_modifiers"} or next; my $add_modifier = "add_${modifier_type}_method_modifier"; - foreach my $method_name (keys %{$modifiers}){ - foreach my $code(@{ $modifiers->{$method_name} }){ + while(my($method_name, $modifiers) = each %{$table}){ + foreach my $code(@{ $modifiers }){ next if $consumer->{"_applied_$modifier_type"}{$method_name, $code}++; # skip applied modifiers $consumer->$add_modifier($method_name => $code); } @@ -167,10 +167,10 @@ sub _apply_modifiers{ sub _append_roles{ my($role, $consumer, $args) = @_; - my $roles = ($args->{_to} eq 'role') ? $consumer->get_roles : $consumer->roles; + my $roles = $consumer->{roles}; foreach my $r($role, @{$role->get_roles}){ - if(!$consumer->does_role($r->name)){ + if(!$consumer->does_role($r)){ push @{$roles}, $r; } } @@ -288,6 +288,8 @@ sub does_role { (defined $role_name) || $self->throw_error("You must supply a role name to look for"); + $role_name = $role_name->name if ref $role_name; + # if we are it,.. then return true return 1 if $role_name eq $self->name; # otherwise.. check our children @@ -306,7 +308,7 @@ Mouse::Meta::Role - The Mouse Role metaclass =head1 VERSION -This document describes Mouse version 0.50_03 +This document describes Mouse version 0.50_05 =head1 SEE ALSO