X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FMethod%2FConstructor.pm;h=cbfbbb26cd4f47188ab6f0b51b3701dcbdde5cf3;hb=31aa6299ca20515174f1b145e5b3d4dbd9e09a08;hp=e641611dae3aa4d11f63909bc408142556fb49bb;hpb=825f7cdadcd71fb73aa7f6fa7c29b4f2d0c25366;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Meta/Method/Constructor.pm b/lib/Mouse/Meta/Method/Constructor.pm index e641611..cbfbbb2 100644 --- a/lib/Mouse/Meta/Method/Constructor.pm +++ b/lib/Mouse/Meta/Method/Constructor.pm @@ -1,7 +1,7 @@ package Mouse::Meta::Method::Constructor; use Mouse::Util qw(:meta); # enables strict and warnings -use constant _MOUSE_DEBUG => !!$ENV{MOUSE_DEBUG}; +use constant _MOUSE_DEBUG => $ENV{MOUSE_DEBUG} ? 1 : 0; sub _inline_slot{ my(undef, $self_var, $attr_name) = @_; @@ -15,9 +15,8 @@ sub _generate_constructor { my $buildall = $class->_generate_BUILDALL($metaclass); my $buildargs = $class->_generate_BUILDARGS($metaclass); - my $initializer = $metaclass->{_initialize_object} ||= do { + my $initializer = $metaclass->{_mouse_cache}{_initialize_object} ||= $class->_generate_initialize_object($metaclass); - }; my $source = sprintf(<<'EOT', __FILE__, $metaclass->name, $buildargs, $buildall); #line 1 "%s" package %s; @@ -88,10 +87,6 @@ sub _generate_initialize_object { $post_process .= "\$checks[$index]->($instance_slot)\n"; $post_process .= " or $attr_var->_throw_type_constraint_error($instance_slot, $constraint_var);\n"; } - if($is_weak_ref){ - $post_process = "Scalar::Util::weaken($instance_slot) " - . "if ref $instance_slot;\n"; - } # build cde for an attribute if (defined $init_arg) { @@ -152,6 +147,11 @@ sub _generate_initialize_object { $code .= "}\n" if defined $init_arg; + if($is_weak_ref){ + $code .= "Scalar::Util::weaken($instance_slot) " + . "if ref $instance_slot;\n"; + } + push @res, $code; } @@ -233,7 +233,7 @@ Mouse::Meta::Method::Constructor - A Mouse method generator for constructors =head1 VERSION -This document describes Mouse version 0.74 +This document describes Mouse version 0.95 =head1 SEE ALSO