X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FMethod%2FConstructor.pm;h=b899026d842f534871dc095941e673cc2c843423;hb=3fee6f680e64b907395238b4d7485e600fee4e46;hp=7568dcdbb773941bdafb61ed8e30814f78fa3b9b;hpb=b3b74cc602b1f2490396e407aa38970b5aa6921a;p=gitmo%2FMouse.git

diff --git a/lib/Mouse/Meta/Method/Constructor.pm b/lib/Mouse/Meta/Method/Constructor.pm
index 7568dcd..b899026 100644
--- a/lib/Mouse/Meta/Method/Constructor.pm
+++ b/lib/Mouse/Meta/Method/Constructor.pm
@@ -5,10 +5,11 @@ use warnings;
 sub generate_constructor_method_inline {
     my ($class, $meta) = @_;
 
-    my @attrs = $meta->compute_all_applicable_attributes; # this one is using by evaled code
+    my @attrs = $meta->compute_all_applicable_attributes;
     my $buildall = $class->_generate_BUILDALL($meta);
-    my $buildargs = $class->_generate_BUILDARGS();
+    my $buildargs = $class->_generate_BUILDARGS($meta);
     my $processattrs = $class->_generate_processattrs($meta, \@attrs);
+    my @compiled_constraints = map { $_ ? $_->{_compiled_type_constraint} : undef } map { $_->{type_constraint} } @attrs;
 
     my $code = <<"...";
     sub {
@@ -21,9 +22,8 @@ sub generate_constructor_method_inline {
     }
 ...
 
-    warn $code if $ENV{DEBUG};
-
     local $@;
+    # warn $code;
     my $res = eval $code;
     die $@ if $@;
     $res;
@@ -32,128 +32,126 @@ sub generate_constructor_method_inline {
 sub _generate_processattrs {
     my ($class, $meta, $attrs) = @_;
     my @res;
-    for my $index (0..scalar(@$attrs)-1) {
+
+    for my $index (0 .. @$attrs - 1) {
         my $attr = $attrs->[$index];
-        my $from = $attr->init_arg;
         my $key  = $attr->name;
+        my $code = '';
+
+        if (defined $attr->init_arg) {
+            my $from = $attr->init_arg;
 
-        my $set_value = do {
-            my @code;
+            $code .= "if (exists \$args->{'$from'}) {\n";
 
             if ($attr->should_coerce && $attr->type_constraint) {
-                push @code, "my \$value = Mouse::TypeRegistry->typecast_constraints('".$attr->associated_class->name."', \$attrs[$index]->{find_type_constraint}, \$attrs[$index]->{type_constraint}, \$args->{'$from'});";
+                $code .= "my \$value = Mouse::Util::TypeConstraints->typecast_constraints('".$attr->associated_class->name."', \$attrs[$index]->{type_constraint}, \$args->{'$from'});\n";
             }
             else {
-                push @code, "my \$value = \$args->{'$from'};";
+                $code .= "my \$value = \$args->{'$from'};\n";
             }
 
             if ($attr->has_type_constraint) {
-                push @code, "{local \$_ = \$value; unless (\$attrs[$index]->{find_type_constraint}->(\$_)) {";
-                push @code, "\$attrs[$index]->verify_type_constraint_error('$key', \$_, \$attrs[$index]->type_constraint)}}";
+                if ($attr->type_constraint->{_compiled_type_constraint}) {
+                    $code .= "unless (\$compiled_constraints[$index](\$value)) {";
+                } else {
+                    $code .= "unless (\$attrs[$index]->{type_constraint}->check(\$value)) {";
+                }
+                $code .= "
+                        \$attrs[$index]->verify_type_constraint_error(
+                            '$key', \$_, \$attrs[$index]->type_constraint
+                        )
+                    }
+                ";
             }
 
-            push @code, "\$instance->{'$key'} = \$value;";
+            $code .= "\$instance->{'$key'} = \$value;\n";
 
             if ($attr->is_weak_ref) {
-                push @code, "weaken( \$instance->{'$key'} ) if ref( \$value );";
+                $code .= "Scalar::Util::weaken( \$instance->{'$key'} ) if ref( \$value );\n";
             }
 
-            if ( $attr->has_trigger ) {
-                push @code, "\$attrs[$index]->{trigger}->( \$instance, \$value, \$attrs[$index] );";
+            if ($attr->has_trigger) {
+                $code .= "\$attrs[$index]->{trigger}->( \$instance, \$value );\n";
             }
 
-            join "\n", @code;
-        };
+            $code .= "\n} else {\n";
+        }
 
-        my $make_default_value = do {
-            my @code;
+        if ($attr->has_default || $attr->has_builder) {
+            unless ($attr->is_lazy) {
+                my $default = $attr->default;
+                my $builder = $attr->builder;
 
-            if ( $attr->has_default || $attr->has_builder ) {
-                unless ( $attr->is_lazy ) {
-                    my $default = $attr->default;
-                    my $builder = $attr->builder;
+                $code .= "my \$value = ";
 
-                    push @code, "my \$value = ";
+                if ($attr->should_coerce && $attr->type_constraint) {
+                    $code .= "Mouse::Util::TypeConstraints->typecast_constraints('".$attr->associated_class->name."', \$attrs[$index]->{type_constraint}, ";
+                }
 
-                    if ($attr->should_coerce && $attr->type_constraint) {
-                        push @code, "Mouse::TypeRegistry->typecast_constraints('".$attr->associated_class->name."', \$attrs[$index]->{find_type_constraint}, \$attrs[$index]->{type_constraint}, ";
+                    if ($attr->has_builder) {
+                        $code .= "\$instance->$builder";
                     }
-                        if ($attr->has_builder) {
-                            push @code, "\$instance->$builder";
-                        }
-                        elsif (ref($default) eq 'CODE') {
-                            push @code, "\$attrs[$index]->{default}->(\$instance)";
-                        }
-                        elsif (!defined($default)) {
-                            push @code, 'undef';
-                        }
-                        elsif ($default =~ /^\-?[0-9]+(?:\.[0-9]+)$/) {
-                            push @code, $default;
-                        }
-                        else {
-                            push @code, "'$default'";
-                        }
-
-                    if ($attr->should_coerce) {
-                        push @code, ");";
+                    elsif (ref($default) eq 'CODE') {
+                        $code .= "\$attrs[$index]->{default}->(\$instance)";
                     }
-                    else {
-                        push @code, ";";
+                    elsif (!defined($default)) {
+                        $code .= 'undef';
                     }
-
-                    if ($attr->has_type_constraint) {
-                        push @code, "{local \$_ = \$value; unless (\$attrs[$index]->{find_type_constraint}->(\$_)) {";
-                        push @code, "\$attrs[$index]->verify_type_constraint_error('$key', \$_, \$attrs[$index]->type_constraint)}}";
+                    elsif ($default =~ /^\-?[0-9]+(?:\.[0-9]+)$/) {
+                        $code .= $default;
+                    }
+                    else {
+                        $code .= "'$default'";
                     }
 
-                    push @code, "\$instance->{'$key'} = \$value;";
+                if ($attr->should_coerce) {
+                    $code .= ");\n";
+                }
+                else {
+                    $code .= ";\n";
+                }
 
-                    if ($attr->is_weak_ref) {
-                        push @code, "weaken( \$instance->{'$key'} ) if ref( \$value );";
-                    }
+                if ($attr->has_type_constraint) {
+                    $code .= "{
+                        unless (\$attrs[$index]->{type_constraint}->check(\$value)) {
+                            \$attrs[$index]->verify_type_constraint_error('$key', \$_, \$attrs[$index]->type_constraint)
+                        }
+                    }";
                 }
-                join "\n", @code;
-            }
-            else {
-                if ( $attr->is_required ) {
-                    qq{Carp::confess("Attribute ($key) is required");};
-                } else {
-                    ""
+
+                $code .= "\$instance->{'$key'} = \$value;\n";
+
+                if ($attr->is_weak_ref) {
+                    $code .= "Scalar::Util::weaken( \$instance->{'$key'} ) if ref( \$value );\n";
                 }
             }
-        };
-        my $code = <<"...";
-            {
-                if (exists(\$args->{'$from'})) {
-                    $set_value;
-...
-        if ($make_default_value) {
-            $code .= <<"...";
-                } else {
-                    $make_default_value;
-...
         }
-        $code .= <<"...";
-                }
-            }
-...
+        elsif ($attr->is_required) {
+            $code .= "Carp::confess('Attribute ($key) is required');";
+        }
+
+        $code .= "}\n" if defined $attr->init_arg;
+
         push @res, $code;
     }
+
     return join "\n", @res;
 }
 
 sub _generate_BUILDARGS {
-    <<'...';
+    my $self = shift;
+    my $meta = shift;
+
+    if ($meta->name->can('BUILDARGS') && $meta->name->can('BUILDARGS') != Mouse::Object->can('BUILDARGS')) {
+        return '$class->BUILDARGS(@_)';
+    }
+
+    return <<'...';
     do {
         if ( scalar @_ == 1 ) {
-            if ( defined $_[0] ) {
-                ( ref( $_[0] ) eq 'HASH' )
+            ( ref( $_[0] ) eq 'HASH' )
                 || Carp::confess "Single parameters to new() must be a HASH ref";
-                +{ %{ $_[0] } };
-            }
-            else {
-                +{};
-            }
+            +{ %{ $_[0] } };
         }
         else {
             +{@_};
@@ -170,6 +168,7 @@ sub _generate_BUILDALL {
     push @code, q{no strict 'refs';};
     push @code, q{no warnings 'once';};
     no strict 'refs';
+    no warnings 'once';
     for my $klass ($meta->linearized_isa) {
         if (*{ $klass . '::BUILD' }{CODE}) {
             push  @code, qq{${klass}::BUILD(\$instance, \$args);};