X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FMethod%2FConstructor.pm;h=75f589d2eebfeb981871887dd3bb91e86d9dcb49;hb=4e14530461aa16875d80a0574d8f98e4eb5d24a8;hp=b899026d842f534871dc095941e673cc2c843423;hpb=3fee6f680e64b907395238b4d7485e600fee4e46;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Meta/Method/Constructor.pm b/lib/Mouse/Meta/Method/Constructor.pm index b899026..75f589d 100644 --- a/lib/Mouse/Meta/Method/Constructor.pm +++ b/lib/Mouse/Meta/Method/Constructor.pm @@ -5,6 +5,7 @@ use warnings; sub generate_constructor_method_inline { my ($class, $meta) = @_; + my $associated_metaclass_name = $meta->name; my @attrs = $meta->compute_all_applicable_attributes; my $buildall = $class->_generate_BUILDALL($meta); my $buildargs = $class->_generate_BUILDARGS($meta); @@ -14,7 +15,9 @@ sub generate_constructor_method_inline { my $code = <<"..."; sub { my \$class = shift; - my \$args = $buildargs; + return \$class->Mouse::Object::new(\@_) + if \$class ne '$associated_metaclass_name'; + $buildargs; my \$instance = bless {}, \$class; $processattrs; $buildall; @@ -143,20 +146,19 @@ sub _generate_BUILDARGS { my $meta = shift; if ($meta->name->can('BUILDARGS') && $meta->name->can('BUILDARGS') != Mouse::Object->can('BUILDARGS')) { - return '$class->BUILDARGS(@_)'; + return 'my $args = $class->BUILDARGS(@_)'; } return <<'...'; - do { + my $args; if ( scalar @_ == 1 ) { ( ref( $_[0] ) eq 'HASH' ) || Carp::confess "Single parameters to new() must be a HASH ref"; - +{ %{ $_[0] } }; + $args = +{ %{ $_[0] } }; } else { - +{@_}; + $args = +{@_}; } - }; ... } @@ -171,7 +173,7 @@ sub _generate_BUILDALL { no warnings 'once'; for my $klass ($meta->linearized_isa) { if (*{ $klass . '::BUILD' }{CODE}) { - push @code, qq{${klass}::BUILD(\$instance, \$args);}; + unshift @code, qq{${klass}::BUILD(\$instance, \$args);}; } } return join "\n", @code;