X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FClass.pm;h=afc6f571601f27f130ed07867aba0f7cd4cc94b9;hb=380e1cd7159fdf0efd57348736ca901825e1e4e8;hp=bfcbaa0ae85e67c01fa00c713b8d325389fbb6d8;hpb=85bd3f44fbee036b39fedb1e2ca2b566c1a6d08f;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Meta/Class.pm b/lib/Mouse/Meta/Class.pm index bfcbaa0..afc6f57 100644 --- a/lib/Mouse/Meta/Class.pm +++ b/lib/Mouse/Meta/Class.pm @@ -1,11 +1,8 @@ package Mouse::Meta::Class; -use strict; -use warnings; +use Mouse::Util qw/:meta get_linear_isa not_supported/; # enables strict and warnings use Scalar::Util qw/blessed weaken/; -use Mouse::Util qw/:meta get_linear_isa not_supported/; - use Mouse::Meta::Method::Constructor; use Mouse::Meta::Method::Destructor; use Mouse::Meta::Module; @@ -14,6 +11,9 @@ our @ISA = qw(Mouse::Meta::Module); sub method_metaclass() { 'Mouse::Meta::Method' } sub attribute_metaclass() { 'Mouse::Meta::Attribute' } +sub constructor_class() { 'Mouse::Meta::Method::Constructor' } +sub destructor_class() { 'Mouse::Meta::Method::Destructor' } + sub _construct_meta { my($class, %args) = @_; @@ -79,6 +79,16 @@ sub get_all_method_names { $self->linearized_isa; } +sub find_attribute_by_name{ + my($self, $name) = @_; + my $attr; + foreach my $class($self->linearized_isa){ + my $meta = Mouse::Util::get_metaclass_by_name($class) or next; + $attr = $meta->get_attribute($name) and last; + } + return $attr; +} + sub add_attribute { my $self = shift; @@ -102,15 +112,7 @@ sub add_attribute { or $self->throw_error('You must provide a name for the attribute'); if ($name =~ s/^\+//) { # inherited attributes - my $inherited_attr; - - # find_attribute_by_name - foreach my $class($self->linearized_isa){ - my $meta = Mouse::Util::get_metaclass_by_name($class) or next; - $inherited_attr = $meta->get_attribute($name) and last; - } - - defined($inherited_attr) + my $inherited_attr = $self->find_attribute_by_name($name) or $self->throw_error("Could not find an attribute by the name of '$name' to inherit from in ".$self->name); $attr = $inherited_attr->clone_and_inherit_options(%args); @@ -257,13 +259,13 @@ sub make_immutable { $self->{is_immutable}++; if ($args{inline_constructor}) { - # generate and install - Mouse::Meta::Method::Constructor->_generate_constructor_method($self, \%args); + $self->add_method($args{constructor_name} => + $self->constructor_class->_generate_constructor($self, \%args)); } if ($args{inline_destructor}) { - # generate and install - Mouse::Meta::Method::Destructor->_generate_destructor_method($self, \%args); + $self->add_method(DESTROY => + $self->destructor_class->_generate_destructor($self, \%args)); } # Moose's make_immutable returns true allowing calling code to skip setting an explicit true value @@ -397,8 +399,8 @@ sub add_after_method_modifier { sub add_override_method_modifier { my ($self, $name, $code) = @_; - if($self->has_method($name)){ - $self->throw_error("Cannot add an override method if a local method is already present"); + if($self->has_method($name)){ + $self->throw_error("Cannot add an override method if a local method is already present"); } my $package = $self->name; @@ -416,6 +418,26 @@ sub add_override_method_modifier { return; } +sub add_augment_method_modifier { + my ($self, $name, $code) = @_; + if($self->has_method($name)){ + $self->throw_error("Cannot add an augment method if a local method is already present"); + } + + my $super = $self->find_method_by_name($name) + or $self->throw_error("You cannot augment '$name' because it has no super method"); + + my $super_package = $super->package_name; + my $super_body = $super->body; + + $self->add_method($name => sub{ + local $Mouse::INNER_BODY{$super_package} = $code; + local $Mouse::INNER_ARGS{$super_package} = [@_]; + $super_body->(@_); + }); + return; +} + sub does_role { my ($self, $role_name) = @_;