X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FClass.pm;h=8871128a3296050029356e56db1e3452e0072772;hb=b6369395ff3663e73319351d01fe8a31f2b3dbf2;hp=1aee61d2a9b22e0dd4c192cffd900e67e77a8c5e;hpb=0097fc4e251f22ca59655844791ddf5733431fc0;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Meta/Class.pm b/lib/Mouse/Meta/Class.pm index 1aee61d..8871128 100644 --- a/lib/Mouse/Meta/Class.pm +++ b/lib/Mouse/Meta/Class.pm @@ -6,11 +6,11 @@ use Scalar::Util qw/blessed weaken/; use Mouse::Meta::Module; our @ISA = qw(Mouse::Meta::Module); -sub method_metaclass() { 'Mouse::Meta::Method' } -sub attribute_metaclass() { 'Mouse::Meta::Attribute' } +sub method_metaclass; +sub attribute_metaclass; -sub constructor_class(); -sub destructor_class(); +sub constructor_class; +sub destructor_class; sub _construct_meta { my($class, %args) = @_; @@ -54,9 +54,18 @@ sub superclasses { foreach my $super(@_){ Mouse::Util::load_class($super); my $meta = Mouse::Util::get_metaclass_by_name($super); + + next if not defined $meta; + if(Mouse::Util::is_a_metarole($meta)){ $self->throw_error("You cannot inherit from a Mouse Role ($super)"); } + + next if $self->isa(ref $meta); # _superclass_meta_is_compatible + + # XXX: should we check 'is_pristine' ? + + $self->_reconcile_with_superclass_meta($meta); } @{ $self->{superclasses} } = @_; } @@ -64,6 +73,33 @@ sub superclasses { return @{ $self->{superclasses} }; } +my @MetaClassTypes = qw( + attribute_metaclass + method_metaclass + constructor_class + destructor_class +); + +sub _reconcile_with_superclass_meta { + my($self, $super_meta) = @_; + + my @incompatibles; + foreach my $metaclass_type(@MetaClassTypes){ + my $super_c = $super_meta->$metaclass_type(); + my $self_c = $self->$metaclass_type(); + + if(!$super_c->isa($self_c)){ + push @incompatibles, $metaclass_type => $super_c; + } + } + + if(@incompatibles){ + $super_meta->reinitialize($self->name, @incompatibles); + } + return; +} + + sub find_method_by_name{ my($self, $method_name) = @_; defined($method_name) @@ -140,7 +176,7 @@ sub add_attribute { $self->{attributes}{$attr->name} = $attr; $attr->install_accessors(); - if(_MOUSE_VERBOSE && !$attr->{associated_methods} && ($attr->{is} || '') ne 'bare'){ + if(Mouse::Util::_MOUSE_VERBOSE && !$attr->{associated_methods} && ($attr->{is} || '') ne 'bare'){ Carp::cluck(qq{Attribute (}.$attr->name.qq{) of class }.$self->name.qq{ has no associated methods (did you mean to provide an "is" argument?)}); } return $attr; @@ -148,21 +184,13 @@ sub add_attribute { sub compute_all_applicable_attributes { Carp::cluck('compute_all_applicable_attributes() has been deprecated') - if _MOUSE_VERBOSE; + if Mouse::Util::_MOUSE_VERBOSE; return shift->get_all_attributes(@_) } sub linearized_isa; -sub new_object { - my $self = shift; - my %args = (@_ == 1 ? %{$_[0]} : @_); - - my $object = bless {}, $self->name; - - $self->_initialize_object($object, \%args); - return $object; -} +sub new_object; sub clone_object { my $class = shift; @@ -182,7 +210,7 @@ sub clone_instance { my ($class, $instance, %params) = @_; Carp::cluck('clone_instance has been deprecated. Use clone_object instead') - if _MOUSE_VERBOSE; + if Mouse::Util::_MOUSE_VERBOSE; return $class->clone_object($instance, %params); } @@ -410,7 +438,7 @@ Mouse::Meta::Class - The Mouse class metaclass =head1 VERSION -This document describes Mouse version 0.40_05 +This document describes Mouse version 0.40_07 =head1 METHODS