X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FAttribute.pm;h=a37601d6f4c65a4fce2d045e1f4c454cb36165c1;hb=26f0aa174f72fdf5fd803278212b7cefa83c8734;hp=80a702f3c119379f63d8decbda353c5f750e765d;hpb=84f321d91fe4b9056272f389dbf818e42867ac17;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Meta/Attribute.pm b/lib/Mouse/Meta/Attribute.pm index 80a702f..a37601d 100644 --- a/lib/Mouse/Meta/Attribute.pm +++ b/lib/Mouse/Meta/Attribute.pm @@ -34,6 +34,7 @@ my %valid_options = map { $_ => undef } ( # internally used 'associated_class', 'associated_methods', + '__METACLASS__', # Moose defines, but Mouse doesn't #'definition_context', @@ -93,13 +94,13 @@ sub get_write_method { $_[0]->writer || $_[0]->accessor } sub get_read_method_ref{ my($self) = @_; - return $self->{_read_method_ref} + return $self->{_mouse_cache_read_method_ref} ||= $self->_get_accessor_method_ref('get_read_method', '_generate_reader'); } sub get_write_method_ref{ my($self) = @_; - return $self->{_write_method_ref} + return $self->{_mouse_cache_write_method_ref} ||= $self->_get_accessor_method_ref('get_write_method', '_generate_writer'); } @@ -137,22 +138,6 @@ sub interpolate_class{ return( $class, @traits ); } -sub _coerce_and_verify { - #my($self, $value, $instance) = @_; - my($self, $value) = @_; - - my $type_constraint = $self->{type_constraint}; - return $value if !defined $type_constraint; - - if ($self->should_coerce && $type_constraint->has_coercion) { - $value = $type_constraint->coerce($value); - } - - $self->verify_against_type_constraint($value); - - return $value; -} - sub verify_against_type_constraint { my ($self, $value) = @_; @@ -198,7 +183,7 @@ sub clone_and_inherit_options{ # remove temporary caches foreach my $attr(keys %{$args}){ - if($attr =~ /\A _/xms){ + if($attr =~ /\A _mouse_cache_/xms){ delete $args->{$attr}; } } @@ -239,7 +224,7 @@ sub get_value { sub has_value { my($self, $object) = @_; - my $accessor_ref = $self->{_predicate_ref} + my $accessor_ref = $self->{_mouse_cache_predicate_ref} ||= $self->_get_accessor_method_ref('predicate', '_generate_predicate'); return $accessor_ref->($object); @@ -247,7 +232,7 @@ sub has_value { sub clear_value { my($self, $object) = @_; - my $accessor_ref = $self->{_crealer_ref} + my $accessor_ref = $self->{_mouse_cache_crealer_ref} ||= $self->_get_accessor_method_ref('clearer', '_generate_clearer'); return $accessor_ref->($object); @@ -278,8 +263,9 @@ sub install_accessors{ # install delegation if(exists $attribute->{handles}){ my %handles = $attribute->_canonicalize_handles(); - while(my($handle, $method_to_call) = each %handles){ + next if Mouse::Object->can($handle); + if($metaclass->has_method($handle)) { $attribute->throw_error("You cannot overwrite a locally defined method ($handle) with a delegation"); } @@ -313,7 +299,7 @@ sub _canonicalize_handles { elsif ($handle_type eq 'Regexp') { my $meta = $self->_find_delegate_metaclass(); return map { $_ => $_ } - grep { !Mouse::Object->can($_) && $_ =~ $handles } + grep { /$handles/ } Mouse::Util::is_a_metarole($meta) ? $meta->get_method_list : $meta->get_all_method_names; @@ -356,7 +342,7 @@ Mouse::Meta::Attribute - The Mouse attribute metaclass =head1 VERSION -This document describes Mouse version 0.71 +This document describes Mouse version 0.77 =head1 DESCRIPTION