X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FAttribute.pm;h=9f680706e4d89110e07d9445fde4e7d851f8802c;hb=b3b74cc602b1f2490396e407aa38970b5aa6921a;hp=72570c86ab4e668c43dff4930ac0aed370b3890d;hpb=7de13475544559b7f6ea43167a6314a61e59f9e2;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Meta/Attribute.pm b/lib/Mouse/Meta/Attribute.pm index 72570c8..9f68070 100644 --- a/lib/Mouse/Meta/Attribute.pm +++ b/lib/Mouse/Meta/Attribute.pm @@ -2,9 +2,10 @@ package Mouse::Meta::Attribute; use strict; use warnings; +require overload; use Carp 'confess'; -use Mouse::Util qw/blessed weaken/; +require Mouse::Util; sub new { my $class = shift; @@ -36,6 +37,7 @@ sub type_constraint { $_[0]->{type_constraint} } sub trigger { $_[0]->{trigger} } sub builder { $_[0]->{builder} } sub should_auto_deref { $_[0]->{auto_deref} } +sub should_coerce { $_[0]->{should_coerce} } sub has_default { exists $_[0]->{default} } sub has_predicate { exists $_[0]->{predicate} } @@ -45,6 +47,8 @@ sub has_type_constraint { exists $_[0]->{type_constraint} } sub has_trigger { exists $_[0]->{trigger} } sub has_builder { exists $_[0]->{builder} } +sub find_type_constraint { $_[0]->{find_type_constraint} } + sub _create_args { $_[0]->{_create_args} = $_[1] if @_ > 1; $_[0]->{_create_args} @@ -60,12 +64,14 @@ sub inlined_name { sub generate_accessor { my $attribute = shift; - my $name = $attribute->name; - my $default = $attribute->default; - my $type = $attribute->type_constraint; - my $constraint = $attribute->find_type_constraint; - my $builder = $attribute->builder; - my $trigger = $attribute->trigger; + my $name = $attribute->name; + my $default = $attribute->default; + my $constraint = $attribute->find_type_constraint; + my $builder = $attribute->builder; + my $trigger = $attribute->trigger; + my $is_weak = $attribute->is_weak_ref; + my $should_deref = $attribute->should_auto_deref; + my $should_coerce = $attribute->should_coerce; my $self = '$_[0]'; my $key = $attribute->inlined_name; @@ -77,22 +83,28 @@ sub generate_accessor { my $value = '$_[1]'; if ($constraint) { - $accessor .= 'local $_ = '.$value.'; + $accessor .= 'my $val = '; + if ($should_coerce) { + $accessor .= 'Mouse::TypeRegistry->typecast_constraints("'.$attribute->associated_class->name.'", $attribute->{find_type_constraint}, $attribute->{type_constraint}, '.$value.');'; + } else { + $accessor .= $value.';'; + } + $accessor .= 'local $_ = $val;'; + $accessor .= ' unless ($constraint->()) { - my $display = defined($_) ? overload::StrVal($_) : "undef"; - Carp::confess("Attribute ($name) does not pass the type constraint because: Validation failed for \'$type\' failed with value $display"); - }' . "\n" + $attribute->verify_type_constraint_error($name, $_, $attribute->type_constraint); + }' . "\n"; + $value = '$val'; } - $accessor .= 'return ' - if !$attribute->is_weak_ref - && !$trigger - && !$attribute->should_auto_deref; + # if there's nothing left to do for the attribute we can return during + # this setter + $accessor .= 'return ' if !$is_weak && !$trigger && !$should_deref; $accessor .= $self.'->{'.$key.'} = '.$value.';' . "\n"; - if ($attribute->is_weak_ref) { - $accessor .= 'weaken('.$self.'->{'.$key.'}) if ref('.$self.'->{'.$key.'});' . "\n"; + if ($is_weak) { + $accessor .= 'Mouse::Util::weaken('.$self.'->{'.$key.'}) if ref('.$self.'->{'.$key.'});' . "\n"; } if ($trigger) { @@ -116,8 +128,9 @@ sub generate_accessor { $accessor .= ' if !exists '.$self.'->{'.$key.'};' . "\n"; } - if ($attribute->should_auto_deref) { - if ($attribute->type_constraint eq 'ArrayRef') { + if ($should_deref) { + my $type_constraint = $attribute->type_constraint; + if (!ref($type_constraint) && $type_constraint eq 'ArrayRef') { $accessor .= 'if (wantarray) { return @{ '.$self.'->{'.$key.'} || [] }; }'; @@ -190,8 +203,36 @@ sub create { %args = $self->canonicalize_args($name, %args); $self->validate_args($name, \%args); - $args{type_constraint} = delete $args{isa} - if exists $args{isa}; + $args{should_coerce} = delete $args{coerce} + if exists $args{coerce}; + + if (exists $args{isa}) { + my $type_constraint = delete $args{isa}; + $type_constraint =~ s/\s//g; + my @type_constraints = split /\|/, $type_constraint; + + my $code; + my $optimized_constraints = Mouse::TypeRegistry->optimized_constraints; + if (@type_constraints == 1) { + $code = $optimized_constraints->{$type_constraints[0]} || + sub { Mouse::Util::blessed($_) && Mouse::Util::blessed($_) eq $type_constraints[0] }; + $args{type_constraint} = $type_constraints[0]; + } else { + my @code_list = map { + my $type = $_; + $optimized_constraints->{$type} || + sub { Mouse::Util::blessed($_) && Mouse::Util::blessed($_) eq $type } + } @type_constraints; + $code = sub { + for my $code (@code_list) { + return 1 if $code->(); + } + return 0; + }; + $args{type_constraint} = \@type_constraints; + } + $args{find_type_constraint} = $code; + } my $attribute = $self->new(%args); @@ -284,33 +325,29 @@ sub validate_args { return 1; } -sub find_type_constraint { - my $self = shift; - my $type = $self->type_constraint; - - return unless $type; - - my $checker = Mouse::TypeRegistry->optimized_constraints->{$type}; - return $checker if $checker; - - return sub { blessed($_) && blessed($_) eq $type }; -} - sub verify_type_constraint { - my $self = shift; - local $_ = shift; + return 1 unless $_[0]->{type_constraint}; - my $type = $self->type_constraint - or return 1; - my $constraint = $self->find_type_constraint; + local $_ = $_[1]; + return 1 if $_[0]->{find_type_constraint}->($_); - return 1 if $constraint->($_); + my $self = shift; + $self->verify_type_constraint_error($self->name, $_, $self->type_constraint); +} - my $name = $self->name; +sub verify_type_constraint_error { + my($self, $name, $value, $type) = @_; + $type = ref($type) eq 'ARRAY' ? join '|', @{ $type } : $type; my $display = defined($_) ? overload::StrVal($_) : 'undef'; Carp::confess("Attribute ($name) does not pass the type constraint because: Validation failed for \'$type\' failed with value $display"); } +sub coerce_constraint { ## my($self, $value) = @_; + my $type = $_[0]->{type_constraint} + or return $_[1]; + return Mouse::TypeRegistry->typecast_constraints($_[0]->associated_class->name, $_[0]->find_type_constraint, $type, $_[1]); +} + sub _canonicalize_handles { my $self = shift; my $handles = shift;