X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMouse%2FMeta%2FAttribute.pm;h=70f50aa8062337ccb8a53a5c44ef06bd4a81689c;hb=a797dd8ddeea120b4f8f638813f5104777361eb4;hp=cdea7cbca502c568693ed31e3b7dcf49ea732a33;hpb=32ec255c44d36d63cce20f5e21386d5cd11396b9;p=gitmo%2FMouse.git diff --git a/lib/Mouse/Meta/Attribute.pm b/lib/Mouse/Meta/Attribute.pm index cdea7cb..70f50aa 100644 --- a/lib/Mouse/Meta/Attribute.pm +++ b/lib/Mouse/Meta/Attribute.pm @@ -34,6 +34,7 @@ my %valid_options = map { $_ => undef } ( # internally used 'associated_class', 'associated_methods', + '__METACLASS__', # Moose defines, but Mouse doesn't #'definition_context', @@ -254,16 +255,24 @@ sub install_accessors{ if(exists $attribute->{$type}){ my $generator = '_generate_' . $type; my $code = $accessor_class->$generator($attribute, $metaclass); - $metaclass->add_method($attribute->{$type} => $code); - $attribute->associate_method($attribute->{$type}); + my $name = $attribute->{$type}; +# TODO: do something for compatibility +# if( $metaclass->name->can($name) ) { +# my $t = $metaclass->has_method($name) ? 'method' : 'function'; +# Carp::cluck("You are overwriting a locally defined $t" +# . " ($name) with an accessor"); +# } + $metaclass->add_method($name => $code); + $attribute->associate_method($name); } } # install delegation if(exists $attribute->{handles}){ my %handles = $attribute->_canonicalize_handles(); - while(my($handle, $method_to_call) = each %handles){ + next if Mouse::Object->can($handle); + if($metaclass->has_method($handle)) { $attribute->throw_error("You cannot overwrite a locally defined method ($handle) with a delegation"); } @@ -297,7 +306,7 @@ sub _canonicalize_handles { elsif ($handle_type eq 'Regexp') { my $meta = $self->_find_delegate_metaclass(); return map { $_ => $_ } - grep { !Mouse::Object->can($_) && $_ =~ $handles } + grep { /$handles/ } Mouse::Util::is_a_metarole($meta) ? $meta->get_method_list : $meta->get_all_method_names; @@ -340,7 +349,7 @@ Mouse::Meta::Attribute - The Mouse attribute metaclass =head1 VERSION -This document describes Mouse version 0.75 +This document describes Mouse version 0.90 =head1 DESCRIPTION