X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMooseX%2FGetopt%2FBasic.pm;h=5000746e482c6228d4a68698ea2648c6af3b8674;hb=8df55e62a4d1278fab4366b2516ecc673820a1f6;hp=a09ce8d55299c933fcf9d73ed72e5ecf029ba005;hpb=30ed85f7fc94f619d46a7430aff840b334c0ebce;p=gitmo%2FMooseX-Getopt.git diff --git a/lib/MooseX/Getopt/Basic.pm b/lib/MooseX/Getopt/Basic.pm index a09ce8d..5000746 100644 --- a/lib/MooseX/Getopt/Basic.pm +++ b/lib/MooseX/Getopt/Basic.pm @@ -44,13 +44,18 @@ sub new_with_options { $configfile = $cfmeta->default if $cfmeta->has_default; } - if(defined $configfile) { - $config_from_file = $class->get_config_from_file($configfile); + if (defined $configfile) { + $config_from_file = eval { + $class->get_config_from_file($configfile); + }; + if ($@) { + die $@ unless $@ =~ /Specified configfile '\Q$configfile\E' does not exist/; + } } } my $constructor_params = ( @params == 1 ? $params[0] : {@params} ); - + Carp::croak("Single parameters to new_with_options() must be a HASH ref") unless ref($constructor_params) eq 'HASH'; @@ -66,7 +71,7 @@ sub new_with_options { # did the user request usage information? if ( $processed{usage} && ($params->{'?'} or $params->{help} or $params->{usage}) ) { - $processed{usage}->die(); + $class->_exit_with_usage($processed{usage}); } $class->new( @@ -77,6 +82,11 @@ sub new_with_options { ); } +sub _exit_with_usage { + my ($self, $usage) = @_; + $usage->die(); +} + sub _parse_argv { my ( $class, %params ) = @_; @@ -135,38 +145,6 @@ sub _traditional_spec { return ( \@options, \%name_to_init_arg ); } -sub _gld_spec { - my ( $class, %params ) = @_; - - my ( @options, %name_to_init_arg ); - - my $constructor_params = $params{params}; - - foreach my $opt ( @{ $params{options} } ) { - push @options, [ - $opt->{opt_string}, - $opt->{doc} || ' ', # FIXME new GLD shouldn't need this hack - { - ( ( $opt->{required} && !exists($constructor_params->{$opt->{init_arg}}) ) ? (required => $opt->{required}) : () ), - # NOTE: - # remove this 'feature' because it didn't work - # all the time, and so is better to not bother - # since Moose will handle the defaults just - # fine anyway. - # - SL - #( exists $opt->{default} ? (default => $opt->{default}) : () ), - }, - ]; - - my $identifier = $opt->{name}; - $identifier =~ s/\W/_/g; # Getopt::Long does this to all option names - - $name_to_init_arg{$identifier} = $opt->{init_arg}; - } - - return ( \@options, \%name_to_init_arg ); -} - sub _compute_getopt_attrs { my $class = shift; grep { @@ -252,7 +230,7 @@ L without GLD. package My::App; use Moose; - with 'MooseX::Getopt'; + with 'MooseX::Getopt::Basic'; has 'out' => (is => 'rw', isa => 'Str', required => 1); has 'in' => (is => 'rw', isa => 'Str', required => 1); @@ -268,198 +246,20 @@ L without GLD. # ... rest of the script here ## on the command line - % perl my_app_script.pl -in file.input -out file.dump + % perl my_app_script.pl --in file.input --out file.dump =head1 DESCRIPTION -This is a role which provides an alternate constructor for creating -objects using parameters passed in from the command line. - -This module attempts to DWIM as much as possible with the command line -params by introspecting your class's attributes. It will use the name -of your attribute as the command line option, and if there is a type -constraint defined, it will configure Getopt::Long to handle the option -accordingly. - -You can use the trait L or the -attribute metaclass L to get non-default -commandline option names and aliases. - -You can use the trait L -or the attribute metaclass L -to have C ignore your attribute in the commandline options. - -By default, attributes which start with an underscore are not given -commandline argument support, unless the attribute's metaclass is set -to L. If you don't want you accessors -to have the leading underscore in thier name, you can do this: - - # for read/write attributes - has '_foo' => (accessor => 'foo', ...); - - # or for read-only attributes - has '_bar' => (reader => 'bar', ...); - -This will mean that Getopt will not handle a --foo param, but your -code can still call the C method. - -If your class also uses a configfile-loading role based on -L, such as L, -L's C will load the configfile -specified by the C<--configfile> option (or the default you've -given for the configfile attribute) for you. - -Options specified in multiple places follow the following -precendence order: commandline overrides configfile, which -overrides explicit new_with_options parameters. - -=head2 Supported Type Constraints - -=over 4 - -=item I - -A I type constraint is set up as a boolean option with -Getopt::Long. So that this attribute description: - - has 'verbose' => (is => 'rw', isa => 'Bool'); - -would translate into C as a Getopt::Long option descriptor, -which would enable the following command line options: - - % my_script.pl --verbose - % my_script.pl --noverbose - -=item I, I, I - -These type constraints are set up as properly typed options with -Getopt::Long, using the C<=i>, C<=f> and C<=s> modifiers as appropriate. - -=item I - -An I type constraint is set up as a multiple value option -in Getopt::Long. So that this attribute description: - - has 'include' => ( - is => 'rw', - isa => 'ArrayRef', - default => sub { [] } - ); - -would translate into C as a Getopt::Long option descriptor, -which would enable the following command line options: - - % my_script.pl --include /usr/lib --include /usr/local/lib - -=item I - -A I type constraint is set up as a hash value option -in Getopt::Long. So that this attribute description: - - has 'define' => ( - is => 'rw', - isa => 'HashRef', - default => sub { {} } - ); - -would translate into C as a Getopt::Long option descriptor, -which would enable the following command line options: - - % my_script.pl --define os=linux --define vendor=debian - -=back - -=head2 Custom Type Constraints - -It is possible to create custom type constraint to option spec -mappings if you need them. The process is fairly simple (but a -little verbose maybe). First you create a custom subtype, like -so: - - subtype 'ArrayOfInts' - => as 'ArrayRef' - => where { scalar (grep { looks_like_number($_) } @$_) }; - -Then you register the mapping, like so: - - MooseX::Getopt::OptionTypeMap->add_option_type_to_map( - 'ArrayOfInts' => '=i@' - ); - -Now any attribute declarations using this type constraint will -get the custom option spec. So that, this: - - has 'nums' => ( - is => 'ro', - isa => 'ArrayOfInts', - default => sub { [0] } - ); - -Will translate to the following on the command line: - - % my_script.pl --nums 5 --nums 88 --nums 199 - -This example is fairly trivial, but more complex validations are -easily possible with a little creativity. The trick is balancing -the type constraint validations with the Getopt::Long validations. - -Better examples are certainly welcome :) - -=head2 Inferred Type Constraints - -If you define a custom subtype which is a subtype of one of the -standard L above, and do not explicitly -provide custom support as in L above, -MooseX::Getopt will treat it like the parent type for Getopt -purposes. - -For example, if you had the same custom C subtype -from the examples above, but did not add a new custom option -type for it to the C, it would be treated just -like a normal C type for Getopt purposes (that is, -C<=s@>). +This is like L and can be used instead except that it +doesn't make use of L (or "GLD" for short). =head1 METHODS =over 4 -=item B - -This method will take a set of default C<%params> and then collect -params from the command line (possibly overriding those in C<%params>) -and then return a newly constructed object. - -The special parameter C, if specified should point to an array -reference with an array to use instead of C<@ARGV>. +=item B -The paramater C, if specified and a true value will disable -the use of L . - -If L fails (due to invalid arguments), -C will throw an exception. - -If L is installed and any of the following -command line params are passed, the program will exit with usage -information. You can add descriptions for each option by including a -B option for each attribute to document. - - --? - --help - --usage - -If you have L a the C param is also passed to -C. - -=item B - -This accessor contains a reference to a copy of the C<@ARGV> array -as it originally existed at the time of C. - -=item B - -This accessor contains an arrayref of leftover C<@ARGV> elements that -L did not parse. Note that the real C<@ARGV> is left -un-mangled. +See L . =item B @@ -487,6 +287,8 @@ Ryan D Johnson, Eryan@innerfence.comE Drew Taylor, Edrew@drewtaylor.comE +Shlomi Fish Eshlomif@cpan.orgE + =head1 COPYRIGHT AND LICENSE Copyright 2007-2008 by Infinity Interactive, Inc.