X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMooseX%2FClassAttribute.pm;h=7306caf64ed8fb05632ea84cd4fe1c5d058cb936;hb=e1bb560144e7ec7173ab5196f661a3b629323300;hp=b7c6398a7d27fb3c171d80d4d17f84bcaa70a52e;hpb=8d65540448deca131e4c77686c6a1135116e522e;p=gitmo%2FMooseX-ClassAttribute.git diff --git a/lib/MooseX/ClassAttribute.pm b/lib/MooseX/ClassAttribute.pm index b7c6398..7306caf 100644 --- a/lib/MooseX/ClassAttribute.pm +++ b/lib/MooseX/ClassAttribute.pm @@ -3,7 +3,7 @@ package MooseX::ClassAttribute; use strict; use warnings; -our $VERSION = '0.03'; +our $VERSION = '0.04'; our $AUTHORITY = 'cpan:DROLSKY'; our @EXPORT = 'class_has'; ## no critic ProhibitAutomaticExportation @@ -32,10 +32,10 @@ sub process_class_attribute ## no critic RequireArgUnpacking my @parents = $caller_meta->superclasses(); my $container_pkg = _make_container_class( $caller, @parents ); + my $container_meta = $container_pkg->meta(); - $container_pkg->meta()->_process_attribute(@_); + $container_meta->add_attribute(@_); - my $container_meta = $container_pkg->meta(); for my $meth ( grep { $_ ne 'instance' } $container_meta->get_method_list() ) { next if $caller_meta->has_method($meth); @@ -69,10 +69,11 @@ sub process_class_attribute ## no critic RequireArgUnpacking unless grep { $_->isa('Moose::Object') } @parents; my $container_pkg = 'MooseX::ClassAttribute::Container::' . $caller; + my $instance_holder = $container_pkg . '::Self'; my $instance_meth = sub { no strict 'refs'; ## no critic ProhibitNoStrict - return ${ $container_pkg . '::Self' } ||= shift->new(@_); + return $$instance_holder ||= shift->new(@_); }; my $class = @@ -141,7 +142,7 @@ MooseX::ClassAttribute - Declare class attributes Moose-style ); __PACKAGE__->meta()->make_immutable(); - MooseX::ClassAttribute::containing_class()->meta()->make_immutable(); + MooseX::ClassAttribute::container_class()->meta()->make_immutable(); no Moose; no MooseX::ClassAttribute; @@ -171,7 +172,7 @@ the constructor will not set it. This class exports one function when you use it, C. This works exactly like Moose's C, but it declares class attributes. -Own little nit is that if you include C in your class, you +One little nit is that if you include C in your class, you won't remove the C function. To do that you must include C as well. @@ -193,10 +194,10 @@ for which you're creating class attributes. You don't need to worry about this too much, except when it comes to making a class immutable. Since the class attributes are not really stored in your class, you -need to make the containing class immutable as well as your own ... +need to make the container class immutable as well as your own ... __PACKAGE__->meta()->make_immutable(); - MooseX::ClassAttribute::containing_class()->meta()->make_immutable(); + MooseX::ClassAttribute::container_class()->meta()->make_immutable(); I