X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMooseX%2FClassAttribute.pm;h=42eefa40cfc7dad654de5e2c412e5a2e99cc2e2c;hb=ac5d97b7c897ed33fc74a15d4cf4038aa0c40025;hp=8a0c4a2c75cd42cdcd3a75f2c5fc68cb838bdf28;hpb=b4d972cdaa4e3cd41ce3b0b81331bba3818de5ec;p=gitmo%2FMooseX-ClassAttribute.git diff --git a/lib/MooseX/ClassAttribute.pm b/lib/MooseX/ClassAttribute.pm index 8a0c4a2..42eefa4 100644 --- a/lib/MooseX/ClassAttribute.pm +++ b/lib/MooseX/ClassAttribute.pm @@ -3,13 +3,14 @@ package MooseX::ClassAttribute; use strict; use warnings; -our $VERSION = '0.02'; +our $VERSION = '0.04'; our $AUTHORITY = 'cpan:DROLSKY'; our @EXPORT = 'class_has'; ## no critic ProhibitAutomaticExportation use base 'Exporter'; use B qw( svref_2object ); +use Moose::Meta::Class; use Sub::Name; @@ -17,15 +18,24 @@ sub class_has ## no critic RequireArgUnpacking { my $caller = caller(); + process_class_attribute( $caller, @_ ); + + return; +} + +sub process_class_attribute ## no critic RequireArgUnpacking +{ + my $caller = shift; + my $caller_meta = $caller->meta(); my @parents = $caller_meta->superclasses(); my $container_pkg = _make_container_class( $caller, @parents ); + my $container_meta = $container_pkg->meta(); - $container_pkg->meta()->_process_attribute(@_); + $container_meta->add_attribute(@_); - my $container_meta = $container_pkg->meta(); for my $meth ( grep { $_ ne 'instance' } $container_meta->get_method_list() ) { next if $caller_meta->has_method($meth); @@ -84,9 +94,9 @@ sub class_has ## no critic RequireArgUnpacking } # This is basically copied from Moose.pm -sub unimport ## no critic RequireFinalReturn +sub unimport ## no critic RequireFinalReturn, RequireArgUnpacking { - my $caller = caller(); + my $caller = Moose::_get_caller(@_); no strict 'refs'; ## no critic ProhibitNoStrict foreach my $name (@EXPORT) @@ -131,7 +141,7 @@ MooseX::ClassAttribute - Declare class attributes Moose-style ); __PACKAGE__->meta()->make_immutable(); - MooseX::ClassAttribute::containing_class()->meta()->make_immutable(); + MooseX::ClassAttribute::container_class()->meta()->make_immutable(); no Moose; no MooseX::ClassAttribute; @@ -161,10 +171,20 @@ the constructor will not set it. This class exports one function when you use it, C. This works exactly like Moose's C, but it declares class attributes. -Own little nit is that if you include C in your class, you +One little nit is that if you include C in your class, you won't remove the C function. To do that you must include C as well. +If you want to use this module to create class attributes in I +classes, you can call the C function like +this: + + MooseX::ClassAttribute::process_class_attribute( $package, ... ); + +The first argument is the package which will have the class attribute, +and the remaining arguments are the same as those passed to +C. + =head2 Implementation and Immutability Underneath the hood, this class creates one new class for each class @@ -173,10 +193,10 @@ for which you're creating class attributes. You don't need to worry about this too much, except when it comes to making a class immutable. Since the class attributes are not really stored in your class, you -need to make the containing class immutable as well as your own ... +need to make the container class immutable as well as your own ... __PACKAGE__->meta()->make_immutable(); - MooseX::ClassAttribute::containing_class()->meta()->make_immutable(); + MooseX::ClassAttribute::container_class()->meta()->make_immutable(); I