X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FUtil%2FTypeConstraints%2FOptimizedConstraints.pm;h=e408d0e12e606543c946bf14d4881dc98dfe4076;hb=refs%2Ftags%2F0.96;hp=d3fcac55d7695a2da57a2fdbaa235ec494e2716d;hpb=267f8179e340201137fb8c257855fc56d2bd39e6;p=gitmo%2FMoose.git diff --git a/lib/Moose/Util/TypeConstraints/OptimizedConstraints.pm b/lib/Moose/Util/TypeConstraints/OptimizedConstraints.pm index d3fcac5..e408d0e 100644 --- a/lib/Moose/Util/TypeConstraints/OptimizedConstraints.pm +++ b/lib/Moose/Util/TypeConstraints/OptimizedConstraints.pm @@ -3,22 +3,29 @@ package Moose::Util::TypeConstraints::OptimizedConstraints; use strict; use warnings; +use Class::MOP; use Scalar::Util 'blessed', 'looks_like_number'; -our $VERSION = '0.52'; +our $VERSION = '0.96'; +$VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; sub Value { defined($_[0]) && !ref($_[0]) } sub Ref { ref($_[0]) } -sub Str { defined($_[0]) && !ref($_[0]) } +# We need to use a temporary here to flatten LVALUEs, for instance as in +# Str(substr($_,0,255)). +sub Str { + my $value = $_[0]; + defined($value) && ref(\$value) eq 'SCALAR' +} sub Num { !ref($_[0]) && looks_like_number($_[0]) } sub Int { defined($_[0]) && !ref($_[0]) && $_[0] =~ /^-?[0-9]+$/ } -sub ScalarRef { ref($_[0]) eq 'SCALAR' } +sub ScalarRef { ref($_[0]) eq 'SCALAR' || ref($_[0]) eq 'REF' } sub ArrayRef { ref($_[0]) eq 'ARRAY' } sub HashRef { ref($_[0]) eq 'HASH' } sub CodeRef { ref($_[0]) eq 'CODE' } @@ -29,34 +36,15 @@ sub FileHandle { ref($_[0]) eq 'GLOB' && Scalar::Util::openhandle($_[0]) or bles sub Object { blessed($_[0]) && blessed($_[0]) ne 'Regexp' } -sub Role { blessed($_[0]) && $_[0]->can('does') } +sub Role { Carp::cluck('The Role type is deprecated.'); blessed($_[0]) && $_[0]->can('does') } sub ClassName { - return 0 if ref($_[0]) || !defined($_[0]) || !length($_[0]); - - # walk the symbol table tree to avoid autovififying - # \*{${main::}{"Foo::"}} == \*main::Foo:: - - my $pack = \*::; - foreach my $part (split('::', $_[0])) { - return 0 unless exists ${$$pack}{"${part}::"}; - $pack = \*{${$$pack}{"${part}::"}}; - } - - # check for $VERSION or @ISA - return 1 if exists ${$$pack}{VERSION} - && defined *{${$$pack}{VERSION}}{SCALAR}; - return 1 if exists ${$$pack}{ISA} - && defined *{${$$pack}{ISA}}{ARRAY}; - - # check for any method - foreach ( keys %{$$pack} ) { - next if substr($_, -2, 2) eq '::'; - return 1 if defined *{${$$pack}{$_}}{CODE}; - } - - # fail - return 0; + return Class::MOP::is_class_loaded( $_[0] ); +} + +sub RoleName { + ClassName($_[0]) + && (Class::MOP::class_of($_[0]) || return)->isa('Moose::Meta::Role') } # NOTE: @@ -77,50 +65,50 @@ bodies for various moose types =head1 DESCRIPTION -This file contains the hand optimized versions of Moose type constraints, +This file contains the hand optimized versions of Moose type constraints, no user serviceable parts inside. =head1 FUNCTIONS =over 4 -=item Value +=item C + +=item C -=item Ref +=item C -=item Str +=item C -=item Num +=item C -=item Int +=item C -=item ScalarRef +=item C -=item ArrayRef +=item C -=item HashRef +=item C -=item CodeRef +=item C -=item RegexpRef +=item C -=item GlobRef +=item C -=item FileHandle +=item C -=item Object +=item C -=item Role +=item C -=item ClassName +=item C =back =head1 BUGS -All complex software has bugs lurking in it, and this module is no -exception. If you find a bug please either email me, or add the bug -to cpan-RT. +See L for details on reporting bugs. =head1 AUTHOR @@ -128,7 +116,7 @@ Yuval Kogman Enothingmuch@cpan.orgE =head1 COPYRIGHT AND LICENSE -Copyright 2007-2008 by Infinity Interactive, Inc. +Copyright 2007-2009 by Infinity Interactive, Inc. L