X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FUtil%2FTypeConstraints%2FOptimizedConstraints.pm;h=d6fe17e6a7bea8f4a439f7ec6eda48684baf17af;hb=6232ef492d4ed956c63d19bba3e14e2eaf13afa9;hp=67391beeb587e8fb50d3cf9d2cf9ccbc7fb76882;hpb=e631c7d15f0653f5784108edd5e3b7e178bfcd96;p=gitmo%2FMoose.git diff --git a/lib/Moose/Util/TypeConstraints/OptimizedConstraints.pm b/lib/Moose/Util/TypeConstraints/OptimizedConstraints.pm index 67391be..d6fe17e 100644 --- a/lib/Moose/Util/TypeConstraints/OptimizedConstraints.pm +++ b/lib/Moose/Util/TypeConstraints/OptimizedConstraints.pm @@ -6,7 +6,7 @@ use warnings; use Class::MOP; use Scalar::Util 'blessed', 'looks_like_number'; -our $VERSION = '0.70'; +our $VERSION = '0.92'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; @@ -14,7 +14,7 @@ sub Value { defined($_[0]) && !ref($_[0]) } sub Ref { ref($_[0]) } -sub Str { defined($_[0]) && !ref($_[0]) } +sub Str { defined($_[0]) && ref(\$_[0]) eq 'SCALAR' } sub Num { !ref($_[0]) && looks_like_number($_[0]) } @@ -31,15 +31,15 @@ sub FileHandle { ref($_[0]) eq 'GLOB' && Scalar::Util::openhandle($_[0]) or bles sub Object { blessed($_[0]) && blessed($_[0]) ne 'Regexp' } -sub Role { blessed($_[0]) && $_[0]->can('does') } +sub Role { Carp::cluck('The Role type is deprecated.'); blessed($_[0]) && $_[0]->can('does') } sub ClassName { return Class::MOP::is_class_loaded( $_[0] ); } sub RoleName { - ClassName($_[0]) - && (($_[0]->can('meta') || return)->($_[0]) || return)->isa('Moose::Meta::Role') + ClassName($_[0]) + && (Class::MOP::class_of($_[0]) || return)->isa('Moose::Meta::Role') } # NOTE: @@ -60,7 +60,7 @@ bodies for various moose types =head1 DESCRIPTION -This file contains the hand optimized versions of Moose type constraints, +This file contains the hand optimized versions of Moose type constraints, no user serviceable parts inside. =head1 FUNCTIONS @@ -103,7 +103,7 @@ no user serviceable parts inside. =head1 BUGS -All complex software has bugs lurking in it, and this module is no +All complex software has bugs lurking in it, and this module is no exception. If you find a bug please either email me, or add the bug to cpan-RT.