X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FRole.pm;h=78a3c6c00c5a05211da6c5b7d32d4c164cf191fa;hb=aa8d5e2de08b41212f4a982585da4a39a4a794c4;hp=d684cc80e89fbd3fdf853dd9f1082db0c7aa3d64;hpb=a7e9b05b9505cd4d2d642ead617de0eb7074e23f;p=gitmo%2FMoose.git diff --git a/lib/Moose/Role.pm b/lib/Moose/Role.pm index d684cc8..78a3c6c 100644 --- a/lib/Moose/Role.pm +++ b/lib/Moose/Role.pm @@ -5,18 +5,19 @@ use strict; use warnings; use Scalar::Util 'blessed'; -use Carp 'confess', 'croak'; +use Carp 'croak'; use Data::OptList; use Sub::Exporter; -our $VERSION = '0.55_04'; +our $VERSION = '0.68'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; use Moose (); use Moose::Util (); +use Moose::Exporter; use Moose::Meta::Role; use Moose::Util::TypeConstraints; @@ -54,7 +55,7 @@ sub before { my $code = pop @_; for (@_) { - croak "Moose::Role do not currently support " + croak "Roles do not currently support " . ref($_) . " references for before method modifiers" if ref $_; @@ -67,7 +68,7 @@ sub after { my $code = pop @_; for (@_) { - croak "Moose::Role do not currently support " + croak "Roles do not currently support " . ref($_) . " references for after method modifiers" if ref $_; @@ -79,7 +80,7 @@ sub around { my $meta = Moose::Meta::Role->initialize(shift); my $code = pop @_; for (@_) { - croak "Moose::Role do not currently support " + croak "Roles do not currently support " . ref($_) . " references for around method modifiers" if ref $_; @@ -100,14 +101,14 @@ sub override { } sub inner { - croak "Moose::Role cannot support 'inner'"; + croak "Roles cannot support 'inner'"; } sub augment { - croak "Moose::Role cannot support 'augment'"; + croak "Roles cannot support 'augment'"; } -my $exporter = Moose::Exporter->setup_import_methods( +Moose::Exporter->setup_import_methods( with_caller => [ qw( with requires excludes has before after around override make_immutable ) ], @@ -123,8 +124,7 @@ sub init_meta { my %args = @_; my $role = $args{for_class} - or confess - "Cannot call init_meta without specifying a for_class"; + or Moose->throw_error("Cannot call init_meta without specifying a for_class"); my $metaclass = $args{metaclass} || "Moose::Meta::Role"; @@ -136,7 +136,7 @@ sub init_meta { if ($role->can('meta')) { $meta = $role->meta(); (blessed($meta) && $meta->isa('Moose::Meta::Role')) - || confess "You already have a &meta function, but it does not return a Moose::Meta::Role"; + || Moose->throw_error("You already have a &meta function, but it does not return a Moose::Meta::Role"); } else { $meta = $metaclass->initialize($role); @@ -262,13 +262,9 @@ ordering. =item * -The C keyword currently only works with actual methods. A method -modifier (before/around/after and override) will not count as a fufillment -of the requirement, and neither will an autogenerated accessor for an attribute. - -It is likely that attribute accessors will eventually be allowed to fufill those -requirements, or we will introduce a C keyword of some kind -instead. This decision has not yet been finalized. +The C keyword currently only works with actual methods. A +method modifier (before/around/after and override) will not count as a +fulfillment of the requirement. =back @@ -286,7 +282,7 @@ Christian Hansen Echansen@cpan.orgE =head1 COPYRIGHT AND LICENSE -Copyright 2006-2008 by Infinity Interactive, Inc. +Copyright 2006-2009 by Infinity Interactive, Inc. L