X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FObject.pm;h=6f38a9853e6efb931be480c942e1e5334e4819c5;hb=2ae1457eead0263b687bd59cd3630b893618e551;hp=bb7accf55fa279e049fcd49e7c0459b431a6f42e;hpb=5ef36adde3d619733607b9f5f1136524a00848df;p=gitmo%2FMoose.git diff --git a/lib/Moose/Object.pm b/lib/Moose/Object.pm index bb7accf..6f38a98 100644 --- a/lib/Moose/Object.pm +++ b/lib/Moose/Object.pm @@ -4,14 +4,15 @@ package Moose::Object; use strict; use warnings; -use Devel::GlobalDestruction qw(in_global_destruction); -use MRO::Compat; -use Scalar::Util; +use Devel::GlobalDestruction (); +use MRO::Compat (); +use Scalar::Util (); +use Try::Tiny (); use if ( not our $__mx_is_compiled ), 'Moose::Meta::Class'; use if ( not our $__mx_is_compiled ), metaclass => 'Moose::Meta::Class'; -our $VERSION = '0.85'; +our $VERSION = '0.95'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; @@ -20,8 +21,6 @@ sub new { my $params = $class->BUILDARGS(@_); - # We want to support passing $self->new, but initialize - # takes only an unblessed class name my $real_class = Scalar::Util::blessed($class) || $class; my $self = Class::MOP::Class->initialize($real_class)->new_object($params); @@ -86,17 +85,21 @@ sub DEMOLISHALL { } sub DESTROY { - # if we have an exception here ... - if ($@) { - # localize the $@ ... - local $@; - # run DEMOLISHALL ourselves, ... - $_[0]->DEMOLISHALL(in_global_destruction); - # and return ... - return; + my $self = shift; + + local $?; + + Try::Tiny::try { + $self->DEMOLISHALL(Devel::GlobalDestruction::in_global_destruction); } - # otherwise it is normal destruction - $_[0]->DEMOLISHALL(in_global_destruction); + Try::Tiny::catch { + # Without this, Perl will warn "\t(in cleanup)$@" because of some + # bizarre fucked-up logic deep in the internals. + no warnings 'misc'; + die $_; + }; + + return; } # support for UNIVERSAL::DOES ... @@ -115,12 +118,8 @@ sub does { my ($self, $role_name) = @_; my $meta = Class::MOP::class_of($self); (defined $role_name) - || $meta->throw_error("You much supply a role name to does()"); - foreach my $class ($meta->class_precedence_list) { - my $m = $meta->initialize($class); - return 1 - if $m->can('does_role') && $m->does_role($role_name); - } + || $meta->throw_error("You must supply a role name to does()"); + return 1 if $meta->can('does_role') && $meta->does_role($role_name); return 0; } @@ -214,9 +213,7 @@ the maximum depth is 1, to avoid making a mess. =head1 BUGS -All complex software has bugs lurking in it, and this module is no -exception. If you find a bug please either email me, or add the bug -to cpan-RT. +See L for details on reporting bugs. =head1 AUTHOR @@ -224,7 +221,7 @@ Stevan Little Estevan@iinteractive.comE =head1 COPYRIGHT AND LICENSE -Copyright 2006-2009 by Infinity Interactive, Inc. +Copyright 2006-2010 by Infinity Interactive, Inc. L