X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FTypeConstraint%2FUnion.pm;h=54c59f65750e19a8aa38ae763bd6112749f7840c;hb=a94188ac85b86f501de86f25496e821e31d74cac;hp=0e434724b202e0b1184a50959610ca40a7ad236b;hpb=39b3bc94309529721acb365c64b2ff52a0c2be35;p=gitmo%2FMoose.git

diff --git a/lib/Moose/Meta/TypeConstraint/Union.pm b/lib/Moose/Meta/TypeConstraint/Union.pm
index 0e43472..54c59f6 100644
--- a/lib/Moose/Meta/TypeConstraint/Union.pm
+++ b/lib/Moose/Meta/TypeConstraint/Union.pm
@@ -5,7 +5,12 @@ use strict;
 use warnings;
 use metaclass;
 
-our $VERSION = '0.03';
+use Moose::Meta::TypeCoercion::Union;
+
+our $VERSION   = '0.56';
+our $AUTHORITY = 'cpan:STEVAN';
+
+use base 'Moose::Meta::TypeConstraint';
 
 __PACKAGE__->meta->add_attribute('type_constraints' => (
     accessor  => 'type_constraints',
@@ -13,76 +18,60 @@ __PACKAGE__->meta->add_attribute('type_constraints' => (
 ));
 
 sub new { 
-    my $class = shift;
-    my $self  = $class->meta->new_object(@_);
+    my ($class, %options) = @_;
+    my $self = $class->SUPER::new(
+        name     => (join ' | ' => map { $_->name } @{$options{type_constraints}}),
+        parent   => undef,
+        message  => undef,
+        hand_optimized_type_constraint => undef,
+        compiled_type_constraint => sub {
+            my $value = shift;
+            foreach my $type (@{$options{type_constraints}}) {
+                return 1 if $type->check($value);
+            }
+            return undef;    
+        },
+        %options
+    );
+    $self->_set_constraint(sub { $self->check($_[0]) });
+    $self->coercion(Moose::Meta::TypeCoercion::Union->new(
+        type_constraint => $self
+    ));
     return $self;
 }
 
-sub name { join ' | ' => map { $_->name } @{$_[0]->type_constraints} }
+sub equals {
+    my ( $self, $type_or_name ) = @_;
 
-# NOTE:
-# this should probably never be used
-# but we include it here for completeness
-sub constraint    { 
-    my $self = shift;
-    sub { $self->check($_[0]) }; 
-}
+    my $other = Moose::Util::TypeConstraints::find_type_constraint($type_or_name);
 
-# conform to the TypeConstraint API
-sub parent        { undef  }
-sub message       { undef  }
-sub has_message   { 0      }
+    return unless $other->isa(__PACKAGE__);
 
-# FIXME:
-# not sure what this should actually do here
-sub coercion { undef  }
+    my @self_constraints  = @{ $self->type_constraints };
+    my @other_constraints = @{ $other->type_constraints };
 
-# this should probably be memoized
-sub has_coercion  {
-    my $self  = shift;
-    foreach my $type (@{$self->type_constraints}) {
-        return 1 if $type->has_coercion
-    }
-    return 0;    
-}
+    return unless @self_constraints == @other_constraints;
 
-# NOTE:
-# this feels too simple, and may not always DWIM
-# correctly, especially in the presence of 
-# close subtype relationships, however it should 
-# work for a fair percentage of the use cases
-sub coerce { 
-    my $self  = shift;
-    my $value = shift;
-    foreach my $type (@{$self->type_constraints}) {
-        if ($type->has_coercion) {
-            my $temp = $type->coerce($value);
-            return $temp if $self->check($temp);
+    # FIXME presort type constraints for efficiency?
+    constraint: foreach my $constraint ( @self_constraints ) {
+        for ( my $i = 0; $i < @other_constraints; $i++ ) {
+            if ( $constraint->equals($other_constraints[$i]) ) {
+                splice @other_constraints, $i, 1;
+                next constraint;
+            }
         }
     }
-    return undef;    
-}
 
-sub _compiled_type_constraint {
-    my $self  = shift;
-    return sub {
-        my $value = shift;
-        foreach my $type (@{$self->type_constraints}) {
-            return 1 if $type->check($value);
-        }
-        return undef;    
-    }
+    return @other_constraints == 0;
 }
 
-sub check {
-    my $self  = shift;
-    my $value = shift;
-    $self->_compiled_type_constraint->($value);
+sub parents {
+    my $self = shift;
+    $self->type_constraints;
 }
 
 sub validate {
-    my $self  = shift;
-    my $value = shift;
+    my ($self, $value) = @_;
     my $message;
     foreach my $type (@{$self->type_constraints}) {
         my $err = $type->validate($value);
@@ -117,43 +106,79 @@ __END__
 
 =head1 NAME
 
-=head1 SYNOPOSIS
+Moose::Meta::TypeConstraint::Union - A union of Moose type constraints
 
 =head1 DESCRIPTION
 
+This metaclass represents a union of Moose type constraints. More 
+details to be explained later (possibly in a Cookbook recipe).
+
+This actually used to be part of Moose::Meta::TypeConstraint, but it 
+is now better off in it's own file. 
+
 =head1 METHODS
 
+This class is not a subclass of Moose::Meta::TypeConstraint, 
+but it does provide the same API
+
 =over 4
 
-=item B<check>
+=item B<meta>
 
-=item B<coerce>
+=item B<new>
 
-=item B<coercion>
+=item B<name>
+
+=item B<type_constraints>
+
+=item B<parents>
 
 =item B<constraint>
 
-=item B<has_coercion>
+=item B<includes_type>
 
-=item B<has_message>
+=item B<equals>
+
+=back
+
+=head2 Overriden methods 
+
+=over 4
+
+=item B<check>
+
+=item B<coerce>
+
+=item B<validate>
 
 =item B<is_a_type_of>
 
 =item B<is_subtype_of>
 
-=item B<message>
+=back
 
-=item B<meta>
+=head2 Empty or Stub methods
 
-=item B<name>
+These methods tend to not be very relevant in 
+the context of a union. Either that or they are 
+just difficult to specify and not very useful 
+anyway. They are here for completeness.
 
-=item B<new>
+=over 4
 
 =item B<parent>
 
-=item B<type_constraints>
+=item B<coercion>
 
-=item B<validate>
+=item B<has_coercion>
+
+=item B<message>
+
+=item B<has_message>
+
+=item B<hand_optimized_type_constraint>
+
+=item B<has_hand_optimized_type_constraint>
 
 =back
 
@@ -167,11 +192,9 @@ to cpan-RT.
 
 Stevan Little E<lt>stevan@iinteractive.comE<gt>
 
-Yuval Kogman E<lt>nothingmuch@woobling.comE<gt>
-
 =head1 COPYRIGHT AND LICENSE
 
-Copyright 2006 by Infinity Interactive, Inc.
+Copyright 2006-2008 by Infinity Interactive, Inc.
 
 L<http://www.iinteractive.com>