X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FRole.pm;h=402ed6db00ce05e689a67e033dc42b15686cb1af;hb=c179d548a2336b7030c1801d44d1d26663d20676;hp=08f176c07edd19e15d1f2891d14b5ea0f3ca196b;hpb=09eeab068dd818b643161b16fcdb6247ad8a4b7b;p=gitmo%2FMoose.git diff --git a/lib/Moose/Meta/Role.pm b/lib/Moose/Meta/Role.pm index 08f176c..402ed6d 100644 --- a/lib/Moose/Meta/Role.pm +++ b/lib/Moose/Meta/Role.pm @@ -10,14 +10,14 @@ use Carp 'confess'; use Sub::Name 'subname'; use Devel::GlobalDestruction 'in_global_destruction'; -our $VERSION = '0.79'; +our $VERSION = '0.87'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; use Moose::Meta::Class; use Moose::Meta::Role::Method; use Moose::Meta::Role::Method::Required; -use Moose::Meta::Role::Method::Conflicted; +use Moose::Meta::Role::Method::Conflicting; use base 'Class::MOP::Module'; @@ -137,9 +137,27 @@ $META->add_attribute( ); $META->add_attribute( - 'conflicted_method_metaclass', - reader => 'conflicted_method_metaclass', - default => 'Moose::Meta::Role::Method::Conflicted', + 'conflicting_method_metaclass', + reader => 'conflicting_method_metaclass', + default => 'Moose::Meta::Role::Method::Conflicting', +); + +$META->add_attribute( + 'application_to_class_class', + reader => 'application_to_class_class', + default => 'Moose::Meta::Role::Application::ToClass', +); + +$META->add_attribute( + 'application_to_role_class', + reader => 'application_to_role_class', + default => 'Moose::Meta::Role::Application::ToRole', +); + +$META->add_attribute( + 'application_to_instance_class', + reader => 'application_to_instance_class', + default => 'Moose::Meta::Role::Application::ToInstance', ); ## some things don't always fit, so they go here ... @@ -175,7 +193,7 @@ sub add_required_methods { } } -sub add_conflicted_method { +sub add_conflicting_method { my $self = shift; my $method; @@ -183,7 +201,7 @@ sub add_conflicted_method { $method = shift; } else { - $method = $self->conflicted_method_metaclass->new(@_); + $method = $self->conflicting_method_metaclass->new(@_); } $self->add_required_methods($method); @@ -214,7 +232,8 @@ foreach my $modifier_type (qw[ before around after ]) { $META->add_method("get_${modifier_type}_method_modifiers" => sub { my ($self, $method_name) = @_; #return () unless exists $self->$attr_reader->{$method_name}; - @{$self->$attr_reader->{$method_name}}; + my $mm = $self->$attr_reader->{$method_name}; + $mm ? @$mm : (); }); $META->add_method("has_${modifier_type}_method_modifiers" => sub { @@ -477,18 +496,19 @@ sub apply { (blessed($other)) || Moose->throw_error("You must pass in an blessed instance"); + my $application_class; if ($other->isa('Moose::Meta::Role')) { - require Moose::Meta::Role::Application::ToRole; - return Moose::Meta::Role::Application::ToRole->new(@args)->apply($self, $other); + $application_class = $self->application_to_role_class; } elsif ($other->isa('Moose::Meta::Class')) { - require Moose::Meta::Role::Application::ToClass; - return Moose::Meta::Role::Application::ToClass->new(@args)->apply($self, $other); + $application_class = $self->application_to_class_class; } else { - require Moose::Meta::Role::Application::ToInstance; - return Moose::Meta::Role::Application::ToInstance->new(@args)->apply($self, $other); + $application_class = $self->application_to_instance_class; } + + Class::MOP::load_class($application_class); + return $application_class->new(@args)->apply($self, $other); } sub combine { @@ -792,7 +812,7 @@ This method creates a new role object with the provided name. This method accepts a list of array references. Each array reference should contain a role name as its first element. The second element is -an optional hash reference. The hash reference can contain C +an optional hash reference. The hash reference can contain C and C keys to control how methods are composed from the role. The return value is a new L that @@ -951,9 +971,9 @@ Adds the named methods to the role's list of required methods. Removes the named methods from the role's list of required methods. -=item B<< $metarole->add_conflicted_method(%params) >> +=item B<< $metarole->add_conflicting_method(%params) >> -Instantiate the parameters as a L +Instantiate the parameters as a L object, then add it to the required method list. =back