X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FRole%2FApplication%2FToInstance.pm;h=f1e3d4e5c38b0808b7ac6532c1d19a586dd4574d;hb=a4895a0e18511244dd0a27fb92c13eed64ef7ee3;hp=571f73f0c24071fbbcf7392d869abe97b3796c58;hpb=75b9541431131c67521bd1ec75df80c9707bd719;p=gitmo%2FMoose.git diff --git a/lib/Moose/Meta/Role/Application/ToInstance.pm b/lib/Moose/Meta/Role/Application/ToInstance.pm index 571f73f..f1e3d4e 100644 --- a/lib/Moose/Meta/Role/Application/ToInstance.pm +++ b/lib/Moose/Meta/Role/Application/ToInstance.pm @@ -4,10 +4,9 @@ use strict; use warnings; use metaclass; -use Carp 'confess'; use Scalar::Util 'blessed'; -our $VERSION = '0.55_01'; +our $VERSION = '0.97'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; @@ -18,27 +17,24 @@ __PACKAGE__->meta->add_attribute('rebless_params' => ( default => sub { {} } )); -my %ANON_CLASSES; - sub apply { - my ($self, $role, $object) = @_; - - my $anon_role_key = (blessed($object) . $role->name); - - my $class; - if (exists $ANON_CLASSES{$anon_role_key} && defined $ANON_CLASSES{$anon_role_key}) { - $class = $ANON_CLASSES{$anon_role_key}; - } - else { - my $obj_meta = eval { $object->meta } || 'Moose::Meta::Class'; - $class = $obj_meta->create_anon_class( - superclasses => [ blessed($object) ] - ); - $ANON_CLASSES{$anon_role_key} = $class; - $self->SUPER::apply($role, $class); - } - - $class->rebless_instance($object, %{$self->rebless_params}); + my ( $self, $role, $object ) = @_; + + my $obj_meta = Class::MOP::class_of($object) || 'Moose::Meta::Class'; + + # This is a special case to handle the case where the object's metaclass + # is a Class::MOP::Class, but _not_ a Moose::Meta::Class (for example, + # when applying a role to a Moose::Meta::Attribute object). + $obj_meta = 'Moose::Meta::Class' + unless $obj_meta->isa('Moose::Meta::Class'); + + my $class = $obj_meta->create_anon_class( + superclasses => [ blessed($object) ], + roles => [ $role ], + cache => 1, + ); + + $class->rebless_instance( $object, %{ $self->rebless_params } ); } 1; @@ -69,9 +65,7 @@ Moose::Meta::Role::Application::ToInstance - Compose a role into an instance =head1 BUGS -All complex software has bugs lurking in it, and this module is no -exception. If you find a bug please either email me, or add the bug -to cpan-RT. +See L for details on reporting bugs. =head1 AUTHOR @@ -79,7 +73,7 @@ Stevan Little Estevan@iinteractive.comE =head1 COPYRIGHT AND LICENSE -Copyright 2006-2008 by Infinity Interactive, Inc. +Copyright 2006-2010 by Infinity Interactive, Inc. L