X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FRole%2FApplication%2FToClass.pm;h=8573cc65de72c153ad40e68dd3103cb54023bcaa;hb=f4b86ac0e1fd7ff8a180f2f8332821170db5371e;hp=843b97a0d7c59e0afcb1516803af2b155d4156c2;hpb=4bf82ce13be926eca01d6b8f07b46625a98a56fa;p=gitmo%2FMoose.git diff --git a/lib/Moose/Meta/Role/Application/ToClass.pm b/lib/Moose/Meta/Role/Application/ToClass.pm index 843b97a..8573cc6 100644 --- a/lib/Moose/Meta/Role/Application/ToClass.pm +++ b/lib/Moose/Meta/Role/Application/ToClass.pm @@ -7,7 +7,7 @@ use metaclass; use Moose::Util 'english_list'; use Scalar::Util 'weaken', 'blessed'; -our $VERSION = '0.98'; +our $VERSION = '1.16'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; @@ -147,40 +147,43 @@ sub apply_attributes { } sub apply_methods { - my ($self, $role, $class) = @_; - foreach my $method_name ($role->get_method_list) { - next if $method_name eq 'meta'; - - unless ($self->is_method_excluded($method_name)) { - # it if it has one already - if ($class->has_method($method_name) && - # and if they are not the same thing ... - $class->get_method($method_name)->body != $role->get_method($method_name)->body) { - next; - } - else { - # add it, although it could be overridden - $class->add_method( - $method_name, - $role->get_method($method_name) - ); - } - } + my ( $self, $role, $class ) = @_; + + foreach my $method ( $role->_get_local_methods ) { + my $method_name = $method->name; + + next if $method->isa('Class::MOP::Method::Meta'); + + unless ( $self->is_method_excluded($method_name) ) { + + my $class_method = $class->get_method($method_name); + + next if $class_method && $class_method->body != $method->body; - if ($self->is_method_aliased($method_name)) { - my $aliased_method_name = $self->get_method_aliases->{$method_name}; - # it if it has one already - if ($class->has_method($aliased_method_name) && - # and if they are not the same thing ... - $class->get_method($aliased_method_name)->body != $role->get_method($method_name)->body) { - $class->throw_error("Cannot create a method alias if a local method of the same name exists"); - } $class->add_method( - $aliased_method_name, - $role->get_method($method_name) + $method_name, + $method, ); } + + next unless $self->is_method_aliased($method_name); + + my $aliased_method_name = $self->get_method_aliases->{$method_name}; + + my $class_method = $class->get_method($aliased_method_name); + + if ( $class_method && $class_method->body != $method->body ) { + $class->throw_error( + "Cannot create a method alias if a local method of the same name exists" + ); + } + + $class->add_method( + $aliased_method_name, + $method, + ); } + # we must reset the cache here since # we are just aliasing methods, otherwise # the modifiers go wonky.