X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FRole%2FApplication%2FToClass.pm;h=3a7099a6f6a4579e91fbfc42f9689a5b858623ff;hb=a3319906531cef2b41a87138e75461ced7a3394b;hp=f61cf03f0094dc59cb63aedd9115c37e949a57e8;hpb=59f5bbde66d61d15b684be88d138fd798ba851d0;p=gitmo%2FMoose.git diff --git a/lib/Moose/Meta/Role/Application/ToClass.pm b/lib/Moose/Meta/Role/Application/ToClass.pm index f61cf03..3a7099a 100644 --- a/lib/Moose/Meta/Role/Application/ToClass.pm +++ b/lib/Moose/Meta/Role/Application/ToClass.pm @@ -7,7 +7,7 @@ use metaclass; use Moose::Util 'english_list'; use Scalar::Util 'blessed'; -our $VERSION = '0.64'; +our $VERSION = '0.73_01'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; @@ -51,32 +51,9 @@ sub check_required_methods { push @missing, $required_method_name; } - else { - # NOTE: - # we need to make sure that the method is - # not a method modifier, because those do - # not satisfy the requirements ... - my $method = $class->find_method_by_name($required_method_name); - - # check if it is a generated accessor ... - push @is_attr, $required_method_name, - if $method->isa('Class::MOP::Method::Accessor'); - - # NOTE: - # All other tests here have been removed, they were tests - # for overriden methods and before/after/around modifiers. - # But we realized that for classes any overriden or modified - # methods would be backed by a real method of that name - # (and therefore meet the requirement). And for roles, the - # overriden and modified methods are "in statis" and so would - # not show up in this test anyway (and as a side-effect they - # would not fufill the requirement, which is exactly what we - # want them to do anyway). - # - SL - } } - return unless @missing || @is_attr; + return unless @missing; my $error = ''; @@ -94,23 +71,6 @@ sub check_required_methods { . $class->name . q{'}; } - if (@is_attr) { - my $noun = @is_attr == 1 ? 'method' : 'methods'; - - my $list - = Moose::Util::english_list( map { q{'} . $_ . q{'} } @is_attr ); - - $error .= "\n" if length $error; - - $error - .= q{'} - . $role->name - . "' requires the $noun $list " - . "to be implemented by '" - . $class->name - . "' but the method is only an attribute accessor"; - } - $class->throw_error($error); } @@ -148,7 +108,7 @@ sub apply_methods { next; } else { - # add it, although it could be overriden + # add it, although it could be overridden $class->add_method( $method_name, $role->get_method($method_name) @@ -258,7 +218,7 @@ Stevan Little Estevan@iinteractive.comE =head1 COPYRIGHT AND LICENSE -Copyright 2006-2008 by Infinity Interactive, Inc. +Copyright 2006-2009 by Infinity Interactive, Inc. L